From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19071 invoked by alias); 22 Oct 2009 16:30:07 -0000 Received: (qmail 19028 invoked by uid 22791); 22 Oct 2009 16:30:04 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Oct 2009 16:29:59 +0000 Received: from zps77.corp.google.com (zps77.corp.google.com [172.25.146.77]) by smtp-out.google.com with ESMTP id n9MGTtxw011193 for ; Thu, 22 Oct 2009 17:29:56 +0100 Received: from ywh36 (ywh36.prod.google.com [10.192.8.36]) by zps77.corp.google.com with ESMTP id n9MGTq5H019519 for ; Thu, 22 Oct 2009 09:29:53 -0700 Received: by ywh36 with SMTP id 36so7482612ywh.15 for ; Thu, 22 Oct 2009 09:29:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.186.12 with SMTP id n12mr1214730anp.111.1256228992648; Thu, 22 Oct 2009 09:29:52 -0700 (PDT) In-Reply-To: <8ac60eac0910220833v96b75i379486328b8f7955@mail.gmail.com> References: <8ac60eac0910212148w24f44d53xfa6bedd7e12b41d1@mail.gmail.com> <20091022054758.GA15116@host0.dyn.jankratochvil.net> <8ac60eac0910212314h3517ff9btcad84f8d0978bddb@mail.gmail.com> <200910221142.55021.pedro@codesourcery.com> <8ac60eac0910220833v96b75i379486328b8f7955@mail.gmail.com> Date: Thu, 22 Oct 2009 16:30:00 -0000 Message-ID: <8ac60eac0910220929v4cad21b4gcf706be716b13771@mail.gmail.com> Subject: Re: [patch] Fix for PR gdb/10819 From: Paul Pluzhnikov To: Andreas Schwab Cc: Pedro Alves , gdb-patches@sourceware.org, Jan Kratochvil Content-Type: multipart/mixed; boundary=001636c9297bdd06bc0476889a92 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00523.txt.bz2 --001636c9297bdd06bc0476889a92 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 722 On Thu, Oct 22, 2009 at 8:33 AM, Paul Pluzhnikov wrote: > I'll just fix the bsearch calls, since A) one of them is known to > cause a problem and B) I introduced them recently :-( Here is the revised patch. The call to bsearch in dwarf2_frame_find_fde is already preceded by assert of "fde_table->num_entries > 0", so no changes are needed there. There is one more call to bsearch in solib-osf.c, but that file appears to not be used anymore. Ok to deleted it? Thanks, -- Paul Pluzhnikov 2009-10-22 Paul Pluzhnikov PR gdb/10819 * dwarf2-frame.c (find_cie): Don't call bsearch on empty cie_table. * objfiles.c (find_pc_section): Likewise. --001636c9297bdd06bc0476889a92 Content-Type: text/plain; charset=US-ASCII; name="gdb-pr10819-20091022-2.txt" Content-Disposition: attachment; filename="gdb-pr10819-20091022-2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g13q8v7r0 Content-length: 2327 SW5kZXg6IGR3YXJmMi1mcmFtZS5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvZHdhcmYyLWZyYW1lLmMsdgpy ZXRyaWV2aW5nIHJldmlzaW9uIDEuMTAwCmRpZmYgLXUgLXAgLXUgLXIxLjEw MCBkd2FyZjItZnJhbWUuYwotLS0gZHdhcmYyLWZyYW1lLmMJNiBPY3QgMjAw OSAyMzoyNzowNCAtMDAwMAkxLjEwMAorKysgZHdhcmYyLWZyYW1lLmMJMjIg T2N0IDIwMDkgMTY6MjE6MTcgLTAwMDAKQEAgLTE1MjUsNiArMTUyNSwyMiBA QCBmaW5kX2NpZSAoc3RydWN0IGR3YXJmMl9jaWVfdGFibGUgKmNpZV90CiB7 CiAgIHN0cnVjdCBkd2FyZjJfY2llICoqcF9jaWU7CiAKKyAgaWYgKGNpZV90 YWJsZS0+bnVtX2VudHJpZXMgPT0gMCkKKyAgICB7CisgICAgICBnZGJfYXNz ZXJ0IChjaWVfdGFibGUtPmVudHJpZXMgPT0gTlVMTCk7CisKKyAgICAgIC8q IFRoZSBDIHN0YW5kYXJkIChJU08vSUVDIDk4OTk6VEMyKSByZXF1aXJlcyB0 aGUgQkFTRSBhcmd1bWVudCB0bworCSBic2VhcmNoIGJlIGEgdmFsaWQgcG9p bnRlciBldmVuIHdoZW4gdGhlIE5NRU1CIGFyZ3VtZW50IGlzIDAuCisKKwkg UGFzc2luZyBOVUxMIGZvciBCQVNFIGFuZCAwIGZvciBOTUVNQiBpcyBhbHNv IGtub3duIHRvIGNhdXNlCisJIFNvbGFyaXMtOCBic2VhcmNoIHRvIGNhbGwg YnNlYXJjaF9jaWVfY21wIHdpdGggTlVMTCBFTEVNRU5UCisJICh3aGljaCBk b2Vzbid0IGV4cGVjdCB0aGF0IGFuZCBjcmFzaGVzKTsgc2VlIFBSIGdkYi8x MDgxOS4KKworCSBUaGVyZWZvcmUsIGF2b2lkIGNhbGxpbmcgYnNlYXJjaCB1 bmRlciB0aGVzZSBjb25kaXRpb25zLiAgKi8KKworICAgICAgcmV0dXJuIE5V TEw7CisgICAgfQorCiAgIHBfY2llID0gYnNlYXJjaCAoJmNpZV9wb2ludGVy LCBjaWVfdGFibGUtPmVudHJpZXMsIGNpZV90YWJsZS0+bnVtX2VudHJpZXMs CiAgICAgICAgICAgICAgICAgICAgc2l6ZW9mIChjaWVfdGFibGUtPmVudHJp ZXNbMF0pLCBic2VhcmNoX2NpZV9jbXApOwogICBpZiAocF9jaWUgIT0gTlVM TCkKSW5kZXg6IG9iamZpbGVzLmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9vYmpmaWxlcy5jLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjk5CmRpZmYgLXUgLXAgLXUgLXIxLjk5IG9iamZp bGVzLmMKLS0tIG9iamZpbGVzLmMJMTkgT2N0IDIwMDkgMDk6NTE6NDEgLTAw MDAJMS45OQorKysgb2JqZmlsZXMuYwkyMiBPY3QgMjAwOSAxNjoyMToxNyAt MDAwMApAQCAtMTE3NSw2ICsxMTc1LDExIEBAIGZpbmRfcGNfc2VjdGlvbiAo Q09SRV9BRERSIHBjKQogICAgICAgcHNwYWNlX2luZm8tPm9iamZpbGVzX2No YW5nZWRfcCA9IDA7CiAgICAgfQogCisgIC8qIFNlZSBjb21tZW50IGluIGR3 YXJmMi1mcmFtZS5jOmZpbmRfY2llIG9uIHdoeSB0aGlzIGNoZWNrCisgICAg IGlzIG5lY2Vzc2FyeS4gICovCisgIGlmIChwc3BhY2VfaW5mby0+bnVtX3Nl Y3Rpb25zID09IDApCisgICAgcmV0dXJuIE5VTEw7CisKICAgc3AgPSAoc3Ry dWN0IG9ial9zZWN0aW9uICoqKSBic2VhcmNoICgmcGMsCiAJCQkJCXBzcGFj ZV9pbmZvLT5zZWN0aW9ucywKIAkJCQkJcHNwYWNlX2luZm8tPm51bV9zZWN0 aW9ucywK --001636c9297bdd06bc0476889a92--