From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11705 invoked by alias); 21 Oct 2009 22:45:35 -0000 Received: (qmail 11671 invoked by uid 22791); 21 Oct 2009 22:45:31 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Oct 2009 22:45:23 +0000 Received: from spaceape8.eur.corp.google.com (spaceape8.eur.corp.google.com [172.28.16.142]) by smtp-out.google.com with ESMTP id n9LMjKe9017843 for ; Wed, 21 Oct 2009 15:45:20 -0700 Received: from yxe33 (yxe33.prod.google.com [10.190.2.33]) by spaceape8.eur.corp.google.com with ESMTP id n9LMiojQ002581 for ; Wed, 21 Oct 2009 15:45:17 -0700 Received: by yxe33 with SMTP id 33so9920534yxe.0 for ; Wed, 21 Oct 2009 15:45:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.20.4 with SMTP id x4mr5211618ani.93.1256165117055; Wed, 21 Oct 2009 15:45:17 -0700 (PDT) Date: Wed, 21 Oct 2009 22:45:00 -0000 Message-ID: <8ac60eac0910211545s143ae258s81b3a647c6873351@mail.gmail.com> Subject: [patch] Omit function name when disassembling one function [Was: Re: [RFC][patch] Allow to disassemble line.] From: Paul Pluzhnikov To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org, Paul Pluzhnikov Content-Type: multipart/mixed; boundary=00504502953894e320047679bb95 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00505.txt.bz2 --00504502953894e320047679bb95 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 949 On Mon, Oct 19, 2009 at 1:23 PM, Paul Pluzhnikov wrote: > On Mon, Oct 19, 2009 at 1:10 PM, Joel Brobecker wrote: > >> I really like the idea of not printing the name of the function >> in the disassembly output, though. > I can do that in a separate patch. Here is proposed patch. Tested on Linux/x86_64 with no regressions. Thanks, -- Paul Pluzhnikov doc/ChangeLog: 2009-10-21 Paul Pluzhnikov * gdb.texinfo (Machine Code): Mention function name in disasssembly and adjust example. testsuite/ChangeLog: 2009-10-21 Paul Pluzhnikov * gdb.asm/asm-source.exp: Adjust. 2009-10-21 Paul Pluzhnikov * disasm.h (DISASSEMBLY_OMIT_FNAME) New define. (gdb_disassembly): Correct parameter name. * disasm.c (dump_insns): Adjust. (gdb_disassembly): Fix indentation. * cli/cli-cmds.c (disassemble_command): Adjust. --00504502953894e320047679bb95 Content-Type: text/plain; charset=US-ASCII; name="gdb-disas-20091021.txt" Content-Disposition: attachment; filename="gdb-disas-20091021.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g12o36rz0 Content-length: 8020 SW5kZXg6IGRvYy9nZGIudGV4aW5mbwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2RvYy9nZGIudGV4aW5mbyx2 CnJldHJpZXZpbmcgcmV2aXNpb24gMS42MzUKZGlmZiAtdSAtcCAtdSAtcjEu NjM1IGdkYi50ZXhpbmZvCi0tLSBkb2MvZ2RiLnRleGluZm8JMjEgT2N0IDIw MDkgMTg6MDI6MjYgLTAwMDAJMS42MzUKKysrIGRvYy9nZGIudGV4aW5mbwky MSBPY3QgMjAwOSAyMjozNzo0MSAtMDAwMApAQCAtNjUyNCw3ICs2NTI0LDkg QEAgVGhlIGRlZmF1bHQgbWVtb3J5IHJhbmdlIGlzIHRoZSBmdW5jdGlvbgog cHJvZ3JhbSBjb3VudGVyIG9mIHRoZSBzZWxlY3RlZCBmcmFtZS4gIEEgc2lu Z2xlIGFyZ3VtZW50IHRvIHRoaXMKIGNvbW1hbmQgaXMgYSBwcm9ncmFtIGNv dW50ZXIgdmFsdWU7IEB2YWx1ZXtHREJOfSBkdW1wcyB0aGUgZnVuY3Rpb24K IHN1cnJvdW5kaW5nIHRoaXMgdmFsdWUuICBUd28gYXJndW1lbnRzIHNwZWNp ZnkgYSByYW5nZSBvZiBhZGRyZXNzZXMKLShmaXJzdCBpbmNsdXNpdmUsIHNl Y29uZCBleGNsdXNpdmUpIHRvIGR1bXAuCisoZmlyc3QgaW5jbHVzaXZlLCBz ZWNvbmQgZXhjbHVzaXZlKSB0byBkdW1wLiAgSW4gdGhhdCBjYXNlLCB0aGUg bmFtZSBvZgordGhlIGZ1bmN0aW9uIGlzIGFsc28gcHJpbnRlZCAoc2luY2Ug dGhlcmUgY291bGQgYmUgc2V2ZXJhbCBmdW5jdGlvbnMgaW4KK3RoZSBnaXZl biByYW5nZSkuCiAKIElmIHRoZSByYW5nZSBvZiBtZW1vcnkgYmVpbmcgZGlz YXNzZW1ibGVkIGNvbnRhaW5zIGN1cnJlbnQgcHJvZ3JhbSBjb3VudGVyLAog dGhlIGluc3RydWN0aW9uIGF0IHRoYXQgbG9jYXRpb24gaXMgc2hvd24gd2l0 aCBhIEBjb2Rlez0+fSBtYXJrZXIuCkBAIC02NTU0LDIxICs2NTU2LDIxIEBA IHByb2dyYW0gaXMgc3RvcHBlZCBqdXN0IGFmdGVyIGZ1bmN0aW9uIHAKIChA dmFsdWV7R0RCUH0pIGRpc2FzIC9tIG1haW4KIER1bXAgb2YgYXNzZW1ibGVy IGNvZGUgZm9yIGZ1bmN0aW9uIG1haW46CiA1ICAgICAgIEB7Ci0gICAweDA4 MDQ4MzMwIDxtYWluKzA+OiAgICBwdXNoICAgJWVicAotICAgMHgwODA0ODMz MSA8bWFpbisxPjogICAgbW92ICAgICVlc3AsJWVicAotICAgMHgwODA0ODMz MyA8bWFpbiszPjogICAgc3ViICAgICQweDgsJWVzcAotICAgMHgwODA0ODMz NiA8bWFpbis2PjogICAgYW5kICAgICQweGZmZmZmZmYwLCVlc3AKLSAgIDB4 MDgwNDgzMzkgPG1haW4rOT46ICAgIHN1YiAgICAkMHgxMCwlZXNwCisgICAw eDA4MDQ4MzMwIDwrMD46ICAgIHB1c2ggICAlZWJwCisgICAweDA4MDQ4MzMx IDwrMT46ICAgIG1vdiAgICAlZXNwLCVlYnAKKyAgIDB4MDgwNDgzMzMgPCsz PjogICAgc3ViICAgICQweDgsJWVzcAorICAgMHgwODA0ODMzNiA8KzY+OiAg ICBhbmQgICAgJDB4ZmZmZmZmZjAsJWVzcAorICAgMHgwODA0ODMzOSA8Kzk+ OiAgICBzdWIgICAgJDB4MTAsJWVzcAogCiA2ICAgICAgICAgcHJpbnRmICgi SGVsbG8uXG4iKTsKLT0+IDB4MDgwNDgzM2MgPG1haW4rMTI+OiAgIG1vdmwg ICAkMHg4MDQ4NDQwLCglZXNwKQotICAgMHgwODA0ODM0MyA8bWFpbisxOT46 ICAgY2FsbCAgIDB4ODA0ODI4NCA8cHV0c0BAcGx0PgorPT4gMHgwODA0ODMz YyA8KzEyPjogICBtb3ZsICAgJDB4ODA0ODQ0MCwoJWVzcCkKKyAgIDB4MDgw NDgzNDMgPCsxOT46ICAgY2FsbCAgIDB4ODA0ODI4NCA8cHV0c0BAcGx0Pgog CiA3ICAgICAgICAgcmV0dXJuIDA7CiA4ICAgICAgIEB9Ci0gICAweDA4MDQ4 MzQ4IDxtYWluKzI0PjogICBtb3YgICAgJDB4MCwlZWF4Ci0gICAweDA4MDQ4 MzRkIDxtYWluKzI5PjogICBsZWF2ZQotICAgMHgwODA0ODM0ZSA8bWFpbisz MD46ICAgcmV0CisgICAweDA4MDQ4MzQ4IDwrMjQ+OiAgIG1vdiAgICAkMHgw LCVlYXgKKyAgIDB4MDgwNDgzNGQgPCsyOT46ICAgbGVhdmUKKyAgIDB4MDgw NDgzNGUgPCszMD46ICAgcmV0CiAKIEVuZCBvZiBhc3NlbWJsZXIgZHVtcC4K IEBlbmQgc21hbGxleGFtcGxlCkluZGV4OiBkaXNhc20uaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2Rpc2Fz bS5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzCmRpZmYgLXUgLXAgLXUg LXIxLjEzIGRpc2FzbS5oCi0tLSBkaXNhc20uaAkxMSBKdWwgMjAwOSAxNDow NDoyMyAtMDAwMAkxLjEzCisrKyBkaXNhc20uaAkyMSBPY3QgMjAwOSAyMjoz Nzo0MSAtMDAwMApAQCAtMjEsMTQgKzIxLDE0IEBACiAKICNkZWZpbmUgRElT QVNTRU1CTFlfU09VUkNFCSgweDEgPDwgMCkKICNkZWZpbmUgRElTQVNTRU1C TFlfUkFXX0lOU04JKDB4MSA8PCAxKQorI2RlZmluZSBESVNBU1NFTUJMWV9P TUlUX0ZOQU1FCSgweDEgPDwgMikKIAogc3RydWN0IHVpX291dDsKIHN0cnVj dCB1aV9maWxlOwogCiBleHRlcm4gdm9pZCBnZGJfZGlzYXNzZW1ibHkgKHN0 cnVjdCBnZGJhcmNoICpnZGJhcmNoLCBzdHJ1Y3QgdWlfb3V0ICp1aW91dCwK LQkJCSAgICAgY2hhciAqZmlsZV9zdHJpbmcsCi0JCQkgICAgIGludCBtaXhl ZF9zb3VyY2VfYW5kX2Fzc2VtYmx5LAotCQkJICAgICBpbnQgaG93X21hbnks IENPUkVfQUREUiBsb3csIENPUkVfQUREUiBoaWdoKTsKKwkJCSAgICAgY2hh ciAqZmlsZV9zdHJpbmcsIGludCBmbGFncywgaW50IGhvd19tYW55LAorCQkJ ICAgICBDT1JFX0FERFIgbG93LCBDT1JFX0FERFIgaGlnaCk7CiAKIC8qIFBy aW50IHRoZSBpbnN0cnVjdGlvbiBhdCBhZGRyZXNzIE1FTUFERFIgaW4gZGVi dWdnZWQgbWVtb3J5LAogICAgb24gU1RSRUFNLiAgUmV0dXJucyB0aGUgbGVu Z3RoIG9mIHRoZSBpbnN0cnVjdGlvbiwgaW4gYnl0ZXMsCkluZGV4OiBkaXNh c20uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Ny Yy9zcmMvZ2RiL2Rpc2FzbS5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjM0 CmRpZmYgLXUgLXAgLXUgLXIxLjM0IGRpc2FzbS5jCi0tLSBkaXNhc20uYwky MSBPY3QgMjAwOSAxODowMjoyNSAtMDAwMAkxLjM0CisrKyBkaXNhc20uYwky MSBPY3QgMjAwOSAyMjozNzo0MSAtMDAwMApAQCAtMTIyLDcgKzEyMiw4IEBA IGR1bXBfaW5zbnMgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLCBzdHIKIAkg IC8qIFdlIGRvbid0IGNhcmUgbm93IGFib3V0IGxpbmUsIGZpbGVuYW1lIGFu ZAogCSAgICAgdW5tYXBwZWQuIEJ1dCB3ZSBtaWdodCBpbiB0aGUgZnV0dXJl LiAqLwogCSAgdWlfb3V0X3RleHQgKHVpb3V0LCAiIDwiKTsKLQkgIHVpX291 dF9maWVsZF9zdHJpbmcgKHVpb3V0LCAiZnVuYy1uYW1lIiwgbmFtZSk7CisJ ICBpZiAoKGZsYWdzICYgRElTQVNTRU1CTFlfT01JVF9GTkFNRSkgPT0gMCkK KwkgICAgdWlfb3V0X2ZpZWxkX3N0cmluZyAodWlvdXQsICJmdW5jLW5hbWUi LCBuYW1lKTsKIAkgIHVpX291dF90ZXh0ICh1aW91dCwgIisiKTsKIAkgIHVp X291dF9maWVsZF9pbnQgKHVpb3V0LCAib2Zmc2V0Iiwgb2Zmc2V0KTsKIAkg IHVpX291dF90ZXh0ICh1aW91dCwgIj46XHQiKTsKQEAgLTM3Myw5ICszNzQs OCBAQCBnZGJfZGlzYXNzZW1ibGVfaW5mbyAoc3RydWN0IGdkYmFyY2ggKmdk CiAKIHZvaWQKIGdkYl9kaXNhc3NlbWJseSAoc3RydWN0IGdkYmFyY2ggKmdk YmFyY2gsIHN0cnVjdCB1aV9vdXQgKnVpb3V0LAotCQljaGFyICpmaWxlX3N0 cmluZywKLQkJaW50IGZsYWdzLAotCQlpbnQgaG93X21hbnksIENPUkVfQURE UiBsb3csIENPUkVfQUREUiBoaWdoKQorCQkgY2hhciAqZmlsZV9zdHJpbmcs IGludCBmbGFncywgaW50IGhvd19tYW55LAorCQkgQ09SRV9BRERSIGxvdywg Q09SRV9BRERSIGhpZ2gpCiB7CiAgIHN0cnVjdCB1aV9zdHJlYW0gKnN0YiA9 IHVpX291dF9zdHJlYW1fbmV3ICh1aW91dCk7CiAgIHN0cnVjdCBjbGVhbnVw ICpjbGVhbnVwcyA9IG1ha2VfY2xlYW51cF91aV9vdXRfc3RyZWFtX2RlbGV0 ZSAoc3RiKTsKSW5kZXg6IGNsaS9jbGktY21kcy5jCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvY2xpL2NsaS1j bWRzLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOTIKZGlmZiAtdSAtcCAt dSAtcjEuOTIgY2xpLWNtZHMuYwotLS0gY2xpL2NsaS1jbWRzLmMJMTEgSnVs IDIwMDkgMTQ6MDQ6MjMgLTAwMDAJMS45MgorKysgY2xpL2NsaS1jbWRzLmMJ MjEgT2N0IDIwMDkgMjI6Mzc6NDEgLTAwMDAKQEAgLTkzNiw4ICs5MzYsNyBA QCBwcmludF9kaXNhc3NlbWJseSAoc3RydWN0IGdkYmFyY2ggKmdkYmFyCiB9 CiAKIC8qIFN1YnJvdXRpbmUgb2YgZGlzYXNzZW1ibGVfY29tbWFuZCB0byBz aW1wbGlmeSBpdC4KLSAgIFByaW50IGEgZGlzYXNzZW1ibHkgb2YgdGhlIGN1 cnJlbnQgZnVuY3Rpb24uCi0gICBNSVhFRCBpcyBub24temVybyB0byBwcmlu dCBzb3VyY2Ugd2l0aCB0aGUgYXNzZW1ibGVyLiAgKi8KKyAgIFByaW50IGEg ZGlzYXNzZW1ibHkgb2YgdGhlIGN1cnJlbnQgZnVuY3Rpb24gYWNjb3JkaW5n IHRvIEZMQUdTLiAgKi8KIAogc3RhdGljIHZvaWQKIGRpc2Fzc2VtYmxlX2N1 cnJlbnRfZnVuY3Rpb24gKGludCBmbGFncykKQEAgLTEwMTgsNiArMTAxNyw3 IEBAIGRpc2Fzc2VtYmxlX2NvbW1hbmQgKGNoYXIgKmFyZywgaW50IGZyb20K IAogICBpZiAoISBhcmcgfHwgISAqYXJnKQogICAgIHsKKyAgICAgIGZsYWdz IHw9IERJU0FTU0VNQkxZX09NSVRfRk5BTUU7CiAgICAgICBkaXNhc3NlbWJs ZV9jdXJyZW50X2Z1bmN0aW9uIChmbGFncyk7CiAgICAgICByZXR1cm47CiAg ICAgfQpAQCAtMTAzOSw2ICsxMDM5LDcgQEAgZGlzYXNzZW1ibGVfY29tbWFu ZCAoY2hhciAqYXJnLCBpbnQgZnJvbQogCWxvdyA9IHR1aV9nZXRfbG93X2Rp c2Fzc2VtYmx5X2FkZHJlc3MgKGdkYmFyY2gsIGxvdywgcGMpOwogI2VuZGlm CiAgICAgICBsb3cgKz0gZ2RiYXJjaF9kZXByZWNhdGVkX2Z1bmN0aW9uX3N0 YXJ0X29mZnNldCAoZ2RiYXJjaCk7CisgICAgICBmbGFncyB8PSBESVNBU1NF TUJMWV9PTUlUX0ZOQU1FOwogICAgIH0KICAgZWxzZQogICAgIHsKSW5kZXg6 IHRlc3RzdWl0ZS9nZGIuYXNtL2FzbS1zb3VyY2UuZXhwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvdGVzdHN1 aXRlL2dkYi5hc20vYXNtLXNvdXJjZS5leHAsdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuNzQKZGlmZiAtdSAtcCAtdSAtcjEuNzQgYXNtLXNvdXJjZS5leHAK LS0tIHRlc3RzdWl0ZS9nZGIuYXNtL2FzbS1zb3VyY2UuZXhwCTE4IE1heSAy MDA5IDEzOjI1OjM0IC0wMDAwCTEuNzQKKysrIHRlc3RzdWl0ZS9nZGIuYXNt L2FzbS1zb3VyY2UuZXhwCTIxIE9jdCAyMDA5IDIyOjM3OjQxIC0wMDAwCkBA IC00NjEsNyArNDYxLDcgQEAgdGVzdF9kaXMgIngvaSAmc3RhdGljdmFyIiAi c3RhdGljdmFyIgogdGVzdF9kaXMgImRpc2Fzc2VtICZzdGF0aWN2YXIgJnN0 YXRpY3ZhcisxIiAic3RhdGljdmFyIgogCiAjIFNlZSBpZiB3ZSBjYW4gbG9v ayBhdCBhIHN0YXRpYyBmdW5jdGlvbgotZ2RiX3Rlc3QgImRpc2Fzc2VtIGZv b3N0YXRpYyIgIi4qPGZvb3N0YXRpY1xcKzA+Oi4qRW5kIG9mIGFzc2VtYmxl ciBkdW1wLiIgXAorZ2RiX3Rlc3QgImRpc2Fzc2VtIGZvb3N0YXRpYyIgIi4q PFxcKzA+Oi4qRW5kIG9mIGFzc2VtYmxlciBkdW1wLiIgXAogCSJsb29rIGF0 IHN0YXRpYyBmdW5jdGlvbiIKIAogcmVtb3RlX2V4ZWMgYnVpbGQgInJtIC1m ICR7c3ViZGlyfS9hcmNoLmluYyIK --00504502953894e320047679bb95--