From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16452 invoked by alias); 19 Oct 2009 18:20:09 -0000 Received: (qmail 16440 invoked by uid 22791); 19 Oct 2009 18:20:07 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Oct 2009 18:20:03 +0000 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id n9JIJxeq005201 for ; Mon, 19 Oct 2009 19:20:00 +0100 Received: from ywh29 (ywh29.prod.google.com [10.192.8.29]) by wpaz24.hot.corp.google.com with ESMTP id n9JIJv0k012623 for ; Mon, 19 Oct 2009 11:19:57 -0700 Received: by ywh29 with SMTP id 29so4490760ywh.32 for ; Mon, 19 Oct 2009 11:19:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.111.12 with SMTP id o12mr3711325anm.51.1255976396925; Mon, 19 Oct 2009 11:19:56 -0700 (PDT) In-Reply-To: <8ac60eac0910191109v62794c33g6712090912b5c11f@mail.gmail.com> References: <20091002004954.8966C76B2B@ppluzhnikov.mtv.corp.google.com> <8ac60eac0910080916i5a2eb49an5f21f3b5c7fb96ef@mail.gmail.com> <20091008162350.GA8625@caradoc.them.org> <8ac60eac0910080952p46f15693x6ed339473db0139d@mail.gmail.com> <8ac60eac0910161607k55fee22cs379c5b7635d7b6a@mail.gmail.com> <8ac60eac0910191109v62794c33g6712090912b5c11f@mail.gmail.com> Date: Mon, 19 Oct 2009 18:20:00 -0000 Message-ID: <8ac60eac0910191119l6e119257q2a0f1860874e685@mail.gmail.com> Subject: Re: [RFC][patch] Allow to disassemble line. From: Paul Pluzhnikov To: tromey@redhat.com Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001636ed7070fc2bd704764dca1f X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00437.txt.bz2 --001636ed7070fc2bd704764dca1f Content-Type: text/plain; charset=ISO-8859-1 Content-length: 570 On Mon, Oct 19, 2009 at 11:09 AM, Paul Pluzhnikov wrote: > Doing it the way you suggesed simplifies it a bit :-) The one-line print_pc_prefix() with a single caller doesn't really buy anything either. Eliminated. Thanks, -- Paul Pluzhnikov 2009-10-19 Paul Pluzhnikov * defs.h (pc_prefix): New prototype. * disasm.c (dump_insns): Mark current instruction. * printcmd.c (do_examine): Likewise. (pc_prefix): New function. * stack.c (print_frame_info): Disassemble entire current line. --001636ed7070fc2bd704764dca1f Content-Type: text/plain; charset=US-ASCII; name="gdb-disas-20091019-2.txt" Content-Disposition: attachment; filename="gdb-disas-20091019-2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g0zjvzpy1 Content-length: 4185 SW5kZXg6IGRlZnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3NyYy9zcmMvZ2RiL2RlZnMuaCx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS4yNTYKZGlmZiAtdSAtcCAtdSAtcjEuMjU2IGRlZnMuaAotLS0gZGVm cy5oCTE5IE9jdCAyMDA5IDA5OjUxOjQwIC0wMDAwCTEuMjU2CisrKyBkZWZz LmgJMTkgT2N0IDIwMDkgMTg6MTY6NTEgLTAwMDAKQEAgLTYwOCw2ICs2MDgs NyBAQCBleHRlcm4gaW50IGJ1aWxkX2FkZHJlc3Nfc3ltYm9saWMgKENPUkVf CiAJCQkJICAgaW50ICp1bm1hcHBlZCk7CiAKIGV4dGVybiB2b2lkIHByaW50 X2FkZHJlc3MgKHN0cnVjdCBnZGJhcmNoICosIENPUkVfQUREUiwgc3RydWN0 IHVpX2ZpbGUgKik7CitleHRlcm4gY29uc3QgY2hhciAqcGNfcHJlZml4IChD T1JFX0FERFIpOwogCiAvKiBGcm9tIHNvdXJjZS5jICovCiAKSW5kZXg6IGRp c2FzbS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv c3JjL3NyYy9nZGIvZGlzYXNtLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu MzMKZGlmZiAtdSAtcCAtdSAtcjEuMzMgZGlzYXNtLmMKLS0tIGRpc2FzbS5j CTExIEp1bCAyMDA5IDE0OjA0OjIzIC0wMDAwCTEuMzMKKysrIGRpc2FzbS5j CTE5IE9jdCAyMDA5IDE4OjE2OjUxIC0wMDAwCkBAIC0xMTMsNiArMTEzLDcg QEAgZHVtcF9pbnNucyAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsIHN0cgog CSAgICBudW1fZGlzcGxheWVkKys7CiAJfQogICAgICAgdWlfb3V0X2NoYWlu ID0gbWFrZV9jbGVhbnVwX3VpX291dF90dXBsZV9iZWdpbl9lbmQgKHVpb3V0 LCBOVUxMKTsKKyAgICAgIHVpX291dF90ZXh0ICh1aW91dCwgcGNfcHJlZml4 IChwYykpOwogICAgICAgdWlfb3V0X2ZpZWxkX2NvcmVfYWRkciAodWlvdXQs ICJhZGRyZXNzIiwgZ2RiYXJjaCwgcGMpOwogCiAgICAgICBpZiAoIWJ1aWxk X2FkZHJlc3Nfc3ltYm9saWMgKHBjLCAwLCAmbmFtZSwgJm9mZnNldCwgJmZp bGVuYW1lLApJbmRleDogcHJpbnRjbWQuYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL3ByaW50Y21kLmMsdgpy ZXRyaWV2aW5nIHJldmlzaW9uIDEuMTY1CmRpZmYgLXUgLXAgLXUgLXIxLjE2 NSBwcmludGNtZC5jCi0tLSBwcmludGNtZC5jCTE5IE9jdCAyMDA5IDA5OjUx OjQxIC0wMDAwCTEuMTY1CisrKyBwcmludGNtZC5jCTE5IE9jdCAyMDA5IDE4 OjE2OjUxIC0wMDAwCkBAIC03MjUsNiArNzI1LDI2IEBAIHByaW50X2FkZHJl c3MgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLAogICBwcmludF9hZGRyZXNz X3N5bWJvbGljIChhZGRyLCBzdHJlYW0sIGFzbV9kZW1hbmdsZSwgIiAiKTsK IH0KIAorLyogUmV0dXJuIGEgcHJlZml4IGZvciBpbnN0cnVjdGlvbiBhZGRy ZXNzOgorICAgIj0+ICIgZm9yIGN1cnJlbnQgaW5zdHJ1Y3Rpb24sIGVsc2Ug IiAgICIuICAqLworCitjb25zdCBjaGFyICoKK3BjX3ByZWZpeCAoQ09SRV9B RERSIGFkZHIpCit7CisgIGlmIChoYXNfc3RhY2tfZnJhbWVzICgpKQorICAg IHsKKyAgICAgIHN0cnVjdCBmcmFtZV9pbmZvICpmcmFtZTsKKyAgICAgIENP UkVfQUREUiBwYzsKKworICAgICAgZnJhbWUgPSBnZXRfc2VsZWN0ZWRfZnJh bWUgKE5VTEwpOworICAgICAgcGMgPSBnZXRfZnJhbWVfcGMgKGZyYW1lKTsK KworICAgICAgaWYgKHBjID09IGFkZHIpCisJcmV0dXJuICI9PiAiOworICAg IH0KKyAgcmV0dXJuICIgICAiOworfQorCiAvKiBQcmludCBhZGRyZXNzIEFE RFIgc3ltYm9saWNhbGx5IG9uIFNUUkVBTS4gIFBhcmFtZXRlciBERU1BTkdM RQogICAgY29udHJvbHMgd2hldGhlciB0byBwcmludCB0aGUgc3ltYm9saWMg bmFtZSAicmF3IiBvciBkZW1hbmdsZWQuCiAgICBHbG9iYWwgc2V0dGluZyAi YWRkcmVzc3ByaW50IiBjb250cm9scyB3aGV0aGVyIHRvIHByaW50IGhleCBh ZGRyZXNzCkBAIC04MTcsNiArODM3LDggQEAgZG9fZXhhbWluZSAoc3RydWN0 IGZvcm1hdF9kYXRhIGZtdCwgc3RydQogICB3aGlsZSAoY291bnQgPiAwKQog ICAgIHsKICAgICAgIFFVSVQ7CisgICAgICBpZiAoZm9ybWF0ID09ICdpJykK KwlmcHV0c19maWx0ZXJlZCAocGNfcHJlZml4IChuZXh0X2FkZHJlc3MpLCBn ZGJfc3Rkb3V0KTsKICAgICAgIHByaW50X2FkZHJlc3MgKG5leHRfZ2RiYXJj aCwgbmV4dF9hZGRyZXNzLCBnZGJfc3Rkb3V0KTsKICAgICAgIHByaW50Zl9m aWx0ZXJlZCAoIjoiKTsKICAgICAgIGZvciAoaSA9IG1heGVsdHM7CkluZGV4 OiBzdGFjay5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvc3JjL3NyYy9nZGIvc3RhY2suYyx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS4yMDgKZGlmZiAtdSAtcCAtdSAtcjEuMjA4IHN0YWNrLmMKLS0tIHN0YWNr LmMJMTkgT2N0IDIwMDkgMDk6NTE6NDIgLTAwMDAJMS4yMDgKKysrIHN0YWNr LmMJMTkgT2N0IDIwMDkgMTg6MTY6NTEgLTAwMDAKQEAgLTY0Myw4ICs2NDMs NyBAQCBwcmludF9mcmFtZV9pbmZvIChzdHJ1Y3QgZnJhbWVfaW5mbyAqZnJh CiAgICAgICAvKiBJZiBkaXNhc3NlbWJsZS1uZXh0LWxpbmUgaXMgc2V0IHRv IG9uIGFuZCB0aGVyZSBpcyBsaW5lIGRlYnVnCiAgICAgICAgICBtZXNzYWdl cywgb3V0cHV0IGFzc2VtYmx5IGNvZGVzIGZvciBuZXh0IGxpbmUuICAqLwog ICAgICAgaWYgKGRpc2Fzc2VtYmxlX25leHRfbGluZSA9PSBBVVRPX0JPT0xF QU5fVFJVRSkKLQlkb19nZGJfZGlzYXNzZW1ibHkgKGdldF9mcmFtZV9hcmNo IChmcmFtZSksIC0xLAotCQkJICAgIGdldF9mcmFtZV9wYyAoZnJhbWUpLCBz YWwuZW5kKTsKKwlkb19nZGJfZGlzYXNzZW1ibHkgKGdldF9mcmFtZV9hcmNo IChmcmFtZSksIC0xLCBzYWwucGMsIHNhbC5lbmQpOwogICAgIH0KIAogICBp ZiAocHJpbnRfd2hhdCAhPSBMT0NBVElPTikK --001636ed7070fc2bd704764dca1f--