On Mon, Oct 19, 2009 at 10:47 AM, Tom Tromey <tromey@redhat.com> wrote:

> Why not directly call ui_out_text in dump_insns?

I am not sure how I arrived at the proposed patch ...
Doing it the way you suggesed simplifies it a bit :-)

I've also changed the "current PC marker" from "* " to "=> " (as Eli
suggested), so the output looks like this:

(top) disas
Dump of assembler code for function gdb_main:
   0x0000000000454c9e <gdb_main+0>:     push   %rbp
   0x0000000000454c9f <gdb_main+1>:     mov    %rsp,%rbp
   0x0000000000454ca2 <gdb_main+4>:     sub    $0x10,%rsp
   0x0000000000454ca6 <gdb_main+8>:     mov    %rdi,-0x8(%rbp)
=> 0x0000000000454caa <gdb_main+12>:    mov    -0x8(%rbp),%rax
   0x0000000000454cae <gdb_main+16>:    mov    0x10(%rax),%eax
   0x0000000000454cb1 <gdb_main+19>:    mov    %eax,0x678475(%rip) #
0xacd12c <use_windows>


This patch still lacks documentation and test case updates. I'll work up
the complete patch if this one is OK.

Thanks,
-- 
Paul Pluzhnikov

2009-10-19  Paul Pluzhnikov  <ppluzhnikov@google.com>

       * defs.h (pc_prefix): New prototype.
       * disasm.c (dump_insns): Mark current instruction.
       * printcmd.c (do_examine): Likewise.
       (pc_prefix, print_pc_prefix): New function.
       * stack.c (print_frame_info): Disassemble entire current line.