From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1132 invoked by alias); 17 Oct 2009 23:26:06 -0000 Received: (qmail 1122 invoked by uid 22791); 17 Oct 2009 23:26:05 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Oct 2009 23:26:01 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id n9HNPwiL032505 for ; Sat, 17 Oct 2009 16:25:59 -0700 Received: from gxk27 (gxk27.prod.google.com [10.202.11.27]) by wpaz21.hot.corp.google.com with ESMTP id n9HNPuvk000394 for ; Sat, 17 Oct 2009 16:25:56 -0700 Received: by gxk27 with SMTP id 27so3042850gxk.7 for ; Sat, 17 Oct 2009 16:25:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.49.19 with SMTP id b19mr2842443ank.146.1255821956090; Sat, 17 Oct 2009 16:25:56 -0700 (PDT) In-Reply-To: <20091015191037.4091D76761@ppluzhnikov.mtv.corp.google.com> References: <20091015191037.4091D76761@ppluzhnikov.mtv.corp.google.com> Date: Sat, 17 Oct 2009 23:26:00 -0000 Message-ID: <8ac60eac0910171625n489736e1v94326e4d95b40f98@mail.gmail.com> Subject: Re: [patch] Fix for PR gdb/10757 From: Paul Pluzhnikov To: gdb-patches@sourceware.org Cc: ppluzhnikov@google.com, Pedro Alves Content-Type: multipart/mixed; boundary=001636ed6dc7980d5a047629d59b X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00401.txt.bz2 --001636ed6dc7980d5a047629d59b Content-Type: text/plain; charset=ISO-8859-1 Content-length: 862 On Thu, Oct 15, 2009 at 12:10 PM, Paul Pluzhnikov wrote: > Here is a proposed fix for gdb/10757: > http://sourceware.org/bugzilla/show_bug.cgi?id=10757 This failed to compile with GCC 4.4 ('err' may be used uninitialized). Here is an updated patch. Thanks, -- Paul Pluzhnikov 2009-10-17 Paul Pluzhnikov PR gdb/10757 * linux-thread-db.c (attach_thread): Return success/failure indicator. (thread_db_find_new_threads_silently): Retry until no new threads. (struct callback_data): New. (find_new_threads_callback): Count new threads, stop iteration on error. (find_new_threads_once): New function. (thread_db_find_new_threads_2): Rename from thread_db_find_new_threads_1 and adjust. (thread_db_find_new_threads_1): New function. --001636ed6dc7980d5a047629d59b Content-Type: text/plain; charset=US-ASCII; name="gdb-pr10757-20091017.txt" Content-Disposition: attachment; filename="gdb-pr10757-20091017.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g0wzy45s0 Content-length: 9195 SW5kZXg6IGxpbnV4LXRocmVhZC1kYi5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvbGludXgtdGhyZWFkLWRi LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNjQKZGlmZiAtdSAtcCAtdSAt cjEuNjQgbGludXgtdGhyZWFkLWRiLmMKLS0tIGxpbnV4LXRocmVhZC1kYi5j CTE2IEp1bCAyMDA5IDIwOjQ1OjE3IC0wMDAwCTEuNjQKKysrIGxpbnV4LXRo cmVhZC1kYi5jCTE1IE9jdCAyMDA5IDE4OjU1OjI4IC0wMDAwCkBAIC0xNjAs NiArMTYwLDcgQEAgc3RydWN0IHRocmVhZF9kYl9pbmZvCiBzdHJ1Y3QgdGhy ZWFkX2RiX2luZm8gKnRocmVhZF9kYl9saXN0OwogCiBzdGF0aWMgdm9pZCB0 aHJlYWRfZGJfZmluZF9uZXdfdGhyZWFkc18xIChwdGlkX3QgcHRpZCk7Citz dGF0aWMgdm9pZCB0aHJlYWRfZGJfZmluZF9uZXdfdGhyZWFkc18yIChwdGlk X3QgcHRpZCwgaW50IG51bV9sb29wKTsKIAogLyogQWRkIHRoZSBjdXJyZW50 IGluZmVyaW9yIHRvIHRoZSBsaXN0IG9mIHByb2Nlc3NlcyB1c2luZyBsaWJw dGhyZWFkLgogICAgUmV0dXJuIGEgcG9pbnRlciB0byB0aGUgbmV3bHkgYWxs b2NhdGVkIG9iamVjdCB0aGF0IHdhcyBhZGRlZCB0bwpAQCAtMjI5LDggKzIz MCw4IEBAIGRlbGV0ZV90aHJlYWRfZGJfaW5mbyAoaW50IHBpZCkKIH0KIAog LyogUHJvdG90eXBlcyBmb3IgbG9jYWwgZnVuY3Rpb25zLiAgKi8KLXN0YXRp YyB2b2lkIGF0dGFjaF90aHJlYWQgKHB0aWRfdCBwdGlkLCBjb25zdCB0ZF90 aHJoYW5kbGVfdCAqdGhfcCwKLQkJCSAgIGNvbnN0IHRkX3RocmluZm9fdCAq dGlfcCk7CitzdGF0aWMgaW50IGF0dGFjaF90aHJlYWQgKHB0aWRfdCBwdGlk LCBjb25zdCB0ZF90aHJoYW5kbGVfdCAqdGhfcCwKKwkJCSAgY29uc3QgdGRf dGhyaW5mb190ICp0aV9wKTsKIHN0YXRpYyB2b2lkIGRldGFjaF90aHJlYWQg KHB0aWRfdCBwdGlkKTsKIAwKIApAQCAtNTk3LDcgKzU5OCw3IEBAIHRocmVh ZF9kYl9maW5kX25ld190aHJlYWRzX3NpbGVudGx5IChwdGkKIAogICBUUllf Q0FUQ0ggKGV4Y2VwdCwgUkVUVVJOX01BU0tfRVJST1IpCiAgICAgewotICAg ICAgdGhyZWFkX2RiX2ZpbmRfbmV3X3RocmVhZHNfMSAocHRpZCk7CisgICAg ICB0aHJlYWRfZGJfZmluZF9uZXdfdGhyZWFkc18yIChwdGlkLCA0KTsKICAg ICB9CiAKICAgaWYgKGV4Y2VwdC5yZWFzb24gPCAwICYmIGluZm9fdmVyYm9z ZSkKQEAgLTk3Nyw5ICs5NzgsOSBAQCB0aHJlYWRfZGJfbmV3X29iamZpbGUg KHN0cnVjdCBvYmpmaWxlICpvCiAKIC8qIEF0dGFjaCB0byBhIG5ldyB0aHJl YWQuICBUaGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCB3aGVuIHdlIHJlY2VpdmUg YQogICAgVERfQ1JFQVRFIGV2ZW50IG9yIHdoZW4gd2UgaXRlcmF0ZSBvdmVy IGFsbCB0aHJlYWRzIGFuZCBmaW5kIG9uZQotICAgdGhhdCB3YXNuJ3QgYWxy ZWFkeSBpbiBvdXIgbGlzdC4gICovCisgICB0aGF0IHdhc24ndCBhbHJlYWR5 IGluIG91ciBsaXN0LiAgUmV0dXJucyB0cnVlIG9uIHN1Y2Nlc3MuICAqLwog Ci1zdGF0aWMgdm9pZAorc3RhdGljIGludAogYXR0YWNoX3RocmVhZCAocHRp ZF90IHB0aWQsIGNvbnN0IHRkX3RocmhhbmRsZV90ICp0aF9wLAogCSAgICAg ICBjb25zdCB0ZF90aHJpbmZvX3QgKnRpX3ApCiB7CkBAIC0xMDEzLDcgKzEw MTQsNyBAQCBhdHRhY2hfdGhyZWFkIChwdGlkX3QgcHRpZCwgY29uc3QgdGRf dGhyCiAgICAgICBpZiAodHAtPnByaXZhdGUgIT0gTlVMTCkKIAl7CiAJICBp ZiAoIXRwLT5wcml2YXRlLT5keWluZykKLQkgICAgcmV0dXJuOworCSAgICBy ZXR1cm4gMDsKIAogCSAgZGVsZXRlX3RocmVhZCAocHRpZCk7CiAJICB0cCA9 IE5VTEw7CkBAIC0xMDIzLDEyICsxMDI0LDEyIEBAIGF0dGFjaF90aHJlYWQg KHB0aWRfdCBwdGlkLCBjb25zdCB0ZF90aHIKICAgY2hlY2tfdGhyZWFkX3Np Z25hbHMgKCk7CiAKICAgaWYgKHRpX3AtPnRpX3N0YXRlID09IFREX1RIUl9V TktOT1dOIHx8IHRpX3AtPnRpX3N0YXRlID09IFREX1RIUl9aT01CSUUpCi0g ICAgcmV0dXJuOwkJCS8qIEEgem9tYmllIHRocmVhZCAtLSBkbyBub3QgYXR0 YWNoLiAgKi8KKyAgICByZXR1cm4gMDsJCQkvKiBBIHpvbWJpZSB0aHJlYWQg LS0gZG8gbm90IGF0dGFjaC4gICovCiAKICAgLyogVW5kZXIgR05VL0xpbnV4 LCB3ZSBoYXZlIHRvIGF0dGFjaCB0byBlYWNoIGFuZCBldmVyeSB0aHJlYWQu ICAqLwogICBpZiAodHAgPT0gTlVMTAogICAgICAgJiYgbGluX2x3cF9hdHRh Y2hfbHdwIChCVUlMRF9MV1AgKHRpX3AtPnRpX2xpZCwgR0VUX1BJRCAocHRp ZCkpKSA8IDApCi0gICAgcmV0dXJuOworICAgIHJldHVybiAwOwogCiAgIC8q IENvbnN0cnVjdCB0aGUgdGhyZWFkJ3MgcHJpdmF0ZSBkYXRhLiAgKi8KICAg cHJpdmF0ZSA9IHhtYWxsb2MgKHNpemVvZiAoc3RydWN0IHByaXZhdGVfdGhy ZWFkX2luZm8pKTsKQEAgLTEwNTYsNiArMTA1Nyw3IEBAIGF0dGFjaF90aHJl YWQgKHB0aWRfdCBwdGlkLCBjb25zdCB0ZF90aHIKICAgaWYgKGVyciAhPSBU RF9PSykKICAgICBlcnJvciAoXygiQ2Fubm90IGVuYWJsZSB0aHJlYWQgZXZl bnQgcmVwb3J0aW5nIGZvciAlczogJXMiKSwKIAkgICB0YXJnZXRfcGlkX3Rv X3N0ciAocHRpZCksIHRocmVhZF9kYl9lcnJfc3RyIChlcnIpKTsKKyAgcmV0 dXJuIDE7CiB9CiAKIHN0YXRpYyB2b2lkCkBAIC0xMjg2LDYgKzEyODgsMTIg QEAgdGhyZWFkX2RiX21vdXJuX2luZmVyaW9yIChzdHJ1Y3QgdGFyZ2V0Xwog ICAgIHVucHVzaF90YXJnZXQgKG9wcyk7CiB9CiAKK3N0cnVjdCBjYWxsYmFj a19kYXRhCit7CisgIHN0cnVjdCB0aHJlYWRfZGJfaW5mbyAqaW5mbzsKKyAg aW50IG5ld190aHJlYWRzOworfTsKKwogc3RhdGljIGludAogZmluZF9uZXdf dGhyZWFkc19jYWxsYmFjayAoY29uc3QgdGRfdGhyaGFuZGxlX3QgKnRoX3As IHZvaWQgKmRhdGEpCiB7CkBAIC0xMjkzLDcgKzEzMDEsOCBAQCBmaW5kX25l d190aHJlYWRzX2NhbGxiYWNrIChjb25zdCB0ZF90aHJoCiAgIHRkX2Vycl9l IGVycjsKICAgcHRpZF90IHB0aWQ7CiAgIHN0cnVjdCB0aHJlYWRfaW5mbyAq dHA7Ci0gIHN0cnVjdCB0aHJlYWRfZGJfaW5mbyAqaW5mbyA9IGRhdGE7Cisg IHN0cnVjdCBjYWxsYmFja19kYXRhICpjYl9kYXRhID0gZGF0YTsKKyAgc3Ry dWN0IHRocmVhZF9kYl9pbmZvICppbmZvID0gY2JfZGF0YS0+aW5mbzsKIAog ICBlcnIgPSBpbmZvLT50ZF90aHJfZ2V0X2luZm9fcCAodGhfcCwgJnRpKTsK ICAgaWYgKGVyciAhPSBURF9PSykKQEAgLTEzMzYsMjEgKzEzNDUsNzYgQEAg ZmluZF9uZXdfdGhyZWFkc19jYWxsYmFjayAoY29uc3QgdGRfdGhyaAogICBw dGlkID0gcHRpZF9idWlsZCAoaW5mby0+cGlkLCB0aS50aV9saWQsIDApOwog ICB0cCA9IGZpbmRfdGhyZWFkX3B0aWQgKHB0aWQpOwogICBpZiAodHAgPT0g TlVMTCB8fCB0cC0+cHJpdmF0ZSA9PSBOVUxMKQotICAgIGF0dGFjaF90aHJl YWQgKHB0aWQsIHRoX3AsICZ0aSk7CisgICAgeworICAgICAgaWYgKGF0dGFj aF90aHJlYWQgKHB0aWQsIHRoX3AsICZ0aSkpCisJY2JfZGF0YS0+bmV3X3Ro cmVhZHMgKz0gMTsKKyAgICAgIGVsc2UKKwkvKiBQcm9ibGVtIGF0dGFjaGlu ZyB0aGlzIHRocmVhZDsgcGVyaGFwcyBpdCBleGl0ZWQgYmVmb3JlIHdlCisJ ICAgY291bGQgYXR0YWNoIGl0PworCSAgIFRoaXMgY291bGQgbWVhbiB0aGF0 IHRoZSB0aHJlYWQgbGlzdCBpbnNpZGUgZ2xpYmMgaXRzZWxmIGlzIGluCisJ ICAgaW5jb25zaXN0ZW50IHN0YXRlLCBhbmQgbGlidGhyZWFkX2RiIGNvdWxk IGdvIG9uIGxvb3BpbmcgZm9yZXZlcgorCSAgIChvYnNlcnZlZCB3aXRoIGds aWJjLTIuMy42KS4gIFRvIHByZXZlbnQgdGhhdCwgdGVybWluYXRlCisJICAg aXRlcmF0aW9uOiB0aHJlYWRfZGJfZmluZF9uZXdfdGhyZWFkc18yIHdpbGwg cmV0cnkuICAqLworCXJldHVybiAxOworICAgIH0KIAogICByZXR1cm4gMDsK IH0KIAorLyogSGVscGVyIGZvciB0aHJlYWRfZGJfZmluZF9uZXdfdGhyZWFk c18yLgorICAgUmV0dXJucyBudW1iZXIgb2YgbmV3IHRocmVhZHMgZm91bmQu ICAqLworCitzdGF0aWMgaW50CitmaW5kX25ld190aHJlYWRzX29uY2UgKHN0 cnVjdCB0aHJlYWRfZGJfaW5mbyAqaW5mbywgaW50IGl0ZXJhdGlvbiwKKwkJ ICAgICAgIGludCAqZXJycCkKK3sKKyAgdm9sYXRpbGUgc3RydWN0IGdkYl9l eGNlcHRpb24gZXhjZXB0OworICBzdHJ1Y3QgY2FsbGJhY2tfZGF0YSBkYXRh OworICBpbnQgZXJyID0gVERfRVJSOworCisgIGRhdGEuaW5mbyA9IGluZm87 CisgIGRhdGEubmV3X3RocmVhZHMgPSAwOworCisgIFRSWV9DQVRDSCAoZXhj ZXB0LCBSRVRVUk5fTUFTS19FUlJPUikKKyAgICB7CisgICAgICAvKiBJdGVy YXRlIG92ZXIgYWxsIHVzZXItc3BhY2UgdGhyZWFkcyB0byBkaXNjb3ZlciBu ZXcgdGhyZWFkcy4gICovCisgICAgICBlcnIgPSBpbmZvLT50ZF90YV90aHJf aXRlcl9wIChpbmZvLT50aHJlYWRfYWdlbnQsCisJCQkJICAgIGZpbmRfbmV3 X3RocmVhZHNfY2FsbGJhY2ssCisJCQkJICAgICZkYXRhLAorCQkJCSAgICBU RF9USFJfQU5ZX1NUQVRFLAorCQkJCSAgICBURF9USFJfTE9XRVNUX1BSSU9S SVRZLAorCQkJCSAgICBURF9TSUdOT19NQVNLLAorCQkJCSAgICBURF9USFJf QU5ZX1VTRVJfRkxBR1MpOworICAgIH0KKworICBpZiAoaW5mb192ZXJib3Nl KQorICAgIHsKKyAgICAgIGlmIChleGNlcHQucmVhc29uIDwgMCkKKwlleGNl cHRpb25fZnByaW50ZiAoZ2RiX3N0ZGVyciwgZXhjZXB0LAorCQkJICAgIldh cm5pbmc6IGZpbmRfbmV3X3RocmVhZHNfb25jZTogIik7CisKKyAgICAgIHBy aW50Zl9maWx0ZXJlZCAoXygiRm91bmQgJWQgbmV3IHRocmVhZHMgaW4gaXRl cmF0aW9uICVkLlxuIiksCisJCSAgICAgICBkYXRhLm5ld190aHJlYWRzLCBp dGVyYXRpb24pOworICAgIH0KKworICBpZiAoZXJycCAhPSBOVUxMKQorICAg ICplcnJwID0gZXJyOworCisgIHJldHVybiBkYXRhLm5ld190aHJlYWRzOwor fQorCiAvKiBTZWFyY2ggZm9yIG5ldyB0aHJlYWRzLCBhY2Nlc3NpbmcgbWVt b3J5IHRocm91Z2ggc3RvcHBlZCB0aHJlYWQKLSAgIFBUSUQuICAqLworICAg UFRJRC4gIElmIE5VTV9MT09QUyBpcyBub24temVybywgcmVwZWF0IHNlYXJj aGluZyB1bnRpbCBOVU1fTE9PUAorICAgc2VhcmNoZXMgaW4gYSByb3cgZG8g bm90IGRpc2NvdmVyIGFueSBuZXcgdGhyZWFkcy4gICovCiAKIHN0YXRpYyB2 b2lkCi10aHJlYWRfZGJfZmluZF9uZXdfdGhyZWFkc18xIChwdGlkX3QgcHRp ZCkKK3RocmVhZF9kYl9maW5kX25ld190aHJlYWRzXzIgKHB0aWRfdCBwdGlk LCBpbnQgbnVtX2xvb3ApCiB7CiAgIHRkX2Vycl9lIGVycjsKICAgc3RydWN0 IGx3cF9pbmZvICpscDsKICAgc3RydWN0IHRocmVhZF9kYl9pbmZvICppbmZv OwogICBpbnQgcGlkID0gcHRpZF9nZXRfcGlkIChwdGlkKTsKKyAgaW50IGks IGxvb3A7CiAKICAgLyogSW4gbGludXgsIHdlIGNhbiBvbmx5IHJlYWQgbWVt b3J5IHRocm91Z2ggYSBzdG9wcGVkIGx3cC4gICovCiAgIEFMTF9MV1BTIChs cCwgcHRpZCkKQEAgLTEzNjUsMTUgKzE0MjksMzMgQEAgdGhyZWFkX2RiX2Zp bmRfbmV3X3RocmVhZHNfMSAocHRpZF90IHB0aQogCiAgIC8qIEFjY2VzcyBh biBsd3Agd2Uga25vdyBpcyBzdG9wcGVkLiAgKi8KICAgaW5mby0+cHJvY19o YW5kbGUucHRpZCA9IHB0aWQ7Ci0gIC8qIEl0ZXJhdGUgb3ZlciBhbGwgdXNl ci1zcGFjZSB0aHJlYWRzIHRvIGRpc2NvdmVyIG5ldyB0aHJlYWRzLiAgKi8K LSAgZXJyID0gaW5mby0+dGRfdGFfdGhyX2l0ZXJfcCAoaW5mby0+dGhyZWFk X2FnZW50LCBmaW5kX25ld190aHJlYWRzX2NhbGxiYWNrLAotCQkJCWluZm8s IFREX1RIUl9BTllfU1RBVEUsIFREX1RIUl9MT1dFU1RfUFJJT1JJVFksCi0J CQkJVERfU0lHTk9fTUFTSywgVERfVEhSX0FOWV9VU0VSX0ZMQUdTKTsKLSAg aWYgKGVyciAhPSBURF9PSykKLSAgICBlcnJvciAoXygiQ2Fubm90IGZpbmQg bmV3IHRocmVhZHM6ICVzIiksIHRocmVhZF9kYl9lcnJfc3RyIChlcnIpKTsK KworICBpZiAobnVtX2xvb3AgIT0gMCkKKyAgICB7CisgICAgICAvKiBSZXF1 aXJlIE5VTV9MT09QIHN1Y2Nlc3NpdmUgaXRlcmF0aW9ucyB3aGljaCBkbyBu b3QgZmluZCBhbnkgbmV3IHRocmVhZHMuICAqLworICAgICAgZm9yIChpID0g MCwgbG9vcCA9IDA7IGxvb3AgPCA0OyArK2ksICsrbG9vcCkKKwlpZiAoZmlu ZF9uZXdfdGhyZWFkc19vbmNlIChpbmZvLCBpLCBOVUxMKSAhPSAwKQorCSAg LyogRm91bmQgc29tZSBuZXcgdGhyZWFkcy4gIFJlc3RhcnQgdGhlIGxvb3Ag ZnJvbSBiZWdpbm5pbmcuICAqLworCSAgbG9vcCA9IC0xOworICAgIH0KKyAg ZWxzZQorICAgIHsKKyAgICAgIGludCBlcnI7CisKKyAgICAgIGZpbmRfbmV3 X3RocmVhZHNfb25jZSAoaW5mbywgMCwgJmVycik7CisgICAgICBpZiAoZXJy ICE9IFREX09LKQorCWVycm9yIChfKCJDYW5ub3QgZmluZCBuZXcgdGhyZWFk czogJXMiKSwgdGhyZWFkX2RiX2Vycl9zdHIgKGVycikpOworICAgIH0KIH0K IAogc3RhdGljIHZvaWQKK3RocmVhZF9kYl9maW5kX25ld190aHJlYWRzXzEg KHB0aWRfdCBwdGlkKQoreworICB0aHJlYWRfZGJfZmluZF9uZXdfdGhyZWFk c18yIChwdGlkLCAwKTsKK30KKworCitzdGF0aWMgdm9pZAogdGhyZWFkX2Ri X2ZpbmRfbmV3X3RocmVhZHMgKHN0cnVjdCB0YXJnZXRfb3BzICpvcHMpCiB7 CiAgIHN0cnVjdCB0aHJlYWRfZGJfaW5mbyAqaW5mbzsK --001636ed6dc7980d5a047629d59b--