From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30664 invoked by alias); 14 Oct 2009 21:01:18 -0000 Received: (qmail 30488 invoked by uid 22791); 14 Oct 2009 21:01:17 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Oct 2009 21:01:12 +0000 Received: from zps36.corp.google.com (zps36.corp.google.com [172.25.146.36]) by smtp-out.google.com with ESMTP id n9EL18Ar010935 for ; Wed, 14 Oct 2009 22:01:09 +0100 Received: from yxe10 (yxe10.prod.google.com [10.190.2.10]) by zps36.corp.google.com with ESMTP id n9EL16M2022839 for ; Wed, 14 Oct 2009 14:01:06 -0700 Received: by yxe10 with SMTP id 10so197535yxe.12 for ; Wed, 14 Oct 2009 14:01:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.9.38 with SMTP id m38mr7915380ani.21.1255554065858; Wed, 14 Oct 2009 14:01:05 -0700 (PDT) In-Reply-To: <200910142007.59636.pedro@codesourcery.com> References: <20091013184120.30A5776761@ppluzhnikov.mtv.corp.google.com> <200910132153.51171.pedro@codesourcery.com> <8ac60eac0910141121r59573032na0ccee77f049366f@mail.gmail.com> <200910142007.59636.pedro@codesourcery.com> Date: Wed, 14 Oct 2009 21:01:00 -0000 Message-ID: <8ac60eac0910141401l57a6285es75634cf40ea5142d@mail.gmail.com> Subject: Re: [patch] Fix for internal-error: linux_nat_post_attach_wait: Assertion `pid == new_pid && WIFSTOPPED (status)' failed. From: Paul Pluzhnikov To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001636b2b0c31781730475eb76e2 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00317.txt.bz2 --001636b2b0c31781730475eb76e2 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1259 On Wed, Oct 14, 2009 at 12:07 PM, Pedro Alves wrote: > Ugh. Happened much more often for me, like 1 in 5... It's racy. I've seen different frequency of problems depending on whether I run kernel 2.6.24 or 2.6.30. > I don't think you needed the interface change. Indeed. > Back to the "simple" variant: The inferior just added is > always inferior_ptid/current_inferior(). If you look > at fork-child.c:startup_inferior, you'll see bits of > code doing exactly what you'd need to do. E.g.: > > target_terminal_ours (); > target_mourn_inferior (); > if (WIFEXITED (status)) > error (_("During startup program exited with code %d."), > WIFEXITCODE (status)); > else if (WIFSIGNALED (status)) > error (_("During startup program exited with signal ..."), > ...); I don't see above code in fork-child.c (or anywhere else for that matter). Are you looking at a local patch? Anyway, here is try #3. Thanks, -- Paul Pluzhnikov 2009-10-14 Paul Pluzhnikov * linux-nat.c (linux_nat_post_attach_wait): Adjust assert. (lin_lwp_attach_lwp, linux_nat_attach): Handle disappearing LWP. --001636b2b0c31781730475eb76e2 Content-Type: text/plain; charset=US-ASCII; name="gdb-assert-10757-20091014-2.txt" Content-Disposition: attachment; filename="gdb-assert-10757-20091014-2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g0skfs780 Content-length: 2855 SW5kZXg6IGxpbnV4LW5hdC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvbGludXgtbmF0LmMsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMTUxCmRpZmYgLXUgLXAgLXUgLXIxLjE1MSBsaW51 eC1uYXQuYwotLS0gbGludXgtbmF0LmMJOSBPY3QgMjAwOSAwMTo1NzoxMiAt MDAwMAkxLjE1MQorKysgbGludXgtbmF0LmMJMTQgT2N0IDIwMDkgMjA6NDE6 NDYgLTAwMDAKQEAgLTEzMzgsNyArMTMzOCwxNiBAQCBsaW51eF9uYXRfcG9z dF9hdHRhY2hfd2FpdCAocHRpZF90IHB0aWQsCiAgICAgICAqY2xvbmVkID0g MTsKICAgICB9CiAKLSAgZ2RiX2Fzc2VydCAocGlkID09IG5ld19waWQgJiYg V0lGU1RPUFBFRCAoc3RhdHVzKSk7CisgIGdkYl9hc3NlcnQgKHBpZCA9PSBu ZXdfcGlkKTsKKworICBpZiAoIVdJRlNUT1BQRUQgKHN0YXR1cykpCisgICAg eworICAgICAgLyogVGhlIHBpZCB3ZSB0cmllZCB0byBhdHRhY2ggaGFzIGFw cGFyZW50bHkganVzdCBleGl0ZWQuICAqLworICAgICAgaWYgKGRlYnVnX2xp bnV4X25hdCkKKwlmcHJpbnRmX3VuZmlsdGVyZWQgKGdkYl9zdGRsb2csICJM TlBBVzogRmFpbGVkIHRvIHN0b3AgJWQ6ICVzIiwKKwkJCSAgICBwaWQsIHN0 YXR1c190b19zdHIgKHN0YXR1cykpOworICAgICAgcmV0dXJuIHN0YXR1czsK KyAgICB9CiAKICAgaWYgKFdTVE9QU0lHIChzdGF0dXMpICE9IFNJR1NUT1Ap CiAgICAgewpAQCAtMTM5Niw2ICsxNDA1LDkgQEAgbGluX2x3cF9hdHRhY2hf bHdwIChwdGlkX3QgcHRpZCkKIAkJCSAgICB0YXJnZXRfcGlkX3RvX3N0ciAo cHRpZCkpOwogCiAgICAgICBzdGF0dXMgPSBsaW51eF9uYXRfcG9zdF9hdHRh Y2hfd2FpdCAocHRpZCwgMCwgJmNsb25lZCwgJnNpZ25hbGxlZCk7CisgICAg ICBpZiAoIVdJRlNUT1BQRUQgKHN0YXR1cykpCisJcmV0dXJuIC0xOworCiAg ICAgICBscCA9IGFkZF9sd3AgKHB0aWQpOwogICAgICAgbHAtPnN0b3BwZWQg PSAxOwogICAgICAgbHAtPmNsb25lZCA9IGNsb25lZDsKQEAgLTE0OTUsNiAr MTUwNywzNyBAQCBsaW51eF9uYXRfYXR0YWNoIChzdHJ1Y3QgdGFyZ2V0X29w cyAqb3BzCiAKICAgc3RhdHVzID0gbGludXhfbmF0X3Bvc3RfYXR0YWNoX3dh aXQgKGxwLT5wdGlkLCAxLCAmbHAtPmNsb25lZCwKIAkJCQkgICAgICAgJmxw LT5zaWduYWxsZWQpOworICBpZiAoIVdJRlNUT1BQRUQgKHN0YXR1cykpCisg ICAgeworICAgICAgZGVsZXRlX2x3cCAocHRpZCk7CisgICAgICBpZiAoV0lG RVhJVEVEIChzdGF0dXMpKQorCXsKKwkgIGludCBleGl0X2NvZGUgPSBXRVhJ VFNUQVRVUyAoc3RhdHVzKTsKKworCSAgdGFyZ2V0X3Rlcm1pbmFsX291cnMg KCk7CisJICB0YXJnZXRfbW91cm5faW5mZXJpb3IgKCk7CisJICBpZiAoZXhp dF9jb2RlID09IDApCisJICAgIGVycm9yIChfKCJEdXJpbmcgc3RhcnR1cCBw cm9ncmFtIGV4aXRlZCBub3JtYWxseS4iKSk7CisJICBlbHNlCisJICAgIGVy cm9yIChfKCJEdXJpbmcgc3RhcnR1cCBwcm9ncmFtIGV4aXRlZCB3aXRoIGNv ZGUgJWQuIiksCisJCSAgIGV4aXRfY29kZSk7CisJfQorICAgICAgZWxzZSBp ZiAoV0lGU0lHTkFMRUQgKHN0YXR1cykpCisJeworCSAgaW50IHNpZ25vID0g V1RFUk1TSUcgKHN0YXR1cyk7CisKKwkgIHRhcmdldF90ZXJtaW5hbF9vdXJz ICgpOworCSAgdGFyZ2V0X21vdXJuX2luZmVyaW9yICgpOworCSAgZXJyb3Ig KF8oIkR1cmluZyBzdGFydHVwIHByb2dyYW0gdGVybWluYXRlZCB3aXRoIHNp Z25hbCAlcywgJXMuIiksCisJCSB0YXJnZXRfc2lnbmFsX3RvX25hbWUgKHNp Z25vKSwKKwkJIHRhcmdldF9zaWduYWxfdG9fc3RyaW5nIChzaWdubykpOwor CX0KKworICAgICAgaW50ZXJuYWxfZXJyb3IgKF9fRklMRV9fLCBfX0xJTkVf XywKKwkJICAgICAgXygidW5leHBlY3RlZCBzdGF0dXMgJWQgZm9yIFBJRCAl bGQiKSwKKwkJICAgICAgc3RhdHVzLCAobG9uZykgR0VUX0xXUCAocHRpZCkp OworICAgIH0KKwogICBscC0+c3RvcHBlZCA9IDE7CiAKICAgLyogU2F2ZSB0 aGUgd2FpdCBzdGF0dXMgdG8gcmVwb3J0IGxhdGVyLiAgKi8K --001636b2b0c31781730475eb76e2--