From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18156 invoked by alias); 8 Oct 2009 05:29:33 -0000 Received: (qmail 18146 invoked by uid 22791); 8 Oct 2009 05:29:32 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Oct 2009 05:29:26 +0000 Received: from spaceape9.eur.corp.google.com (spaceape9.eur.corp.google.com [172.28.16.143]) by smtp-out.google.com with ESMTP id n985TNWI006511 for ; Thu, 8 Oct 2009 06:29:23 +0100 Received: from ywh8 (ywh8.prod.google.com [10.192.8.8]) by spaceape9.eur.corp.google.com with ESMTP id n985TKFQ003560 for ; Wed, 7 Oct 2009 22:29:20 -0700 Received: by ywh8 with SMTP id 8so5633267ywh.3 for ; Wed, 07 Oct 2009 22:29:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.40.17 with SMTP id n17mr812561ann.187.1254979760215; Wed, 07 Oct 2009 22:29:20 -0700 (PDT) Date: Thu, 08 Oct 2009 05:29:00 -0000 Message-ID: <8ac60eac0910072229s432c6480k5788878ca414b255@mail.gmail.com> Subject: [patch] Fix for excessive stack use (gdb/10457) From: Paul Pluzhnikov To: gdb-patches ml Cc: Holger Freyther Content-Type: multipart/mixed; boundary=0016e646522cced785047565be54 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00163.txt.bz2 --0016e646522cced785047565be54 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 261 Greetings, Calling alloca in a loop is a bad idea. Here is a fix for gdb/10457; rather on the obvious side. Thanks, -- Paul Pluzhnikov 2009-10-07 Paul Pluzhnikov * elfread.c (elf_symtab_read): Don't use alloca in a loop. --0016e646522cced785047565be54 Content-Type: text/plain; charset=US-ASCII; name="gdb-pr10457-20091007.txt" Content-Disposition: attachment; filename="gdb-pr10457-20091007.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g0j2i78k0 Content-length: 1164 SW5kZXg6IGVsZnJlYWQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2VsZnJlYWQuYyx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS43NwpkaWZmIC1wIC11IC1yMS43NyBlbGZyZWFkLmMKLS0t IGVsZnJlYWQuYwkzMCBBcHIgMjAwOSAyMTo1OTowMyAtMDAwMAkxLjc3Cisr KyBlbGZyZWFkLmMJOCBPY3QgMjAwOSAwNToyMjo0OSAtMDAwMApAQCAtNTM1 LDcgKzUzNSw3IEBAIGVsZl9zeW10YWJfcmVhZCAoc3RydWN0IG9iamZpbGUg Km9iamZpbGUKIAogCSAgICAgIGlmIChsZW4gPiA0ICYmIHN0cmNtcCAoc3lt LT5uYW1lICsgbGVuIC0gNCwgIkBwbHQiKSA9PSAwKQogCQl7Ci0JCSAgY2hh ciAqYmFzZV9uYW1lID0gYWxsb2NhIChsZW4gLSA0ICsgMSk7CisJCSAgY2hh ciAqYmFzZV9uYW1lID0geG1hbGxvYyAobGVuIC0gNCArIDEpOwogCQkgIHN0 cnVjdCBtaW5pbWFsX3N5bWJvbCAqbXRyYW1wOwogCiAJCSAgbWVtY3B5IChi YXNlX25hbWUsIHN5bS0+bmFtZSwgbGVuIC0gNCk7CkBAIC01NDMsNiArNTQz LDcgQEAgZWxmX3N5bXRhYl9yZWFkIChzdHJ1Y3Qgb2JqZmlsZSAqb2JqZmls ZQogCQkgIG10cmFtcCA9IHJlY29yZF9taW5pbWFsX3N5bWJvbCAoYmFzZV9u YW1lLCBzeW1hZGRyLAogCQkJCQkJICBtc3Rfc29saWJfdHJhbXBvbGluZSwK IAkJCQkJCSAgc3ltLT5zZWN0aW9uLCBvYmpmaWxlKTsKKwkJICB4ZnJlZSAo YmFzZV9uYW1lKTsKIAkJICBpZiAobXRyYW1wKQogCQkgICAgewogCQkgICAg ICBNU1lNQk9MX1NJWkUgKG10cmFtcCkgPSBNU1lNQk9MX1NJWkUgKG1zeW0p Owo= --0016e646522cced785047565be54--