From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17154 invoked by alias); 5 Oct 2009 01:49:29 -0000 Received: (qmail 17125 invoked by uid 22791); 5 Oct 2009 01:49:28 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Oct 2009 01:49:23 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id n951nLTn012780 for ; Sun, 4 Oct 2009 18:49:21 -0700 Received: from yxe31 (yxe31.prod.google.com [10.190.2.31]) by wpaz21.hot.corp.google.com with ESMTP id n951nJIM002838 for ; Sun, 4 Oct 2009 18:49:19 -0700 Received: by yxe31 with SMTP id 31so2581194yxe.21 for ; Sun, 04 Oct 2009 18:49:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.55.7 with SMTP id h7mr4666101ank.116.1254707359098; Sun, 04 Oct 2009 18:49:19 -0700 (PDT) In-Reply-To: <200910042132.23246.pedro@codesourcery.com> References: <20090902163344.833F476568@localhost> <8ac60eac0909021015u37d1a6e2u1ae88dd35d00d2b9@mail.gmail.com> <8ac60eac0910021651o38990564ue7a65a870c14d00b@mail.gmail.com> <200910042132.23246.pedro@codesourcery.com> Date: Mon, 05 Oct 2009 01:49:00 -0000 Message-ID: <8ac60eac0910041849q5e95466br6190a355f8192eeb@mail.gmail.com> Subject: Re: [patch] Allow gdbserver to dynamically lookup libthread_db.so.1 From: Paul Pluzhnikov To: Pedro Alves Cc: gdb-patches@sourceware.org, dje@google.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00104.txt.bz2 On Sun, Oct 4, 2009 at 1:32 PM, Pedro Alves wrote: > Thanks much. =A0This is close. Thanks for your comments, I'll address most of them soon. Quick question: >> + =A0struct process_info_private *proc =3D current_process()->private; > > Missing space before '()'. =A0There are other instances of this. So this is supposed to be: struct process_info_private *proc =3D current_process ()->private; That A) looks weird and B) contradicts current usage (before the patch): grep current_process thread-db.c struct process_info_private *proc =3D current_process()->private; struct process_info_private *proc =3D current_process()->private; struct process_info_private *proc =3D current_process()->private; struct process_info *proc =3D current_process (); Thanks, --=20 Paul Pluzhnikov