From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29100 invoked by alias); 17 Sep 2009 16:37:21 -0000 Received: (qmail 29087 invoked by uid 22791); 17 Sep 2009 16:37:19 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37,J_CHICKENPOX_73,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Sep 2009 16:37:15 +0000 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id n8HGbBGI028938 for ; Thu, 17 Sep 2009 17:37:11 +0100 Received: from yxe42 (yxe42.prod.google.com [10.190.2.42]) by wpaz24.hot.corp.google.com with ESMTP id n8HGb8Sh023491 for ; Thu, 17 Sep 2009 09:37:09 -0700 Received: by yxe42 with SMTP id 42so272369yxe.31 for ; Thu, 17 Sep 2009 09:37:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.174.36 with SMTP id b36mr316277anp.91.1253205428524; Thu, 17 Sep 2009 09:37:08 -0700 (PDT) In-Reply-To: <83ab0uyfzk.fsf@gnu.org> References: <200909152132.15317.sergiodj@linux.vnet.ibm.com> <200909161416.22783.pedro@codesourcery.com> <83ab0uyfzk.fsf@gnu.org> Date: Thu, 17 Sep 2009 16:37:00 -0000 Message-ID: <8ac60eac0909170937t14e62114o9a74d1ef110643b1@mail.gmail.com> Subject: Re: [RFA] Fix "show convenience" test From: Paul Pluzhnikov To: Eli Zaretskii Cc: Pedro Alves , sergiodj@linux.vnet.ibm.com, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001636c927cf65d9b50473c8a0dc X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00565.txt.bz2 --001636c927cf65d9b50473c8a0dc Content-Type: text/plain; charset=ISO-8859-1 Content-length: 3127 On Wed, Sep 16, 2009 at 10:08 AM, Eli Zaretskii wrote: >> From: Pedro Alves >> Date: Wed, 16 Sep 2009 14:16:22 +0100 >> Cc: gdb-patches@sourceware.org >> >> Hmm, I had already approved Paul's similar follow up patch at >> . I now see that you did. I lost that fact in the ensuing discussion of testsuite failures :-( >> I looks like it was waiting for a docs review. > > Ouch! sorry about that (binary attachments tend to have this effect on > me ;-). The attachment was actually text, just base64-encoded: Content-Type: text/plain; charset=US-ASCII; name="gdb-convenience.20090406.txt" Unfortunately, my attempts to convince gmail not to do that have failed :-( >> The variable @code{$_siginfo} is bound to extra signal information >> -inspection (@pxref{extra signal information}). >> +inspection (@pxref{extra signal information}). Note that @code{$_siginfo} >> +could be empty. For example, it will be empty before you execute the >> +@code{run} command. >> @end table > > A couple of comments: > > . "the variable ... is bound to extra signal information inspection" > is awkward wording. "How about "contains extra signal > information"? Fixed. > . I don't understand the note about it being ``empty''? What does > that mean, exactly, and why the example is talking about before > `run'? I could understand that it's empty if no signals were > delivered yet, but what does `run' has to do with this? Before the first 'run' is one rare case where the application has not yet received any signals. I think this example could be simply removed without much loss. Let me know if you'd like me to do that. > > . Please leave two spaces between sentences, not one. Sorry about that. Fixed. How does the attached patch look? Here's the doc part, so you don't have to deal with base64: Index: doc/gdb.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.624 diff -u -p -u -r1.624 gdb.texinfo --- doc/gdb.texinfo 15 Sep 2009 18:51:25 -0000 1.624 +++ doc/gdb.texinfo 17 Sep 2009 16:33:19 -0000 @@ -7819,8 +7819,10 @@ the program being debugged terminates. @item $_siginfo @vindex $_siginfo@r{, convenience variable} -The variable @code{$_siginfo} is bound to extra signal information -inspection (@pxref{extra signal information}). +The variable @code{$_siginfo} contains extra signal information +(@pxref{extra signal information}). Note that @code{$_siginfo} +could be empty, if the application has not yet received any signals. +For example, it will be empty before you execute the @code{run} command. @end table On HP-UX systems, if you refer to a function or variable name that Thanks, -- Paul Pluzhnikov testsuite/ChangeLog 2009-09-17 Paul Pluzhnikov * gdb.base/default.exp: Fix "show convenience". doc/ChangeLog 2009-09-17 Paul Pluzhnikov * gdb.texinfo (convenince variables): Mention $_siginfo could be empty. --001636c927cf65d9b50473c8a0dc Content-Type: text/plain; charset=US-ASCII; name="gdb-convenience.20090917.txt" Content-Disposition: attachment; filename="gdb-convenience.20090917.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fzpq4h5q0 Content-length: 2591 SW5kZXg6IHRlc3RzdWl0ZS9nZGIuYmFzZS9kZWZhdWx0LmV4cAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL3Rl c3RzdWl0ZS9nZGIuYmFzZS9kZWZhdWx0LmV4cCx2CnJldHJpZXZpbmcgcmV2 aXNpb24gMS4zMQpkaWZmIC11IC1wIC11IC1yMS4zMSBkZWZhdWx0LmV4cAot LS0gdGVzdHN1aXRlL2dkYi5iYXNlL2RlZmF1bHQuZXhwCTEzIEF1ZyAyMDA5 IDE0OjU4OjI3IC0wMDAwCTEuMzEKKysrIHRlc3RzdWl0ZS9nZGIuYmFzZS9k ZWZhdWx0LmV4cAkxNyBTZXAgMjAwOSAxNjozMzoxOSAtMDAwMApAQCAtNTk4 LDcgKzU5OCw3IEBAIGdkYl90ZXN0ICJzaG93IGNvbXBsYWludHMiICJNYXgg bnVtYmVyIG8KICN0ZXN0IHNob3cgY29uZmlybQogZ2RiX3Rlc3QgInNob3cg Y29uZmlybSIgIldoZXRoZXIgdG8gY29uZmlybSBwb3RlbnRpYWxseSBkYW5n ZXJvdXMgb3BlcmF0aW9ucyBpcyBvXFthLXpcXSouIiAic2hvdyBjb25maXJt IgogI3Rlc3Qgc2hvdyBjb252ZW5pZW5jZQotZ2RiX3Rlc3QgInNob3cgY29u dmVuaWVuY2UiICJObyBkZWJ1Z2dlciBjb252ZW5pZW5jZSB2YXJpYWJsZXMg bm93IGRlZmluZWQuKFxbXlxyXG5cXSpcW1xyXG5cXSkrQ29udmVuaWVuY2Ug dmFyaWFibGVzIGhhdmUgbmFtZXMgc3RhcnRpbmcgd2l0aCBcIi5cIjsoXFte XHJcblxdKlxbXHJcblxdKSt1c2UgXCJzZXRcIiBhcyBpbiBcInNldCAuZm9v ID0gNVwiIHRvIGRlZmluZSB0aGVtLiIgInNob3cgY29udmVuaWVuY2UiCitn ZGJfdGVzdCAic2hvdyBjb252ZW5pZW5jZSIgIlxcXCRfc2lnaW5mbyA9IHZv aWQiICJzaG93IGNvbnZlbmllbmNlIgogI3Rlc3Qgc2hvdyBkaXJlY3Rvcmll cwogZ2RiX3Rlc3QgInNob3cgZGlyZWN0b3JpZXMiICJTb3VyY2UgZGlyZWN0 b3JpZXMgc2VhcmNoZWQ6IC5jZGlyXFs6O1xdLmN3ZCIgInNob3cgZGlyZWN0 b3JpZXMiCiAjdGVzdCBzaG93IGVkaXRpbmcKSW5kZXg6IGRvYy9nZGIudGV4 aW5mbwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Ny Yy9zcmMvZ2RiL2RvYy9nZGIudGV4aW5mbyx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS42MjQKZGlmZiAtdSAtcCAtdSAtcjEuNjI0IGdkYi50ZXhpbmZvCi0t LSBkb2MvZ2RiLnRleGluZm8JMTUgU2VwIDIwMDkgMTg6NTE6MjUgLTAwMDAJ MS42MjQKKysrIGRvYy9nZGIudGV4aW5mbwkxNyBTZXAgMjAwOSAxNjozMzox OSAtMDAwMApAQCAtNzgxOSw4ICs3ODE5LDEwIEBAIHRoZSBwcm9ncmFtIGJl aW5nIGRlYnVnZ2VkIHRlcm1pbmF0ZXMuCiAKIEBpdGVtICRfc2lnaW5mbwog QHZpbmRleCAkX3NpZ2luZm9AcnssIGNvbnZlbmllbmNlIHZhcmlhYmxlfQot VGhlIHZhcmlhYmxlIEBjb2RleyRfc2lnaW5mb30gaXMgYm91bmQgdG8gZXh0 cmEgc2lnbmFsIGluZm9ybWF0aW9uCi1pbnNwZWN0aW9uIChAcHhyZWZ7ZXh0 cmEgc2lnbmFsIGluZm9ybWF0aW9ufSkuCitUaGUgdmFyaWFibGUgQGNvZGV7 JF9zaWdpbmZvfSBjb250YWlucyBleHRyYSBzaWduYWwgaW5mb3JtYXRpb24K KyhAcHhyZWZ7ZXh0cmEgc2lnbmFsIGluZm9ybWF0aW9ufSkuICBOb3RlIHRo YXQgQGNvZGV7JF9zaWdpbmZvfQorY291bGQgYmUgZW1wdHksIGlmIHRoZSBh cHBsaWNhdGlvbiBoYXMgbm90IHlldCByZWNlaXZlZCBhbnkgc2lnbmFscy4K K0ZvciBleGFtcGxlLCBpdCB3aWxsIGJlIGVtcHR5IGJlZm9yZSB5b3UgZXhl Y3V0ZSB0aGUgQGNvZGV7cnVufSBjb21tYW5kLgogQGVuZCB0YWJsZQogCiBP biBIUC1VWCBzeXN0ZW1zLCBpZiB5b3UgcmVmZXIgdG8gYSBmdW5jdGlvbiBv ciB2YXJpYWJsZSBuYW1lIHRoYXQK --001636c927cf65d9b50473c8a0dc--