From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6409 invoked by alias); 14 Sep 2009 18:10:47 -0000 Received: (qmail 6400 invoked by uid 22791); 14 Sep 2009 18:10:46 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Sep 2009 18:10:41 +0000 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id n8EIAdLq028226 for ; Mon, 14 Sep 2009 11:10:39 -0700 Received: from yxe5 (yxe5.prod.google.com [10.190.2.5]) by zps37.corp.google.com with ESMTP id n8EI9dbt010020 for ; Mon, 14 Sep 2009 11:10:37 -0700 Received: by yxe5 with SMTP id 5so4719022yxe.33 for ; Mon, 14 Sep 2009 11:10:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.80.5 with SMTP id h5mr6560284anl.10.1252951836918; Mon, 14 Sep 2009 11:10:36 -0700 (PDT) In-Reply-To: <20090914173554.GK8327@adacore.com> References: <8ac60eac0909131447i5a128877q585e3ab4c24f551b@mail.gmail.com> <200909141643.n8EGhjgm021351@d12av02.megacenter.de.ibm.com> <8ac60eac0909141019x77435f40p32f731dfd9df0abc@mail.gmail.com> <20090914173554.GK8327@adacore.com> Date: Mon, 14 Sep 2009 18:10:00 -0000 Message-ID: <8ac60eac0909141110h18959c04r2a08269296909db9@mail.gmail.com> Subject: Re: [patch] Speed up find_pc_section From: Paul Pluzhnikov To: Joel Brobecker Cc: Ulrich Weigand , Pierre Muller , Ulrich Weigand , gdb-patches ml , Tom Tromey , Jan Kratochvil , Christian Thalinger Content-Type: multipart/mixed; boundary=001636ed690929048c04738d9526 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00430.txt.bz2 --001636ed690929048c04738d9526 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1584 On Mon, Sep 14, 2009 at 10:35 AM, Joel Brobecker wrote: >> I've just checked in both patches. Hopefully this thread will end here, >> it's been long enough :-) > > There is still the OBJF_NOT_MAPPED patch. Given this subthread: http://sourceware.org/ml/gdb-patches/2009-09/msg00307.html I don't believe OBJF_NOT_MAPPED is the right way to go. I agree with Tristan that we should separate the 'read objfile for symbols, sections, etc.' from read an object file just for its debug bits. This would allow: - Darwin "dwarf debug is found in the separate *.o files", - Solaris cc/CC without '-xs' (dwarf or stabs debug is found in original *.o files -- very similar to Darwin), - We could then use the same on Linux and drop the separate_debug_objfile/separate_debug_objfile_backlink objfile members, as well as filter_debuginfo_sections(). Note that current checked in code on Darwin does not fail any asserts, it just doesn't work correctly and issues bazillion of complaints. Given above, I don't think committing/testing the OBJF_NOT_MAPPED patch is the right way to go -- it's more of a hack then a solution. However, if someone needs a hack, attached is the current state of the patch. Christian Thalinger tested essentially this version on his Darwin/Java build, and reported success. Cheers, -- Paul Pluzhnikov 2009-09-14 Paul Pluzhnikov * objfiles.h (OBJF_NOT_MAPPED): New define. * objfiles.c (update_section_map): Ignore not mapped objfiles. * machoread.c (macho_oso_symfile, macho_oso_symfile): Adjust. --001636ed690929048c04738d9526 Content-Type: text/plain; charset=US-ASCII; name="gdb-macho-bp-reset-20090914.txt" Content-Disposition: attachment; filename="gdb-macho-bp-reset-20090914.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fzlj0x3d0 Content-length: 4222 SW5kZXg6IG9iamZpbGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9vYmpmaWxlcy5oLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjY0CmRpZmYgLXUgLXAgLXUgLXIxLjY0IG9iamZpbGVz LmgKLS0tIG9iamZpbGVzLmgJMTEgU2VwIDIwMDkgMTg6NTE6MzEgLTAwMDAJ MS42NAorKysgb2JqZmlsZXMuaAkxNCBTZXAgMjAwOSAxODowNDo1NCAtMDAw MApAQCAtNDE0LDYgKzQxNCwxMiBAQCBzdHJ1Y3Qgb2JqZmlsZQogCiAjZGVm aW5lIE9CSkZfVVNFUkxPQURFRAkoMSA8PCAzKQkvKiBVc2VyIGxvYWRlZCAq LwogCisvKiBUaGlzIG9iamZpbGUgaXMgbm90IG1hcHBlZCBpbnRvIHRoZSBw cm9jZXNzIGFkZHJlc3Mgc3BhY2UuIFdlIG9ubHkgaGF2ZSBpdAorICAgZm9y IGl0cyBkZWJ1ZyBiaXRzLiAgT25lIGV4YW1wbGUgaXMgTUFDSC1PICgib3Ro ZXIgc291cmNlIikgb2JqZWN0CisgICBmaWxlcy4gICovCisKKyNkZWZpbmUg T0JKRl9OT1RfTUFQUEVEICgxIDw8IDQpICAgICAgICAvKiBOb3QgbWFwcGVk ICovCisKIC8qIFRoZSBvYmplY3QgZmlsZSB0aGF0IHRoZSBtYWluIHN5bWJv bCB0YWJsZSB3YXMgbG9hZGVkIGZyb20gKGUuZy4gdGhlCiAgICBhcmd1bWVu dCB0byB0aGUgInN5bWJvbC1maWxlIiBvciAiZmlsZSIgY29tbWFuZCkuICAq LwogCkluZGV4OiBvYmpmaWxlcy5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvb2JqZmlsZXMuYyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS45NgpkaWZmIC11IC1wIC11IC1yMS45NiBvYmpm aWxlcy5jCi0tLSBvYmpmaWxlcy5jCTE0IFNlcCAyMDA5IDE3OjEyOjA3IC0w MDAwCTEuOTYKKysrIG9iamZpbGVzLmMJMTQgU2VwIDIwMDkgMTg6MDQ6NTQg LTAwMDAKQEAgLTEwNDEsMTYgKzEwNDEsMjEgQEAgdXBkYXRlX3NlY3Rpb25f bWFwIChzdHJ1Y3Qgb2JqX3NlY3Rpb24gKgogICB4ZnJlZSAobWFwKTsKIAog ICBhbGxvY19zaXplID0gMDsKLSAgQUxMX09CSlNFQ1RJT05TIChvYmpmaWxl LCBzKQotICAgIGlmIChpbnNlcnRfc2VjdGlvbl9wIChvYmpmaWxlLT5vYmZk LCBzLT50aGVfYmZkX3NlY3Rpb24pKQotICAgICAgYWxsb2Nfc2l6ZSArPSAx OworCisgIEFMTF9PQkpGSUxFUyAob2JqZmlsZSkKKyAgICBpZiAoKG9iamZp bGUtPmZsYWdzICYgT0JKRl9OT1RfTUFQUEVEKSA9PSAwKQorICAgICAgQUxM X09CSkZJTEVfT1NFQ1RJT05TIChvYmpmaWxlLCBzKQorCWlmIChpbnNlcnRf c2VjdGlvbl9wIChvYmpmaWxlLT5vYmZkLCBzLT50aGVfYmZkX3NlY3Rpb24p KQorCSAgYWxsb2Nfc2l6ZSArPSAxOwogCiAgIG1hcCA9IHhtYWxsb2MgKGFs bG9jX3NpemUgKiBzaXplb2YgKCptYXApKTsKIAogICBpID0gMDsKLSAgQUxM X09CSlNFQ1RJT05TIChvYmpmaWxlLCBzKQotICAgIGlmIChpbnNlcnRfc2Vj dGlvbl9wIChvYmpmaWxlLT5vYmZkLCBzLT50aGVfYmZkX3NlY3Rpb24pKQot ICAgICAgbWFwW2krK10gPSBzOworICBBTExfT0JKRklMRVMgKG9iamZpbGUp CisgICAgaWYgKChvYmpmaWxlLT5mbGFncyAmIE9CSkZfTk9UX01BUFBFRCkg PT0gMCkKKyAgICAgIEFMTF9PQkpGSUxFX09TRUNUSU9OUyAob2JqZmlsZSwg cykKKwlpZiAoaW5zZXJ0X3NlY3Rpb25fcCAob2JqZmlsZS0+b2JmZCwgcy0+ dGhlX2JmZF9zZWN0aW9uKSkKKwkgIG1hcFtpKytdID0gczsKIAogICBxc29y dCAobWFwLCBhbGxvY19zaXplLCBzaXplb2YgKCptYXApLCBxc29ydF9jbXAp OwogICBtYXBfc2l6ZSA9IGZpbHRlcl9kZWJ1Z2luZm9fc2VjdGlvbnMobWFw LCBhbGxvY19zaXplKTsKSW5kZXg6IG1hY2hvcmVhZC5jCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvbWFjaG9y ZWFkLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNQpkaWZmIC11IC1wIC11 IC1yMS41IG1hY2hvcmVhZC5jCi0tLSBtYWNob3JlYWQuYwkxOSBKdW4gMjAw OSAxNDozMDozMCAtMDAwMAkxLjUKKysrIG1hY2hvcmVhZC5jCTE0IFNlcCAy MDA5IDE4OjA0OjU0IC0wMDAwCkBAIC00MDYsNyArNDA2LDggQEAgbWFjaG9f b3NvX3N5bWZpbGUgKHN0cnVjdCBvYmpmaWxlICptYWluXwogCSAgICAgIGJm ZF9jbG9zZSAobWVtYmVyX2JmZCk7CiAJICAgIH0KIAkgICAgZWxzZQotCSAg ICAgIHN5bWJvbF9maWxlX2FkZF9mcm9tX2JmZCAobWVtYmVyX2JmZCwgMCwg YWRkcnMsIDApOworCSAgICAgIHN5bWJvbF9maWxlX2FkZF9mcm9tX2JmZCAo bWVtYmVyX2JmZCwgU1lNRklMRV9ERUZFUl9CUF9SRVNFVCwKKwkJCQkJYWRk cnMsIE9CSkZfTk9UX01BUFBFRCk7CiAJfQogICAgICAgZWxzZQogCXsKQEAg LTQyOSw3ICs0MzAsOCBAQCBtYWNob19vc29fc3ltZmlsZSAoc3RydWN0IG9i amZpbGUgKm1haW5fCiAJICAgICAgY29udGludWU7CiAJICAgIH0KICAgCi0J ICBzeW1ib2xfZmlsZV9hZGRfZnJvbV9iZmQgKGFiZmQsIDAsIGFkZHJzLCAw KTsKKwkgIHN5bWJvbF9maWxlX2FkZF9mcm9tX2JmZCAoYWJmZCwgU1lNRklM RV9ERUZFUl9CUF9SRVNFVCwgYWRkcnMsCisJCQkJICAgIE9CSkZfTk9UX01B UFBFRCk7CiAJfQogICAgICAgeGZyZWUgKG9zby0+c3ltYm9scyk7CiAgICAg ICB4ZnJlZSAob3NvLT5vZmZzZXRzKTsKQEAgLTU5Miw3ICs1OTQsNyBAQCBt YWNob19zeW1maWxlX3JlYWQgKHN0cnVjdCBvYmpmaWxlICpvYmpmCiAJICBv c29fdmVjdG9yID0gTlVMTDsKIAogCSAgLyogTm93IHJlY3Vyc2U6IHJlYWQg ZHdhcmYgZnJvbSBkc3ltLiAgKi8KLQkgIHN5bWJvbF9maWxlX2FkZF9mcm9t X2JmZCAoZHN5bV9iZmQsIDAsIE5VTEwsIDApOworCSAgc3ltYm9sX2ZpbGVf YWRkX2Zyb21fYmZkIChkc3ltX2JmZCwgMCwgTlVMTCwgT0JKRl9OT1RfTUFQ UEVEKTsKICAgICAgIAogCSAgLyogRG9uJ3QgdHJ5IHRvIHJlYWQgZHdhcmYy IGZyb20gbWFpbiBmaWxlIG9yIHNoYXJlZCBsaWJyYXJpZXMuICAqLwogCSAg cmV0dXJuOwo= --001636ed690929048c04738d9526--