From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14580 invoked by alias); 11 Sep 2009 08:03:11 -0000 Received: (qmail 14530 invoked by uid 22791); 11 Sep 2009 08:03:10 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 08:03:06 +0000 Received: from spaceape14.eur.corp.google.com (spaceape14.eur.corp.google.com [172.28.16.148]) by smtp-out.google.com with ESMTP id n8B834oT022792 for ; Fri, 11 Sep 2009 09:03:04 +0100 Received: from ywh9 (ywh9.prod.google.com [10.192.8.9]) by spaceape14.eur.corp.google.com with ESMTP id n8B831sK006342 for ; Fri, 11 Sep 2009 01:03:02 -0700 Received: by ywh9 with SMTP id 9so1256617ywh.32 for ; Fri, 11 Sep 2009 01:03:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.207.25 with SMTP id j25mr2861315anq.19.1252656181319; Fri, 11 Sep 2009 01:03:01 -0700 (PDT) In-Reply-To: <000f01ca32b3$0e6b5390$2b41fab0$@u-strasbg.fr> References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> <20090909055824.GB11738@adacore.com> <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> <20090910182952.GK20694@adacore.com> <8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> <000c01ca32ac$0ca9f8b0$25fdea10$@u-strasbg.fr> <8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com> <000f01ca32b3$0e6b5390$2b41fab0$@u-strasbg.fr> Date: Fri, 11 Sep 2009 08:03:00 -0000 Message-ID: <8ac60eac0909110103l2b88dc95i2f3c238aa4be2ed0@mail.gmail.com> Subject: Re: [patch] Speed up find_pc_section From: Paul Pluzhnikov To: Pierre Muller Cc: Joel Brobecker , Ulrich Weigand , gdb-patches ml , Tom Tromey , Jan Kratochvil Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00309.txt.bz2 On Fri, Sep 11, 2009 at 12:39 AM, Pierre Muller w= rote: >> All overlaps are removed in filter_overlapping_sections, before the >> first binary search is performed. > > =A0This is where I get lost: > I see no code in filter_overlapping_sections > that changes map_size, so how are these overlapping > elements removed and what is put in their place? Ah, that's a bug; thanks for catching it. The filter_overlapping_sections was supposed to return 'j', not 'map_size'. I'll retest an updated patch and send it in tomorrow. --=20 Paul Pluzhnikov