From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14226 invoked by alias); 11 Sep 2009 07:51:07 -0000 Received: (qmail 14218 invoked by uid 22791); 11 Sep 2009 07:51:06 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 07:51:02 +0000 Received: from zps35.corp.google.com (zps35.corp.google.com [172.25.146.35]) by smtp-out.google.com with ESMTP id n8B7oxoQ028741 for ; Fri, 11 Sep 2009 00:50:59 -0700 Received: from an-out-0708.google.com (anab2.prod.google.com [10.100.53.2]) by zps35.corp.google.com with ESMTP id n8B7oROW000515 for ; Fri, 11 Sep 2009 00:50:57 -0700 Received: by an-out-0708.google.com with SMTP id b2so344988ana.31 for ; Fri, 11 Sep 2009 00:50:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.49.19 with SMTP id b19mr2781745ank.146.1252655455764; Fri, 11 Sep 2009 00:50:55 -0700 (PDT) In-Reply-To: <200909110739.n8B7dbc6028614@brahms.sibelius.xs4all.nl> References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> <20090909055824.GB11738@adacore.com> <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> <20090910182952.GK20694@adacore.com> <8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> <000c01ca32ac$0ca9f8b0$25fdea10$@u-strasbg.fr> <8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com> <200909110739.n8B7dbc6028614@brahms.sibelius.xs4all.nl> Date: Fri, 11 Sep 2009 07:51:00 -0000 Message-ID: <8ac60eac0909110050l19c4d3f3m3797fb2cf535f4a2@mail.gmail.com> Subject: Re: [patch] Speed up find_pc_section From: Paul Pluzhnikov To: Mark Kettenis Cc: muller@ics.u-strasbg.fr, brobecker@adacore.com, Ulrich.Weigand@de.ibm.com, gdb-patches@sourceware.org, tromey@redhat.com, jan.kratochvil@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00305.txt.bz2 On Fri, Sep 11, 2009 at 12:39 AM, Mark Kettenis w= rote: >> - =A0return 0; >> + =A0if (sect1->objfile->mtime < sect2->objfile->mtime) return -1; >> + =A0if (sect1->objfile->mtime > sect2->objfile->mtime) return 1; >> + =A0return 0; >> } > > This snippet caught my eye. =A0Please put those return statements on a > line of their own. This wasn't a real patch, just something I typed by hand. Yes, I will certainly put return on a separate line IF it is considered reasonable (which I somewhat doubt). --=20 Paul Pluzhnikov