From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27868 invoked by alias); 10 Sep 2009 16:18:37 -0000 Received: (qmail 27836 invoked by uid 22791); 10 Sep 2009 16:18:33 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Sep 2009 16:18:29 +0000 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id n8AGIQJE001561 for ; Thu, 10 Sep 2009 09:18:27 -0700 Received: from yxe27 (yxe27.prod.google.com [10.190.2.27]) by wpaz24.hot.corp.google.com with ESMTP id n8AGIOTa020590 for ; Thu, 10 Sep 2009 09:18:24 -0700 Received: by yxe27 with SMTP id 27so323173yxe.10 for ; Thu, 10 Sep 2009 09:18:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.192.12 with SMTP id p12mr1730279anf.142.1252599504297; Thu, 10 Sep 2009 09:18:24 -0700 (PDT) In-Reply-To: <20090909053848.GA11738@adacore.com> References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <20090909053848.GA11738@adacore.com> Date: Thu, 10 Sep 2009 16:18:00 -0000 Message-ID: <8ac60eac0909100918y6e5b4738t8ee0d53f110ac4c8@mail.gmail.com> Subject: Re: [patch] Speed up find_pc_section From: Paul Pluzhnikov To: Joel Brobecker Cc: Ulrich Weigand , Ulrich Weigand , gdb-patches ml , Tom Tromey Content-Type: multipart/mixed; boundary=0016364ed1947fe23604733b8c78 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00274.txt.bz2 --0016364ed1947fe23604733b8c78 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 517 On Tue, Sep 8, 2009 at 10:38 PM, Joel Brobecker wrote: > Otherwise, the patch seems fine. I would love some input from Ulrich, > though. Thanks for the review. Attached patch implements your suggestions. -- Paul Pluzhnikov 2009-09-10 Paul Pluzhnikov *minsyms.c (lookup_minimal_symbol_by_pc_section_1): Assert non-NULL section. (lookup_minimal_symbol_by_pc_section): Check for NULL section. (lookup_minimal_symbol_by_pc): Adjust. --0016364ed1947fe23604733b8c78 Content-Type: text/plain; charset=US-ASCII; name="gdb-overlay-fix-20090910.txt" Content-Disposition: attachment; filename="gdb-overlay-fix-20090910.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fzfpdptx0 Content-length: 5608 SW5kZXg6IG1pbnN5bXMuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL21pbnN5bXMuYyx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS42NgpkaWZmIC11IC1wIC11IC1yMS42NiBtaW5zeW1zLmMK LS0tIG1pbnN5bXMuYwkyOCBKdW4gMjAwOSAwMDoyMDoyMiAtMDAwMAkxLjY2 CisrKyBtaW5zeW1zLmMJMTAgU2VwIDIwMDkgMTY6MTc6MTMgLTAwMDAKQEAg LTQzNCwxMyArNDM0LDE0IEBAIGxvb2t1cF9taW5pbWFsX3N5bWJvbF9zb2xp Yl90cmFtcG9saW5lICgKIAogLyogU2VhcmNoIHRocm91Z2ggdGhlIG1pbmlt YWwgc3ltYm9sIHRhYmxlIGZvciBlYWNoIG9iamZpbGUgYW5kIGZpbmQKICAg IHRoZSBzeW1ib2wgd2hvc2UgYWRkcmVzcyBpcyB0aGUgbGFyZ2VzdCBhZGRy ZXNzIHRoYXQgaXMgc3RpbGwgbGVzcwotICAgdGhhbiBvciBlcXVhbCB0byBQ QywgYW5kIG1hdGNoZXMgU0VDVElPTiAoaWYgbm9uLU5VTEwpLiAgUmV0dXJu cyBhCi0gICBwb2ludGVyIHRvIHRoZSBtaW5pbWFsIHN5bWJvbCBpZiBzdWNo IGEgc3ltYm9sIGlzIGZvdW5kLCBvciBOVUxMIGlmCi0gICBQQyBpcyBub3Qg aW4gYSBzdWl0YWJsZSByYW5nZS4gIE5vdGUgdGhhdCB3ZSBuZWVkIHRvIGxv b2sgdGhyb3VnaAotICAgQUxMIHRoZSBtaW5pbWFsIHN5bWJvbCB0YWJsZXMg YmVmb3JlIGRlY2lkaW5nIG9uIHRoZSBzeW1ib2wgdGhhdAotICAgY29tZXMg Y2xvc2VzdCB0byB0aGUgc3BlY2lmaWVkIFBDLiAgVGhpcyBpcyBiZWNhdXNl IG9iamZpbGVzIGNhbgotICAgb3ZlcmxhcCwgZm9yIGV4YW1wbGUgb2JqZmls ZSBBIGhhcyAudGV4dCBhdCAweDEwMCBhbmQgLmRhdGEgYXQKLSAgIDB4NDAw MDAgYW5kIG9iamZpbGUgQiBoYXMgLnRleHQgYXQgMHgyMzQgYW5kIC5kYXRh IGF0IDB4NDAwNDguCisgICB0aGFuIG9yIGVxdWFsIHRvIFBDLCBhbmQgbWF0 Y2hlcyBTRUNUSU9OICh3aGljaCBpcyBub3QgTlVMTCkuCisgICBSZXR1cm5z IGEgcG9pbnRlciB0byB0aGUgbWluaW1hbCBzeW1ib2wgaWYgc3VjaCBhIHN5 bWJvbCBpcyBmb3VuZCwKKyAgIG9yIE5VTEwgaWYgUEMgaXMgbm90IGluIGEg c3VpdGFibGUgcmFuZ2UuCisgICBOb3RlIHRoYXQgd2UgbmVlZCB0byBsb29r IHRocm91Z2ggQUxMIHRoZSBtaW5pbWFsIHN5bWJvbCB0YWJsZXMKKyAgIGJl Zm9yZSBkZWNpZGluZyBvbiB0aGUgc3ltYm9sIHRoYXQgY29tZXMgY2xvc2Vz dCB0byB0aGUgc3BlY2lmaWVkIFBDLgorICAgVGhpcyBpcyBiZWNhdXNlIG9i amZpbGVzIGNhbiBvdmVybGFwLCBmb3IgZXhhbXBsZSBvYmpmaWxlIEEgaGFz IC50ZXh0CisgICBhdCAweDEwMCBhbmQgLmRhdGEgYXQgMHg0MDAwMCBhbmQg b2JqZmlsZSBCIGhhcyAudGV4dCBhdCAweDIzNCBhbmQKKyAgIC5kYXRhIGF0 IDB4NDAwNDguCiAKICAgIElmIFdBTlRfVFJBTVBPTElORSBpcyBzZXQsIHBy ZWZlciBtc3Rfc29saWJfdHJhbXBvbGluZSBzeW1ib2xzIHdoZW4KICAgIHRo ZXJlIGFyZSB0ZXh0IGFuZCB0cmFtcG9saW5lIHN5bWJvbHMgYXQgdGhlIHNh bWUgYWRkcmVzcy4KQEAgLTQ1NywyMCArNDU4LDEyIEBAIGxvb2t1cF9taW5p bWFsX3N5bWJvbF9ieV9wY19zZWN0aW9uXzEgKEMKICAgc3RydWN0IG9iamZp bGUgKm9iamZpbGU7CiAgIHN0cnVjdCBtaW5pbWFsX3N5bWJvbCAqbXN5bWJv bDsKICAgc3RydWN0IG1pbmltYWxfc3ltYm9sICpiZXN0X3N5bWJvbCA9IE5V TEw7Ci0gIHN0cnVjdCBvYmpfc2VjdGlvbiAqcGNfc2VjdGlvbjsKICAgZW51 bSBtaW5pbWFsX3N5bWJvbF90eXBlIHdhbnRfdHlwZSwgb3RoZXJfdHlwZTsK IAogICB3YW50X3R5cGUgPSB3YW50X3RyYW1wb2xpbmUgPyBtc3Rfc29saWJf dHJhbXBvbGluZSA6IG1zdF90ZXh0OwogICBvdGhlcl90eXBlID0gd2FudF90 cmFtcG9saW5lID8gbXN0X3RleHQgOiBtc3Rfc29saWJfdHJhbXBvbGluZTsK LSAgCi0gIC8qIFBDIGhhcyB0byBiZSBpbiBhIGtub3duIHNlY3Rpb24uICBU aGlzIGVuc3VyZXMgdGhhdCBhbnl0aGluZwotICAgICBiZXlvbmQgdGhlIGVu ZCBvZiB0aGUgbGFzdCBzZWdtZW50IGRvZXNuJ3QgYXBwZWFyIHRvIGJlIHBh cnQgb2YKLSAgICAgdGhlIGxhc3QgZnVuY3Rpb24gaW4gdGhlIGxhc3Qgc2Vn bWVudC4gICovCi0gIHBjX3NlY3Rpb24gPSBmaW5kX3BjX3NlY3Rpb24gKHBj KTsKLSAgaWYgKHBjX3NlY3Rpb24gPT0gTlVMTCkKLSAgICByZXR1cm4gTlVM TDsKIAotICAvKiBXZSBjYW4gbm90IHJlcXVpcmUgdGhlIHN5bWJvbCBmb3Vu ZCB0byBiZSBpbiBwY19zZWN0aW9uLCBiZWNhdXNlCisgIC8qIFdlIGNhbiBu b3QgcmVxdWlyZSB0aGUgc3ltYm9sIGZvdW5kIHRvIGJlIGluIHNlY3Rpb24s IGJlY2F1c2UKICAgICAgZS5nLiBJUklYIDYuNSBtZGVidWcgcmVsaWVzIG9u IHRoaXMgY29kZSByZXR1cm5pbmcgYW4gYWJzb2x1dGUKICAgICAgc3ltYm9s IC0gYnV0IGZpbmRfcGNfc2VjdGlvbiB3b24ndCByZXR1cm4gYW4gYWJzb2x1 dGUgc2VjdGlvbiBhbmQKICAgICAgaGVuY2UgdGhlIGNvZGUgYmVsb3cgd291 bGQgc2tpcCBvdmVyIGFic29sdXRlIHN5bWJvbHMuICBXZSBjYW4KQEAgLTQ3 OSw3ICs0NzIsOCBAQCBsb29rdXBfbWluaW1hbF9zeW1ib2xfYnlfcGNfc2Vj dGlvbl8xIChDCiAgICAgIGZpbGVzLCBzZWFyY2ggYm90aCB0aGUgZmlsZSBh bmQgaXRzIHNlcGFyYXRlIGRlYnVnIGZpbGUuICBUaGVyZSdzCiAgICAgIG5v IHRlbGxpbmcgd2hpY2ggb25lIHdpbGwgaGF2ZSB0aGUgbWluaW1hbCBzeW1i b2xzLiAgKi8KIAotICBvYmpmaWxlID0gcGNfc2VjdGlvbi0+b2JqZmlsZTsK KyAgZ2RiX2Fzc2VydCAoc2VjdGlvbiAhPSBOVUxMKTsKKyAgb2JqZmlsZSA9 IHNlY3Rpb24tPm9iamZpbGU7CiAgIGlmIChvYmpmaWxlLT5zZXBhcmF0ZV9k ZWJ1Z19vYmpmaWxlKQogICAgIG9iamZpbGUgPSBvYmpmaWxlLT5zZXBhcmF0 ZV9kZWJ1Z19vYmpmaWxlOwogCkBAIC02ODAsNiArNjc0LDE1IEBAIGxvb2t1 cF9taW5pbWFsX3N5bWJvbF9ieV9wY19zZWN0aW9uXzEgKEMKIHN0cnVjdCBt aW5pbWFsX3N5bWJvbCAqCiBsb29rdXBfbWluaW1hbF9zeW1ib2xfYnlfcGNf c2VjdGlvbiAoQ09SRV9BRERSIHBjLCBzdHJ1Y3Qgb2JqX3NlY3Rpb24gKnNl Y3Rpb24pCiB7CisgIGlmIChzZWN0aW9uID09IE5VTEwpCisgICAgeworICAg ICAgLyogTk9URTogY2FnbmV5LzIwMDQtMDEtMjc6IFRoaXMgd2FzIHVzaW5n IGZpbmRfcGNfbWFwcGVkX3NlY3Rpb24gdG8KKwkgZm9yY2UgdGhlIHNlY3Rp b24gYnV0IHRoYXQgKHdlbGwgdW5sZXNzIHlvdSdyZSBkb2luZyBvdmVybGF5 CisJIGRlYnVnZ2luZykgYWx3YXlzIHJldHVybnMgTlVMTCBtYWtpbmcgdGhl IGNhbGwgc29tZXdoYXQgdXNlbGVzcy4gICovCisgICAgICBzZWN0aW9uID0g ZmluZF9wY19zZWN0aW9uIChwYyk7CisgICAgICBpZiAoc2VjdGlvbiA9PSBO VUxMKQorCXJldHVybiBOVUxMOworICAgIH0KICAgcmV0dXJuIGxvb2t1cF9t aW5pbWFsX3N5bWJvbF9ieV9wY19zZWN0aW9uXzEgKHBjLCBzZWN0aW9uLCAw KTsKIH0KIApAQCAtNjg5LDEzICs2OTIsNyBAQCBsb29rdXBfbWluaW1hbF9z eW1ib2xfYnlfcGNfc2VjdGlvbiAoQ09SCiBzdHJ1Y3QgbWluaW1hbF9zeW1i b2wgKgogbG9va3VwX21pbmltYWxfc3ltYm9sX2J5X3BjIChDT1JFX0FERFIg cGMpCiB7Ci0gIC8qIE5PVEU6IGNhZ25leS8yMDA0LTAxLTI3OiBUaGlzIHdh cyB1c2luZyBmaW5kX3BjX21hcHBlZF9zZWN0aW9uIHRvCi0gICAgIGZvcmNl IHRoZSBzZWN0aW9uIGJ1dCB0aGF0ICh3ZWxsIHVubGVzcyB5b3UncmUgZG9p bmcgb3ZlcmxheQotICAgICBkZWJ1Z2dpbmcpIGFsd2F5cyByZXR1cm5zIE5V TEwgbWFraW5nIHRoZSBjYWxsIHNvbWV3aGF0IHVzZWxlc3MuICAqLwotICBz dHJ1Y3Qgb2JqX3NlY3Rpb24gKnNlY3Rpb24gPSBmaW5kX3BjX3NlY3Rpb24g KHBjKTsKLSAgaWYgKHNlY3Rpb24gPT0gTlVMTCkKLSAgICByZXR1cm4gTlVM TDsKLSAgcmV0dXJuIGxvb2t1cF9taW5pbWFsX3N5bWJvbF9ieV9wY19zZWN0 aW9uIChwYywgc2VjdGlvbik7CisgIHJldHVybiBsb29rdXBfbWluaW1hbF9z eW1ib2xfYnlfcGNfc2VjdGlvbiAocGMsIE5VTEwpOwogfQogDAogCg== --0016364ed1947fe23604733b8c78--