From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18415 invoked by alias); 2 Sep 2009 17:16:06 -0000 Received: (qmail 18406 invoked by uid 22791); 2 Sep 2009 17:16:04 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Sep 2009 17:15:59 +0000 Received: from zps18.corp.google.com (zps18.corp.google.com [172.25.146.18]) by smtp-out.google.com with ESMTP id n82HFtrQ019516 for ; Wed, 2 Sep 2009 18:15:55 +0100 Received: from an-out-0708.google.com (andd14.prod.google.com [10.100.30.14]) by zps18.corp.google.com with ESMTP id n82HFqDt030701 for ; Wed, 2 Sep 2009 10:15:52 -0700 Received: by an-out-0708.google.com with SMTP id d14so516540and.36 for ; Wed, 02 Sep 2009 10:15:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.7.25 with SMTP id k25mr9183209ani.192.1251911752255; Wed, 02 Sep 2009 10:15:52 -0700 (PDT) In-Reply-To: <200909021747.27651.pedro@codesourcery.com> References: <20090902163344.833F476568@localhost> <200909021747.27651.pedro@codesourcery.com> Date: Wed, 02 Sep 2009 17:16:00 -0000 Message-ID: <8ac60eac0909021015u37d1a6e2u1ae88dd35d00d2b9@mail.gmail.com> Subject: Re: [patch] Allow gdbserver to dynamically lookup libthread_db.so.1 From: Paul Pluzhnikov To: Pedro Alves Cc: gdb-patches@sourceware.org, dje@google.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00064.txt.bz2 On Wed, Sep 2, 2009 at 9:47 AM, Pedro Alves wrote: > Since you're touching this, how about loading a thread_db per-process > like gdb/linux-thread-db.c already does? Oh, I've had this patch locally for so long, I didn't realize gdbserver is now multi-process as well. Will fix. > Did you intend to remove this? > >> - =A0/* If the thread layer is not (yet) initialized, fail. =A0*/ >> - =A0if (!get_thread_process (thread)->all_symbols_looked_up) >> - =A0 =A0return TD_ERR; No, I must have accidentally killed it. >> -AC_PREREQ(2.59)dnl >> +AC_PREREQ(2.64)dnl > > This should be a separate change. I still can't get a good mental model of autotools :-( Given gdbserver/acinclude.m4 change, I should include gdbserver/configure change here, but not gdbserver/configure.ac, right? Thanks, --=20 Paul Pluzhnikov