From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29270 invoked by alias); 23 Aug 2009 22:48:52 -0000 Received: (qmail 29256 invoked by uid 22791); 23 Aug 2009 22:48:49 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 23 Aug 2009 22:48:42 +0000 Received: from spaceape10.eur.corp.google.com (spaceape10.eur.corp.google.com [172.28.16.144]) by smtp-out.google.com with ESMTP id n7NMmcYZ011333 for ; Sun, 23 Aug 2009 15:48:39 -0700 Received: from pxi31 (pxi31.prod.google.com [10.243.27.31]) by spaceape10.eur.corp.google.com with ESMTP id n7NMmZKQ005909 for ; Sun, 23 Aug 2009 15:48:36 -0700 Received: by pxi31 with SMTP id 31so2331297pxi.24 for ; Sun, 23 Aug 2009 15:48:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.200.7 with SMTP id x7mr1794858rvf.166.1251067715185; Sun, 23 Aug 2009 15:48:35 -0700 (PDT) In-Reply-To: <200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> Date: Sun, 23 Aug 2009 23:25:00 -0000 Message-ID: <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> Subject: Re: [patch] Speed up find_pc_section From: Paul Pluzhnikov To: Ulrich Weigand Cc: Ulrich Weigand , gdb-patches ml , Tom Tromey Content-Type: multipart/mixed; boundary=000e0cd2142cc0eef90471d6e6da X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00373.txt.bz2 --000e0cd2142cc0eef90471d6e6da Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 910 On Fri, Aug 21, 2009 at 4:30 AM, Ulrich Weigand wrote: > (A cleaner fix might be to fix all callers to never pass in a NULL > section argument --most already don't-- and simply rely on it.) Attached patch does that ... Not tested (I still haven't figured out how to test overlays). > I'm still not completely happy about the assertions you added. =A0An > assertion failure is supposed to be an indication of a bug in GDB > -- it should never be possible to trigger the assertion just by > providing particular user input (this includes the binary file). I am still working on fixing that part... Thanks, -- Paul Pluzhnikov 2009-08-23 Paul Pluzhnikov * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Assume non-NULL section. (lookup_minimal_symbol_by_pc_section): Check for NULL section. (lookup_minimal_symbol_by_pc): Adjust. --000e0cd2142cc0eef90471d6e6da Content-Type: text/plain; charset=US-ASCII; name="gdb-overlay-fix-20090823.txt" Content-Disposition: attachment; filename="gdb-overlay-fix-20090823.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fyqd963u0 Content-length: 2823 SW5kZXg6IG1pbnN5bXMuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL21pbnN5bXMuYyx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS42NgpkaWZmIC11IC1wIC11IC1yMS42NiBtaW5zeW1zLmMK LS0tIG1pbnN5bXMuYwkyOCBKdW4gMjAwOSAwMDoyMDoyMiAtMDAwMAkxLjY2 CisrKyBtaW5zeW1zLmMJMjIgQXVnIDIwMDkgMTg6MDE6MzcgLTAwMDAKQEAg LTQ1NywxOCArNDU3LDEwIEBAIGxvb2t1cF9taW5pbWFsX3N5bWJvbF9ieV9w Y19zZWN0aW9uXzEgKEMKICAgc3RydWN0IG9iamZpbGUgKm9iamZpbGU7CiAg IHN0cnVjdCBtaW5pbWFsX3N5bWJvbCAqbXN5bWJvbDsKICAgc3RydWN0IG1p bmltYWxfc3ltYm9sICpiZXN0X3N5bWJvbCA9IE5VTEw7Ci0gIHN0cnVjdCBv Ympfc2VjdGlvbiAqcGNfc2VjdGlvbjsKICAgZW51bSBtaW5pbWFsX3N5bWJv bF90eXBlIHdhbnRfdHlwZSwgb3RoZXJfdHlwZTsKIAogICB3YW50X3R5cGUg PSB3YW50X3RyYW1wb2xpbmUgPyBtc3Rfc29saWJfdHJhbXBvbGluZSA6IG1z dF90ZXh0OwogICBvdGhlcl90eXBlID0gd2FudF90cmFtcG9saW5lID8gbXN0 X3RleHQgOiBtc3Rfc29saWJfdHJhbXBvbGluZTsKLSAgCi0gIC8qIFBDIGhh cyB0byBiZSBpbiBhIGtub3duIHNlY3Rpb24uICBUaGlzIGVuc3VyZXMgdGhh dCBhbnl0aGluZwotICAgICBiZXlvbmQgdGhlIGVuZCBvZiB0aGUgbGFzdCBz ZWdtZW50IGRvZXNuJ3QgYXBwZWFyIHRvIGJlIHBhcnQgb2YKLSAgICAgdGhl IGxhc3QgZnVuY3Rpb24gaW4gdGhlIGxhc3Qgc2VnbWVudC4gICovCi0gIHBj X3NlY3Rpb24gPSBmaW5kX3BjX3NlY3Rpb24gKHBjKTsKLSAgaWYgKHBjX3Nl Y3Rpb24gPT0gTlVMTCkKLSAgICByZXR1cm4gTlVMTDsKIAogICAvKiBXZSBj YW4gbm90IHJlcXVpcmUgdGhlIHN5bWJvbCBmb3VuZCB0byBiZSBpbiBwY19z ZWN0aW9uLCBiZWNhdXNlCiAgICAgIGUuZy4gSVJJWCA2LjUgbWRlYnVnIHJl bGllcyBvbiB0aGlzIGNvZGUgcmV0dXJuaW5nIGFuIGFic29sdXRlCkBAIC00 NzksNyArNDcxLDcgQEAgbG9va3VwX21pbmltYWxfc3ltYm9sX2J5X3BjX3Nl Y3Rpb25fMSAoQwogICAgICBmaWxlcywgc2VhcmNoIGJvdGggdGhlIGZpbGUg YW5kIGl0cyBzZXBhcmF0ZSBkZWJ1ZyBmaWxlLiAgVGhlcmUncwogICAgICBu byB0ZWxsaW5nIHdoaWNoIG9uZSB3aWxsIGhhdmUgdGhlIG1pbmltYWwgc3lt Ym9scy4gICovCiAKLSAgb2JqZmlsZSA9IHBjX3NlY3Rpb24tPm9iamZpbGU7 CisgIG9iamZpbGUgPSBzZWN0aW9uLT5vYmpmaWxlOwogICBpZiAob2JqZmls ZS0+c2VwYXJhdGVfZGVidWdfb2JqZmlsZSkKICAgICBvYmpmaWxlID0gb2Jq ZmlsZS0+c2VwYXJhdGVfZGVidWdfb2JqZmlsZTsKIApAQCAtNjgwLDYgKzY3 MiwxMiBAQCBsb29rdXBfbWluaW1hbF9zeW1ib2xfYnlfcGNfc2VjdGlvbl8x IChDCiBzdHJ1Y3QgbWluaW1hbF9zeW1ib2wgKgogbG9va3VwX21pbmltYWxf c3ltYm9sX2J5X3BjX3NlY3Rpb24gKENPUkVfQUREUiBwYywgc3RydWN0IG9i al9zZWN0aW9uICpzZWN0aW9uKQogeworICBpZiAoc2VjdGlvbiA9PSBOVUxM KQorICAgIHsKKyAgICAgIHNlY3Rpb24gPSBmaW5kX3BjX3NlY3Rpb24gKHBj KTsKKyAgICAgIGlmIChzZWN0aW9uID09IE5VTEwpCisJcmV0dXJuIE5VTEw7 CisgICAgfQogICByZXR1cm4gbG9va3VwX21pbmltYWxfc3ltYm9sX2J5X3Bj X3NlY3Rpb25fMSAocGMsIHNlY3Rpb24sIDApOwogfQogCkBAIC02OTUsNyAr NjkzLDcgQEAgbG9va3VwX21pbmltYWxfc3ltYm9sX2J5X3BjIChDT1JFX0FE RFIgcAogICBzdHJ1Y3Qgb2JqX3NlY3Rpb24gKnNlY3Rpb24gPSBmaW5kX3Bj X3NlY3Rpb24gKHBjKTsKICAgaWYgKHNlY3Rpb24gPT0gTlVMTCkKICAgICBy ZXR1cm4gTlVMTDsKLSAgcmV0dXJuIGxvb2t1cF9taW5pbWFsX3N5bWJvbF9i eV9wY19zZWN0aW9uIChwYywgc2VjdGlvbik7CisgIHJldHVybiBsb29rdXBf bWluaW1hbF9zeW1ib2xfYnlfcGNfc2VjdGlvbl8xIChwYywgc2VjdGlvbiwg MCk7CiB9CiAMCiAK --000e0cd2142cc0eef90471d6e6da--