From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24246 invoked by alias); 20 Aug 2009 20:40:26 -0000 Received: (qmail 24236 invoked by uid 22791); 20 Aug 2009 20:40:25 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Aug 2009 20:40:17 +0000 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id n7KKeEV6002913 for ; Thu, 20 Aug 2009 21:40:14 +0100 Received: from rv-out-0506.google.com (rvfb25.prod.google.com [10.140.179.25]) by wpaz37.hot.corp.google.com with ESMTP id n7KKeB7W012345 for ; Thu, 20 Aug 2009 13:40:11 -0700 Received: by rv-out-0506.google.com with SMTP id b25so65768rvf.9 for ; Thu, 20 Aug 2009 13:40:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.141.18.9 with SMTP id v9mr182451rvi.89.1250800811137; Thu, 20 Aug 2009 13:40:11 -0700 (PDT) In-Reply-To: <200908201822.n7KIM1vZ008118@d12av02.megacenter.de.ibm.com> References: <8ac60eac0908201057y44de0b84gdf193f2e2a81bc68@mail.gmail.com> <200908201822.n7KIM1vZ008118@d12av02.megacenter.de.ibm.com> Date: Thu, 20 Aug 2009 21:06:00 -0000 Message-ID: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> Subject: Re: [patch] Speed up find_pc_section From: Paul Pluzhnikov To: Ulrich Weigand Cc: Ulrich Weigand , gdb-patches ml , Tom Tromey Content-Type: multipart/mixed; boundary=000e0cd14cd4085cd0047198c2b7 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00329.txt.bz2 --000e0cd14cd4085cd0047198c2b7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1424 On Thu, Aug 20, 2009 at 11:22 AM, Ulrich Weigand wrote: > Unfortunately, this doesn't help. ... > If you want to remove *all* overlay sections, mapped or not, you Yes. > could attempt to use "section_is_overlay" instead. =A0But that won't > work either -- all the overlay routines have a shortcut that says > "no" to all such questions before the user actually enabled overlay > support. =A0This means that when loading a binary with overlays, > you still crash at the assertion before the user even has the > chance to give the "overlay auto" command. Right. Here is an updated patch ... > It used to be the case that you could debug -to some extent- binaries > with overlays even in "overlay off" mode, e.g. because GDB does not > support the particular overlay manager. =A0I think this should be preserv= ed; > at least GDB should not run into assertion failures just because section > addresses overlap ... I believe the crash at load should be gone now, and some debugging will be possible, though find_pc_section will fail to find any overlay section which find_pc_mapped_section doesn't find. I think that's still better than what GDB was doing before under these conditions: finding a "random" overlapping overlay section. Thanks, --=20 Paul Pluzhnikov 2009-08-20 Paul Pluzhnikov *objfiles.c (insert_section_p): New function. (update_section_map): Call it. --000e0cd14cd4085cd0047198c2b7 Content-Type: text/plain; charset=US-ASCII; name="gdb-find_pc_section-20090820-2.txt" Content-Disposition: attachment; filename="gdb-find_pc_section-20090820-2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fylyhvcg0 Content-length: 2294 SW5kZXg6IG9iamZpbGVzLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9vYmpmaWxlcy5jLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjkyCmRpZmYgLXUgLXAgLXUgLXIxLjkyIG9iamZpbGVz LmMKLS0tIG9iamZpbGVzLmMJMTcgQXVnIDIwMDkgMTE6MTY6MTMgLTAwMDAJ MS45MgorKysgb2JqZmlsZXMuYwkyMCBBdWcgMjAwOSAyMDozNzoyMiAtMDAw MApAQCAtODIzLDYgKzgyMywyNCBAQCBwcmVmZXJyZWRfb2JqX3NlY3Rpb24g KHN0cnVjdCBvYmpfc2VjdGlvCiAgIHJldHVybiBiOwogfQogCisvKiBSZXR1 cm4gMSBpZiBTRUNUSU9OIHNob3VsZCBiZSBpbnNlcnRlZCBpbnRvIHRoZSBz ZWN0aW9uIG1hcC4KKyAgIFdlIHdhbnQgdG8gaW5zZXJ0IG9ubHkgbm9uLW92 ZXJsYXkgYW5kIG5vbi1UTFMgc2VjdGlvbi4gICovCisKK3N0YXRpYyBpbnQK K2luc2VydF9zZWN0aW9uX3AgKGNvbnN0IHN0cnVjdCBiZmQgKmFiZmQsCisJ CSAgY29uc3Qgc3RydWN0IGJmZF9zZWN0aW9uICpzZWN0aW9uKQoreworICBj b25zdCBiZmRfdm1hIGxtYSA9IGJmZF9zZWN0aW9uX2xtYSAoYWJmZCwgc2Vj dGlvbik7CisKKyAgaWYgKGxtYSAhPSAwICYmIGxtYSAhPSBiZmRfc2VjdGlv bl92bWEgKGFiZmQsIHNlY3Rpb24pKQorICAgIC8qIFRoaXMgaXMgYW4gb3Zl cmxheSBzZWN0aW9uLiAgKi8KKyAgICByZXR1cm4gMDsKKyAgaWYgKChiZmRf Z2V0X3NlY3Rpb25fZmxhZ3MgKGFiZmQsIHNlY3Rpb24pICYgU0VDX1RIUkVB RF9MT0NBTCkgIT0gMCkKKyAgICByZXR1cm4gMDsKKworICByZXR1cm4gMTsK K30KKwogLyogVXBkYXRlIFBNQVAsIFBNQVBfU0laRSB3aXRoIG5vbi1UTFMg c2VjdGlvbnMgZnJvbSBhbGwgb2JqZmlsZXMuICAqLwogCiBzdGF0aWMgdm9p ZApAQCAtODM3LDI0ICs4NTUsMTggQEAgdXBkYXRlX3NlY3Rpb25fbWFwIChz dHJ1Y3Qgb2JqX3NlY3Rpb24gKgogICBtYXAgPSAqcG1hcDsKICAgeGZyZWUg KG1hcCk7CiAKLSNkZWZpbmUgaW5zZXJ0X3Aob2JqZiwgc2VjKSBcCi0gICgo YmZkX2dldF9zZWN0aW9uX2ZsYWdzICgob2JqZiktPm9iZmQsIChzZWMpLT50 aGVfYmZkX3NlY3Rpb24pIFwKLSAgICAmIFNFQ19USFJFQURfTE9DQUwpID09 IDApCi0KICAgbWFwX3NpemUgPSAwOwogICBBTExfT0JKU0VDVElPTlMgKG9i amZpbGUsIHMpCi0gICAgaWYgKGluc2VydF9wIChvYmpmaWxlLCBzKSkKKyAg ICBpZiAoaW5zZXJ0X3NlY3Rpb25fcCAob2JqZmlsZS0+b2JmZCwgcy0+dGhl X2JmZF9zZWN0aW9uKSkKICAgICAgIG1hcF9zaXplICs9IDE7CiAKICAgbWFw ID0geG1hbGxvYyAobWFwX3NpemUgKiBzaXplb2YgKCptYXApKTsKIAogICBp ID0gMDsKICAgQUxMX09CSlNFQ1RJT05TIChvYmpmaWxlLCBzKQotICAgIGlm IChpbnNlcnRfcCAob2JqZmlsZSwgcykpCisgICAgaWYgKGluc2VydF9zZWN0 aW9uX3AgKG9iamZpbGUtPm9iZmQsIHMtPnRoZV9iZmRfc2VjdGlvbikpCiAg ICAgICBtYXBbaSsrXSA9IHM7CiAKLSN1bmRlZiBpbnNlcnRfcAotCiAgIHFz b3J0IChtYXAsIG1hcF9zaXplLCBzaXplb2YgKCptYXApLCBxc29ydF9jbXAp OwogCiAgIC8qIFdpdGggc2VwYXJhdGUgZGVidWdpbmZvIGZpbGVzLCB3ZSBt YXkgaGF2ZSB1cCB0byB0d28gKGFsbW9zdCkK --000e0cd14cd4085cd0047198c2b7--