From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30871 invoked by alias); 14 Aug 2009 19:09:43 -0000 Received: (qmail 30800 invoked by uid 22791); 14 Aug 2009 19:09:43 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Aug 2009 19:09:36 +0000 Received: from zps18.corp.google.com (zps18.corp.google.com [172.25.146.18]) by smtp-out.google.com with ESMTP id n7EJ9VA0027470 for ; Fri, 14 Aug 2009 20:09:32 +0100 Received: from rv-out-0708.google.com (rvbf25.prod.google.com [10.140.82.25]) by zps18.corp.google.com with ESMTP id n7EJ9TIo011716 for ; Fri, 14 Aug 2009 12:09:29 -0700 Received: by rv-out-0708.google.com with SMTP id f25so537341rvb.2 for ; Fri, 14 Aug 2009 12:09:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.142.7 with SMTP id p7mr1112077rvd.80.1250276969232; Fri, 14 Aug 2009 12:09:29 -0700 (PDT) In-Reply-To: References: <8ac60eac0908140922m57367e9dn464783d8ff625474@mail.gmail.com> Date: Fri, 14 Aug 2009 19:15:00 -0000 Message-ID: <8ac60eac0908141209p7c457259h5ce40c7627e81ce5@mail.gmail.com> Subject: Re: [patch] Fix Darwin breakage From: Paul Pluzhnikov To: tromey@redhat.com Cc: gdb-patches ml , Christian Thalinger Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00202.txt.bz2 On Fri, Aug 14, 2009 at 11:30 AM, Tom Tromey wrote: > The idea seems reasonable enough to me, but I don't really understand > all the implications of it. If we need special treatment here, why not > in all the other places that use ALL_OBJSECTIONS and the like? Good question. I looked in gcore.c, and it looks like it should similarly skip OBJF_NOT_MAPPED objfiles. In main.c, I am not sure, but possibly. In printcmd.c, it's already skipping some (but not all!): ALL_OBJSECTIONS (objfile, osect) { /* Only process each object file once, even if there's a separate debug file. */ if (objfile->separate_debug_objfile_backlink) continue; In spu-tdep.c and symfile.c all uses have to do with overlays, and I *think* they should similarly skip. On Fri, Aug 14, 2009 at 11:32 AM, Tom Tromey wrote: > I think you probably would also need to do this in > symbol_file_add_with_addrs_or_offsets. Right, that's what '*' in 'symbol_file_add*' was supposed to convey. Perhaps I should have used regexp instead of shell glob :-) Thanks, -- Paul Pluzhnikov