From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1021 invoked by alias); 22 Jul 2009 20:32:48 -0000 Received: (qmail 1008 invoked by uid 22791); 22 Jul 2009 20:32:48 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Jul 2009 20:32:38 +0000 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id n6MKWamt001037 for ; Wed, 22 Jul 2009 13:32:36 -0700 Received: from qyk4 (qyk4.prod.google.com [10.241.83.132]) by zps76.corp.google.com with ESMTP id n6MKU8Sv002141 for ; Wed, 22 Jul 2009 13:32:34 -0700 Received: by qyk4 with SMTP id 4so604570qyk.18 for ; Wed, 22 Jul 2009 13:32:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.100.13 with SMTP id w13mr268704qcn.62.1248294754057; Wed, 22 Jul 2009 13:32:34 -0700 (PDT) In-Reply-To: References: <20090722001233.C049876BC0@localhost> Date: Wed, 22 Jul 2009 23:16:00 -0000 Message-ID: <8ac60eac0907221332n70b19febj539b5c866f7fd2f4@mail.gmail.com> Subject: Re: [RFC][patch] Work around for gold/10400 bug. From: Paul Pluzhnikov To: Andreas Schwab Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016363b85ca63fd8f046f514509 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00571.txt.bz2 --0016363b85ca63fd8f046f514509 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 330 On Wed, Jul 22, 2009 at 1:55 AM, Andreas Schwab wrote: >> + return (char *) a - (char *) b; > > This can overflow. Fixed in the updated patch. Thanks, -- Paul Pluzhnikov 009-07-21 Paul Pluzhnikov gold/10400 * dwarf2-frame.c (qsort_fde_cmp): Use stable sort. --0016363b85ca63fd8f046f514509 Content-Type: text/plain; charset=US-ASCII; name="gdb-gold-workaround-20090722.txt" Content-Disposition: attachment; filename="gdb-gold-workaround-20090722.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fxgifu6d0 Content-length: 1314 SW5kZXg6IHNyYy9nZGIvZHdhcmYyLWZyYW1lLmMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gc3JjLm9yaWcvZ2RiL2R3YXJmMi1mcmFtZS5jCTIwMDkt MDctMjIgMTM6MjY6MTcuMDAwMDAwMDAwIC0wNzAwCisrKyBzcmMvZ2RiL2R3 YXJmMi1mcmFtZS5jCTIwMDktMDctMjIgMTM6Mjk6NDYuMDAwMDAwMDAwIC0w NzAwCkBAIC0xOTU4LDkgKzE5NTgsMTggQEAKIHsKICAgc3RydWN0IGR3YXJm Ml9mZGUgKmFhID0gKihzdHJ1Y3QgZHdhcmYyX2ZkZSAqKilhOwogICBzdHJ1 Y3QgZHdhcmYyX2ZkZSAqYmIgPSAqKHN0cnVjdCBkd2FyZjJfZmRlICoqKWI7 CisKICAgaWYgKGFhLT5pbml0aWFsX2xvY2F0aW9uID09IGJiLT5pbml0aWFs X2xvY2F0aW9uKQotICAgIC8qIFB1dCBlaF9mcmFtZSBlbnRyaWVzIGFmdGVy IGRlYnVnX2ZyYW1lIG9uZXMuICAqLwotICAgIHJldHVybiBhYS0+ZWhfZnJh bWVfcCAtIGJiLT5laF9mcmFtZV9wOworICAgIHsKKyAgICAgIGlmIChhYS0+ YWRkcmVzc19yYW5nZSAhPSBiYi0+YWRkcmVzc19yYW5nZQorICAgICAgICAg ICYmIGFhLT5laF9mcmFtZV9wID09IDAgJiYgYmItPmVoX2ZyYW1lX3AgPT0g MCkKKyAgICAgICAgLyogTGlua2VyIGJ1ZywgZS5nLiBnb2xkLzEwNDAwLgor ICAgICAgICAgICBXb3JrIGFyb3VuZCBpdCBieSBrZWVwaW5nIHN0YWJsZSBz b3J0IG9yZGVyLiAgKi8KKyAgICAgICAgcmV0dXJuIChhIDwgYikgPyAtMSA6 IDE7CisgICAgICBlbHNlCisgICAgICAgIC8qIFB1dCBlaF9mcmFtZSBlbnRy aWVzIGFmdGVyIGRlYnVnX2ZyYW1lIG9uZXMuICAqLworICAgICAgICByZXR1 cm4gYWEtPmVoX2ZyYW1lX3AgLSBiYi0+ZWhfZnJhbWVfcDsKKyAgICB9CiAK ICAgcmV0dXJuIChhYS0+aW5pdGlhbF9sb2NhdGlvbiA8IGJiLT5pbml0aWFs X2xvY2F0aW9uKSA/IC0xIDogMTsKIH0K --0016363b85ca63fd8f046f514509--