From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31753 invoked by alias); 22 Jul 2009 15:49:53 -0000 Received: (qmail 31743 invoked by uid 22791); 22 Jul 2009 15:49:52 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Jul 2009 15:49:45 +0000 Received: from spaceape12.eur.corp.google.com (spaceape12.eur.corp.google.com [172.28.16.146]) by smtp-out.google.com with ESMTP id n6MFnfPn009881 for ; Wed, 22 Jul 2009 16:49:42 +0100 Received: from qw-out-1920.google.com (qwc5.prod.google.com [10.241.193.133]) by spaceape12.eur.corp.google.com with ESMTP id n6MFmsf2024285 for ; Wed, 22 Jul 2009 08:49:39 -0700 Received: by qw-out-1920.google.com with SMTP id 5so120187qwc.46 for ; Wed, 22 Jul 2009 08:49:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.100.14 with SMTP id w14mr209266qcn.48.1248277779287; Wed, 22 Jul 2009 08:49:39 -0700 (PDT) In-Reply-To: References: <8ac60eac0907161724v40e5bd8bg7877d8901b8d7b6e@mail.gmail.com> <8ac60eac0907211318j11706eb3u2339901a832e2360@mail.gmail.com> <200907221146.05270.pedro@codesourcery.com> Date: Wed, 22 Jul 2009 17:02:00 -0000 Message-ID: <8ac60eac0907220849w3add6806h96e3df1d3257ac54@mail.gmail.com> Subject: Re: [patch] Speed up find_pc_section From: Paul Pluzhnikov To: tromey@redhat.com Cc: Pedro Alves , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016363109bb9d8ef1046f4d5159 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00539.txt.bz2 --0016363109bb9d8ef1046f4d5159 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 625 On Wed, Jul 22, 2009 at 7:25 AM, Tom Tromey wrote: > Paul, could you please either fix this ASAP, or revert the change while > coming up with a fix? =A0Thanks. Here is the fix for both issues. Tested on Linux/x86_64, no regressions. I'll work up a test case for add-symbol-file in a separate patch. Not sure if I can make a test case for objfile_relocate though. Thanks, --=20 Paul Pluzhnikov 2009-07-22 Paul Pluzhnikov * objfiles.c (objfile_relocate): Must rebuild section map. (set_objfiles_updated_on_new_objfile): New observer. (_initialize_objfiles): Register it. --0016363109bb9d8ef1046f4d5159 Content-Type: text/plain; charset=US-ASCII; name="gdb-find_pc_section-20090722.txt" Content-Disposition: attachment; filename="gdb-find_pc_section-20090722.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fxg8butn0 Content-length: 1839 SW5kZXg6IG9iamZpbGVzLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9vYmpmaWxlcy5jLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjg2CmRpZmYgLXUgLXAgLXUgLXIxLjg2IG9iamZpbGVz LmMKLS0tIG9iamZpbGVzLmMJMjEgSnVsIDIwMDkgMjA6NTQ6MzAgLTAwMDAJ MS44NgorKysgb2JqZmlsZXMuYwkyMiBKdWwgMjAwOSAxNTo0Mzo0NyAtMDAw MApAQCAtNjgyLDYgKzY4Miw3IEBAIG9iamZpbGVfcmVsb2NhdGUgKHN0cnVj dCBvYmpmaWxlICpvYmpmaWwKIAogICAvKiBSZWxvY2F0ZSBicmVha3BvaW50 cyBhcyBuZWNlc3NhcnksIGFmdGVyIHRoaW5ncyBhcmUgcmVsb2NhdGVkLiAq LwogICBicmVha3BvaW50X3JlX3NldCAoKTsKKyAgb2JqZmlsZXNfdXBkYXRl ZF9wID0gMTsgIC8qIFJlYnVpbGQgc2VjdGlvbiBtYXAgbmV4dCB0aW1lIHdl IG5lZWQgaXQuICAqLwogfQogDAogLyogTWFueSBwbGFjZXMgaW4gZ2RiIHdh bnQgdG8gdGVzdCBqdXN0IHRvIHNlZSBpZiB3ZSBoYXZlIGFueSBwYXJ0aWFs CkBAIC0xMDA3LDEwICsxMDA4LDIwIEBAIHNldF9vYmpmaWxlc191cGRhdGVk X29uX3NvbGliX2FjdGl2aXR5ICgKICAgb2JqZmlsZXNfdXBkYXRlZF9wID0g MTsgIC8qIFJlYnVpbGQgc2VjdGlvbiBtYXAgbmV4dCB0aW1lIHdlIG5lZWQg aXQuICAqLwogfQogCisvKiBTZXQgb2JqZmlsZXNfdXBkYXRlZF9wIHNvIHNl Y3Rpb24gbWFwIHdpbGwgYmUgcmVidWlsdCBuZXh0IHRpbWUgaXQKKyAgIGlz IHVzZWQuICBDYWxsZWQgYnkgbmV3X29iamZpbGUgb2JzZXJ2ZXIuICAqLwor CitzdGF0aWMgdm9pZAorc2V0X29iamZpbGVzX3VwZGF0ZWRfb25fbmV3X29i amZpbGUgKHN0cnVjdCBvYmpmaWxlICpvYmpmaWxlKQoreworICBvYmpmaWxl c191cGRhdGVkX3AgPSAxOyAgLyogUmVidWlsZCBzZWN0aW9uIG1hcCBuZXh0 IHRpbWUgd2UgbmVlZCBpdC4gICovCit9CisKIHZvaWQKIF9pbml0aWFsaXpl X29iamZpbGVzICh2b2lkKQogewogICBvYnNlcnZlcl9hdHRhY2hfZXhlY3V0 YWJsZV9jaGFuZ2VkIChzZXRfb2JqZmlsZXNfdXBkYXRlZF9vbl9leGVfY2hh bmdlKTsKKyAgb2JzZXJ2ZXJfYXR0YWNoX25ld19vYmpmaWxlIChzZXRfb2Jq ZmlsZXNfdXBkYXRlZF9vbl9uZXdfb2JqZmlsZSk7CiAgIG9ic2VydmVyX2F0 dGFjaF9zb2xpYl9sb2FkZWQgKHNldF9vYmpmaWxlc191cGRhdGVkX29uX3Nv bGliX2FjdGl2aXR5KTsKICAgb2JzZXJ2ZXJfYXR0YWNoX3NvbGliX3VubG9h ZGVkIChzZXRfb2JqZmlsZXNfdXBkYXRlZF9vbl9zb2xpYl9hY3Rpdml0eSk7 CiB9Cg== --0016363109bb9d8ef1046f4d5159--