From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10094 invoked by alias); 23 Jun 2009 17:35:49 -0000 Received: (qmail 10086 invoked by uid 22791); 23 Jun 2009 17:35:48 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Jun 2009 17:35:42 +0000 Received: from spaceape11.eur.corp.google.com (spaceape11.eur.corp.google.com [172.28.16.145]) by smtp-out.google.com with ESMTP id n5NHZd6Z016109 for ; Tue, 23 Jun 2009 18:35:39 +0100 Received: from qyk4 (qyk4.prod.google.com [10.241.83.132]) by spaceape11.eur.corp.google.com with ESMTP id n5NHZaEm007455 for ; Tue, 23 Jun 2009 10:35:37 -0700 Received: by qyk4 with SMTP id 4so324955qyk.20 for ; Tue, 23 Jun 2009 10:35:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.95.4 with SMTP id b4mr91114qcn.40.1245778536302; Tue, 23 Jun 2009 10:35:36 -0700 (PDT) In-Reply-To: <20090623150322.GA7654@host0.dyn.jankratochvil.net> References: <20090527001157.934BD76BC0@localhost> <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> <8ac60eac0906101839t4d3978fyc1c6d3b3e2eccb6e@mail.gmail.com> <8ac60eac0906101842y2d2fc9fco331cb4336d9508d0@mail.gmail.com> <8ac60eac0906161342m67c30151lc7f685e0eb36e41f@mail.gmail.com> <8ac60eac0906161407s6498913cu5e50e930d599be77@mail.gmail.com> <20090623150322.GA7654@host0.dyn.jankratochvil.net> Date: Tue, 23 Jun 2009 17:35:00 -0000 Message-ID: <8ac60eac0906231035o389086e3g7d36060d52697f0c@mail.gmail.com> Subject: Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.] From: Paul Pluzhnikov To: Jan Kratochvil Cc: Tom Tromey , gdb-patches@sources.redhat.com Content-Type: multipart/mixed; boundary=0016364ef40a200855046d076b41 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00622.txt.bz2 --0016364ef40a200855046d076b41 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 410 On Tue, Jun 23, 2009 at 8:03 AM, Jan Kratochvil wrote: > while sure your patch is great it has a regression. =A0Assuming a regress= ion > reproducer needs to link GDB with -lmcheck (but did verify it). The problem also shows up under Valgrind (log attached). > This patch will fix back (tested on {x86_64,i686}-fedora-linux-gnu): Looks good to me. Thanks, --=20 Paul Pluzhnikov --0016364ef40a200855046d076b41 Content-Type: text/plain; charset=US-ASCII; name="gdb-valgrind.txt" Content-Disposition: attachment; filename="gdb-valgrind.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fwawcnpu0 Content-length: 4836 KGdkYikgc2hlbGwgdG91Y2ggL3Vzci9sb2NhbC9nb29nbGUvcHBsdXpobmlr b3YvQXJjaGl2ZS9zb3VyY2V3YXJlLm9yZy9nZGIvYnVpbGQvZ2RiL3Rlc3Rz dWl0ZS9nZGIuYmFzZS9yZXJlYWReTQooZ2RiKSBydW4gXk0KVGhlIHByb2dy YW0gYmVpbmcgZGVidWdnZWQgaGFzIGJlZW4gc3RhcnRlZCBhbHJlYWR5Ll5N ClN0YXJ0IGl0IGZyb20gdGhlIGJlZ2lubmluZz8gKHkgb3IgbikgeV5NCmAv dXNyL2xvY2FsL2dvb2dsZS9wcGx1emhuaWtvdi9BcmNoaXZlL3NvdXJjZXdh cmUub3JnL2dkYi9idWlsZC9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL3JlcmVh ZCcgaGFzIGNoYW5nZWQ7IHJlLXJlYWRpbmcgc3ltYm9scy5eTQo9PTg1Njk9 PSBJbnZhbGlkIHJlYWQgb2Ygc2l6ZSA0Xk0KPT04NTY5PT0gICAgYXQgMHg1 MkUyNjQ6IG11bm1hcF9zZWN0aW9uX2J1ZmZlciAvaG9tZS9wcGx1emhuaWtv di9BcmNoaXZlL3NvdXJjZXdhcmUub3JnL2dkYi9idWlsZC9nZGIvLi4vLi4v c3JjL2dkYi9kd2FyZjJyZWFkLmM6MTA5MzdeTQo9PTg1Njk9PSAgICBieSAw eDUyRTJEQjogZHdhcmYyX3Blcl9vYmpmaWxlX2NsZWFudXAgL2hvbWUvcHBs dXpobmlrb3YvQXJjaGl2ZS9zb3VyY2V3YXJlLm9yZy9nZGIvYnVpbGQvZ2Ri Ly4uLy4uL3NyYy9nZGIvZHdhcmYycmVhZC5jOjEwOTU3Xk0KPT04NTY5PT0g ICAgYnkgMHg0NDgyMDk6IGNsZWFyX29iamZpbGVfZGF0YSAvaG9tZS9wcGx1 emhuaWtvdi9BcmNoaXZlL3NvdXJjZXdhcmUub3JnL2dkYi9idWlsZC9nZGIv Li4vLi4vc3JjL2dkYi9vYmpmaWxlcy5jOjg3NV5NCj09ODU2OT09ICAgIGJ5 IDB4NEU0MTUyOiByZXJlYWRfc3ltYm9scyAvaG9tZS9wcGx1emhuaWtvdi9B cmNoaXZlL3NvdXJjZXdhcmUub3JnL2dkYi9idWlsZC9nZGIvLi4vLi4vc3Jj L2dkYi9zeW1maWxlLmM6MjM3NF5NCj09ODU2OT09ICAgIGJ5IDB4NEVGMzA1 OiBydW5fY29tbWFuZF8xIC9ob21lL3BwbHV6aG5pa292L0FyY2hpdmUvc291 cmNld2FyZS5vcmcvZ2RiL2J1aWxkL2dkYi8uLi8uLi9zcmMvZ2RiL2luZmNt ZC5jOjQ5MF5NCj09ODU2OT09ICAgIGJ5IDB4NDRENDMzOiBleGVjdXRlX2Nv bW1hbmQgL2hvbWUvcHBsdXpobmlrb3YvQXJjaGl2ZS9zb3VyY2V3YXJlLm9y Zy9nZGIvYnVpbGQvZ2RiLy4uLy4uL3NyYy9nZGIvdG9wLmM6NDQyXk0KPT04 NTY5PT0gICAgYnkgMHg1MDQyRjg6IGNvbW1hbmRfaGFuZGxlciAvaG9tZS9w cGx1emhuaWtvdi9BcmNoaXZlL3NvdXJjZXdhcmUub3JnL2dkYi9idWlsZC9n ZGIvLi4vLi4vc3JjL2dkYi9ldmVudC10b3AuYzo1MTFeTQo9PTg1Njk9PSAg ICBieSAweDUwNEU0QjogY29tbWFuZF9saW5lX2hhbmRsZXIgL2hvbWUvcHBs dXpobmlrb3YvQXJjaGl2ZS9zb3VyY2V3YXJlLm9yZy9nZGIvYnVpbGQvZ2Ri Ly4uLy4uL3NyYy9nZGIvZXZlbnQtdG9wLmM6NzM1Xk0KPT04NTY5PT0gICAg YnkgMHg1QjUzRDI6IHJsX2NhbGxiYWNrX3JlYWRfY2hhciAvdXNyL2xvY2Fs L2dvb2dsZS9wcGx1emhuaWtvdi9BcmNoaXZlL3NvdXJjZXdhcmUub3JnL2dk Yi9idWlsZC9yZWFkbGluZS8uLi8uLi9zcmMvcmVhZGxpbmUvY2FsbGJhY2su YzoyMDVeTQo9PTg1Njk9PSAgICBieSAweDUwNDQyODogcmxfY2FsbGJhY2tf cmVhZF9jaGFyX3dyYXBwZXIgL2hvbWUvcHBsdXpobmlrb3YvQXJjaGl2ZS9z b3VyY2V3YXJlLm9yZy9nZGIvYnVpbGQvZ2RiLy4uLy4uL3NyYy9nZGIvZXZl bnQtdG9wLmM6MTc4Xk0KPT04NTY5PT0gICAgYnkgMHg1MDJGMjA6IHByb2Nl c3NfZXZlbnQgL2hvbWUvcHBsdXpobmlrb3YvQXJjaGl2ZS9zb3VyY2V3YXJl Lm9yZy9nZGIvYnVpbGQvZ2RiLy4uLy4uL3NyYy9nZGIvZXZlbnQtbG9vcC5j OjM5NF5NCj09ODU2OT09ICAgIGJ5IDB4NTAzRDk3OiBnZGJfZG9fb25lX2V2 ZW50IC9ob21lL3BwbHV6aG5pa292L0FyY2hpdmUvc291cmNld2FyZS5vcmcv Z2RiL2J1aWxkL2dkYi8uLi8uLi9zcmMvZ2RiL2V2ZW50LWxvb3AuYzo0NDde TQo9PTg1Njk9PSAgQWRkcmVzcyAweDViNzhhYTAgaXMgMyw0ODAgYnl0ZXMg aW5zaWRlIGEgYmxvY2sgb2Ygc2l6ZSA0LDA3MiBmcmVlJ2ReTQo9PTg1Njk9 PSAgICBhdCAweDRDMURFMEY6IGZyZWUgL3RtcC92Zy9jb3JlZ3JpbmQvbV9y ZXBsYWNlbWFsbG9jL3ZnX3JlcGxhY2VfbWFsbG9jLmM6MzIyXk0KPT04NTY5 PT0gICAgYnkgMHg1NzZEMEU3OiBvYnN0YWNrX2ZyZWUgL3Vzci9ncnRlL3Yx L2RlYnVnLXNyYy9zcmMvZ2xpYmMtMi4zLjYvbWFsbG9jL29ic3RhY2suYzoz NDdeTQo9PTg1Njk9PSAgICBieSAweDRFNDBDRDogcmVyZWFkX3N5bWJvbHMg L2hvbWUvcHBsdXpobmlrb3YvQXJjaGl2ZS9zb3VyY2V3YXJlLm9yZy9nZGIv YnVpbGQvZ2RiLy4uLy4uL3NyYy9nZGIvc3ltZmlsZS5jOjIzNjBeTQo9PTg1 Njk9PSAgICBieSAweDRFRjMwNTogcnVuX2NvbW1hbmRfMSAvaG9tZS9wcGx1 emhuaWtvdi9BcmNoaXZlL3NvdXJjZXdhcmUub3JnL2dkYi9idWlsZC9nZGIv Li4vLi4vc3JjL2dkYi9pbmZjbWQuYzo0OTBeTQo9PTg1Njk9PSAgICBieSAw eDQ0RDQzMzogZXhlY3V0ZV9jb21tYW5kIC9ob21lL3BwbHV6aG5pa292L0Fy Y2hpdmUvc291cmNld2FyZS5vcmcvZ2RiL2J1aWxkL2dkYi8uLi8uLi9zcmMv Z2RiL3RvcC5jOjQ0Ml5NCj09ODU2OT09ICAgIGJ5IDB4NTA0MkY4OiBjb21t YW5kX2hhbmRsZXIgL2hvbWUvcHBsdXpobmlrb3YvQXJjaGl2ZS9zb3VyY2V3 YXJlLm9yZy9nZGIvYnVpbGQvZ2RiLy4uLy4uL3NyYy9nZGIvZXZlbnQtdG9w LmM6NTExXk0KPT04NTY5PT0gICAgYnkgMHg1MDRFNEI6IGNvbW1hbmRfbGlu ZV9oYW5kbGVyIC9ob21lL3BwbHV6aG5pa292L0FyY2hpdmUvc291cmNld2Fy ZS5vcmcvZ2RiL2J1aWxkL2dkYi8uLi8uLi9zcmMvZ2RiL2V2ZW50LXRvcC5j OjczNV5NCj09ODU2OT09ICAgIGJ5IDB4NUI1M0QyOiBybF9jYWxsYmFja19y ZWFkX2NoYXIgL3Vzci9sb2NhbC9nb29nbGUvcHBsdXpobmlrb3YvQXJjaGl2 ZS9zb3VyY2V3YXJlLm9yZy9nZGIvYnVpbGQvcmVhZGxpbmUvLi4vLi4vc3Jj L3JlYWRsaW5lL2NhbGxiYWNrLmM6MjA1Xk0KPT04NTY5PT0gICAgYnkgMHg1 MDQ0Mjg6IHJsX2NhbGxiYWNrX3JlYWRfY2hhcl93cmFwcGVyIC9ob21lL3Bw bHV6aG5pa292L0FyY2hpdmUvc291cmNld2FyZS5vcmcvZ2RiL2J1aWxkL2dk Yi8uLi8uLi9zcmMvZ2RiL2V2ZW50LXRvcC5jOjE3OF5NCj09ODU2OT09ICAg IGJ5IDB4NTAyRjIwOiBwcm9jZXNzX2V2ZW50IC9ob21lL3BwbHV6aG5pa292 L0FyY2hpdmUvc291cmNld2FyZS5vcmcvZ2RiL2J1aWxkL2dkYi8uLi8uLi9z cmMvZ2RiL2V2ZW50LWxvb3AuYzozOTReTQo9PTg1Njk9PSAgICBieSAweDUw M0Q5NzogZ2RiX2RvX29uZV9ldmVudCAvaG9tZS9wcGx1emhuaWtvdi9BcmNo aXZlL3NvdXJjZXdhcmUub3JnL2dkYi9idWlsZC9nZGIvLi4vLi4vc3JjL2dk Yi9ldmVudC1sb29wLmM6NDQ3Xk0KPT04NTY5PT0gICAgYnkgMHg0RkU2QUE6 IGNhdGNoX2Vycm9ycyAvaG9tZS9wcGx1emhuaWtvdi9BcmNoaXZlL3NvdXJj ZXdhcmUub3JnL2dkYi9idWlsZC9nZGIvLi4vLi4vc3JjL2dkYi9leGNlcHRp b25zLmM6NTEwXk0K --0016364ef40a200855046d076b41--