From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27310 invoked by alias); 22 Jun 2009 22:04:51 -0000 Received: (qmail 27302 invoked by uid 22791); 22 Jun 2009 22:04:50 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Jun 2009 22:04:43 +0000 Received: from spaceape11.eur.corp.google.com (spaceape11.eur.corp.google.com [172.28.16.145]) by smtp-out.google.com with ESMTP id n5MM4eI1003079 for ; Mon, 22 Jun 2009 15:04:40 -0700 Received: from qyk27 (qyk27.prod.google.com [10.241.83.155]) by spaceape11.eur.corp.google.com with ESMTP id n5MM4OL4013043 for ; Mon, 22 Jun 2009 15:04:38 -0700 Received: by qyk27 with SMTP id 27so5445447qyk.2 for ; Mon, 22 Jun 2009 15:04:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.80.78 with SMTP id s14mr1180945qck.101.1245708275835; Mon, 22 Jun 2009 15:04:35 -0700 (PDT) In-Reply-To: <200906222006.n5MK6MAP015693@d12av02.megacenter.de.ibm.com> References: <8ac60eac0906221242o56529b23s600d18e0cb69eb45@mail.gmail.com> <200906222006.n5MK6MAP015693@d12av02.megacenter.de.ibm.com> Date: Mon, 22 Jun 2009 22:04:00 -0000 Message-ID: <8ac60eac0906221504l17329986yb36a5a1cae2412b@mail.gmail.com> Subject: Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs. From: Paul Pluzhnikov To: Ulrich Weigand Cc: Joel Brobecker , tromey@redhat.com, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001636426d4d4664c3046cf70f85 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00593.txt.bz2 --001636426d4d4664c3046cf70f85 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 845 On Mon, Jun 22, 2009 at 1:06 PM, Ulrich Weigand wrote: >> Perhaps a better alternative is to restore the overlay-bp-reset behavior to >> "before 2009-05-12" commit: now that this change is in: Here is the patch to do that. Tested on Linux/x86_64. I also verified that create_overlay_event_breakpoint is not called for each solib (though it is called 7 times, which seems like 6 too many). Thanks, -- Paul Pluzhnikov 2009-06-22 Paul Pluzhnikov Revert 2009-05-14 breakpoint commit (no longer needed). * breakpoint.h (breakpoint_re_set_objfile): Remove * breakpoint.c (breakpoint_re_set_objfile): Likewise (create_overlay_event_breakpoint_1): Resurrect. (create_overlay_event_breakpoint): Likewise. * objfiles.c (objfile_relocate): Update. * symfile.c (new_symfile_objfile): Likewise. --001636426d4d4664c3046cf70f85 Content-Type: text/plain; charset=US-ASCII; name="gdb-overlay-bp-20090622-2.txt" Content-Disposition: attachment; filename="gdb-overlay-bp-20090622-2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fw9qhjc10 Content-length: 5808 SW5kZXg6IGJyZWFrcG9pbnQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2JyZWFrcG9pbnQuYyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS40MDcKZGlmZiAtdSAtcCAtdSAtcjEuNDA3IGJy ZWFrcG9pbnQuYwotLS0gYnJlYWtwb2ludC5jCTE5IEp1biAyMDA5IDE1OjE0 OjExIC0wMDAwCTEuNDA3CisrKyBicmVha3BvaW50LmMJMjIgSnVuIDIwMDkg MjE6Mzg6MTQgLTAwMDAKQEAgLTE0NzYsNyArMTQ3Niw3IEBAIGNyZWF0ZV9p bnRlcm5hbF9icmVha3BvaW50IChDT1JFX0FERFIgYWQKIH0KIAogc3RhdGlj IHZvaWQKLWNyZWF0ZV9vdmVybGF5X2V2ZW50X2JyZWFrcG9pbnQgKGNoYXIg KmZ1bmNfbmFtZSwgc3RydWN0IG9iamZpbGUgKm9iamZpbGUpCitjcmVhdGVf b3ZlcmxheV9ldmVudF9icmVha3BvaW50XzEgKGNoYXIgKmZ1bmNfbmFtZSwg c3RydWN0IG9iamZpbGUgKm9iamZpbGUpCiB7CiAgIHN0cnVjdCBicmVha3Bv aW50ICpiOwogICBzdHJ1Y3QgbWluaW1hbF9zeW1ib2wgKm07CkBAIC0xNTAy LDEzICsxNTAyLDIwIEBAIGNyZWF0ZV9vdmVybGF5X2V2ZW50X2JyZWFrcG9p bnQgKGNoYXIgKmYKICAgdXBkYXRlX2dsb2JhbF9sb2NhdGlvbl9saXN0ICgx KTsKIH0KIAorc3RhdGljIHZvaWQKK2NyZWF0ZV9vdmVybGF5X2V2ZW50X2Jy ZWFrcG9pbnQgKGNoYXIgKmZ1bmNfbmFtZSkKK3sKKyAgc3RydWN0IG9iamZp bGUgKm9iamZpbGU7CisgIEFMTF9PQkpGSUxFUyAob2JqZmlsZSkKKyAgICBj cmVhdGVfb3ZlcmxheV9ldmVudF9icmVha3BvaW50XzEgKGZ1bmNfbmFtZSwg b2JqZmlsZSk7Cit9CisKIHZvaWQKIHVwZGF0ZV9icmVha3BvaW50c19hZnRl cl9leGVjICh2b2lkKQogewogICBzdHJ1Y3QgYnJlYWtwb2ludCAqYjsKICAg c3RydWN0IGJyZWFrcG9pbnQgKnRlbXA7CiAgIHN0cnVjdCBicF9sb2NhdGlv biAqYnBsb2M7Ci0gIHN0cnVjdCBvYmpmaWxlICpvYmpmaWxlOwogCiAgIC8q IFdlJ3JlIGFib3V0IHRvIGRlbGV0ZSBicmVha3BvaW50cyBmcm9tIEdEQidz IGxpc3RzLiAgSWYgdGhlCiAgICAgIElOU0VSVEVEIGZsYWcgaXMgdHJ1ZSwg R0RCIHdpbGwgdHJ5IHRvIGxpZnQgdGhlIGJyZWFrcG9pbnRzIGJ5CkBAIC0x NjAzLDggKzE2MTAsNyBAQCB1cGRhdGVfYnJlYWtwb2ludHNfYWZ0ZXJfZXhl YyAodm9pZCkKICAgICAgIH0KICAgfQogICAvKiBGSVhNRSB3aGF0IGFib3V0 IGxvbmdqbXAgYnJlYWtwb2ludHM/ICBSZS1jcmVhdGUgdGhlbSBoZXJlPyAg Ki8KLSAgQUxMX09CSkZJTEVTIChvYmpmaWxlKQotICAgIGNyZWF0ZV9vdmVy bGF5X2V2ZW50X2JyZWFrcG9pbnQgKCJfb3ZseV9kZWJ1Z19ldmVudCIsIG9i amZpbGUpOworICBjcmVhdGVfb3ZlcmxheV9ldmVudF9icmVha3BvaW50ICgi X292bHlfZGVidWdfZXZlbnQiKTsKIH0KIAogaW50CkBAIC03NzcxLDEzICs3 Nzc3LDkgQEAgYnJlYWtwb2ludF9yZV9zZXRfb25lICh2b2lkICpiaW50KQog ICByZXR1cm4gMDsKIH0KIAotLyogUmUtc2V0IGFsbCBicmVha3BvaW50cyBh ZnRlciBzeW1ib2xzIGhhdmUgYmVlbiByZS1sb2FkZWQuCi0KLSAgIElmIE9C SkZJTEUgaXMgbm9uLW51bGwsIGNyZWF0ZSBvdmVybGF5IGJyZWFrIHBvaW50 IG9ubHkgaW4gT0JKRklMRQotICAgKHNwZWVkIG9wdGltaXphdGlvbikuICBP dGhlcndpc2UgcmVzY2FuIGFsbCBsb2FkZWQgb2JqZmlsZXMuICAqLwotCisv KiBSZS1zZXQgYWxsIGJyZWFrcG9pbnRzIGFmdGVyIHN5bWJvbHMgaGF2ZSBi ZWVuIHJlLWxvYWRlZC4gICovCiB2b2lkCi1icmVha3BvaW50X3JlX3NldF9v YmpmaWxlIChzdHJ1Y3Qgb2JqZmlsZSAqb2JqZmlsZSkKK2JyZWFrcG9pbnRf cmVfc2V0ICh2b2lkKQogewogICBzdHJ1Y3QgYnJlYWtwb2ludCAqYiwgKnRl bXA7CiAgIGVudW0gbGFuZ3VhZ2Ugc2F2ZV9sYW5ndWFnZTsKQEAgLTc3OTcs MTkgKzc3OTksNyBAQCBicmVha3BvaW50X3JlX3NldF9vYmpmaWxlIChzdHJ1 Y3Qgb2JqZmlsCiAgIHNldF9sYW5ndWFnZSAoc2F2ZV9sYW5ndWFnZSk7CiAg IGlucHV0X3JhZGl4ID0gc2F2ZV9pbnB1dF9yYWRpeDsKIAotICBpZiAob2Jq ZmlsZSA9PSBOVUxMKQotICAgIEFMTF9PQkpGSUxFUyAob2JqZmlsZSkKLSAg ICAgIGNyZWF0ZV9vdmVybGF5X2V2ZW50X2JyZWFrcG9pbnQgKCJfb3ZseV9k ZWJ1Z19ldmVudCIsIG9iamZpbGUpOwotICBlbHNlCi0gICAgY3JlYXRlX292 ZXJsYXlfZXZlbnRfYnJlYWtwb2ludCAoIl9vdmx5X2RlYnVnX2V2ZW50Iiwg b2JqZmlsZSk7Ci19Ci0KLS8qIFJlLXNldCBhbGwgYnJlYWtwb2ludHMgYWZ0 ZXIgc3ltYm9scyBoYXZlIGJlZW4gcmUtbG9hZGVkLiAgKi8KLQotdm9pZAot YnJlYWtwb2ludF9yZV9zZXQgKHZvaWQpCi17Ci0gIGJyZWFrcG9pbnRfcmVf c2V0X29iamZpbGUgKE5VTEwpOworICBjcmVhdGVfb3ZlcmxheV9ldmVudF9i cmVha3BvaW50ICgiX292bHlfZGVidWdfZXZlbnQiKTsKIH0KIAwKIC8qIFJl c2V0IHRoZSB0aHJlYWQgbnVtYmVyIG9mIHRoaXMgYnJlYWtwb2ludDoKSW5k ZXg6IGJyZWFrcG9pbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2JyZWFrcG9pbnQuaCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS45MgpkaWZmIC11IC1wIC11IC1yMS45MiBicmVha3Bv aW50LmgKLS0tIGJyZWFrcG9pbnQuaAkyNCBNYXkgMjAwOSAxODowMDowOCAt MDAwMAkxLjkyCisrKyBicmVha3BvaW50LmgJMjIgSnVuIDIwMDkgMjE6Mzg6 MTQgLTAwMDAKQEAgLTY4Nyw3ICs2ODcsNyBAQCBleHRlcm4gaW50IGJyZWFr cG9pbnRfdGhyZWFkX21hdGNoIChDT1JFCiBleHRlcm4gdm9pZCB1bnRpbF9i cmVha19jb21tYW5kIChjaGFyICosIGludCwgaW50KTsKIAogZXh0ZXJuIHZv aWQgYnJlYWtwb2ludF9yZV9zZXQgKHZvaWQpOwotZXh0ZXJuIHZvaWQgYnJl YWtwb2ludF9yZV9zZXRfb2JqZmlsZSAoc3RydWN0IG9iamZpbGUgKik7CisK IGV4dGVybiB2b2lkIGJyZWFrcG9pbnRfcmVfc2V0X3RocmVhZCAoc3RydWN0 IGJyZWFrcG9pbnQgKik7CiAKIGV4dGVybiBzdHJ1Y3QgYnJlYWtwb2ludCAq c2V0X21vbWVudGFyeV9icmVha3BvaW50CkluZGV4OiBvYmpmaWxlcy5jCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9n ZGIvb2JqZmlsZXMuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44MwpkaWZm IC11IC1wIC11IC1yMS44MyBvYmpmaWxlcy5jCi0tLSBvYmpmaWxlcy5jCTE0 IE1heSAyMDA5IDIzOjMzOjA4IC0wMDAwCTEuODMKKysrIG9iamZpbGVzLmMJ MjIgSnVuIDIwMDkgMjE6Mzg6MTQgLTAwMDAKQEAgLTY3NCw3ICs2NzQsNyBA QCBvYmpmaWxlX3JlbG9jYXRlIChzdHJ1Y3Qgb2JqZmlsZSAqb2JqZmlsCiAg ICAgfQogCiAgIC8qIFJlbG9jYXRlIGJyZWFrcG9pbnRzIGFzIG5lY2Vzc2Fy eSwgYWZ0ZXIgdGhpbmdzIGFyZSByZWxvY2F0ZWQuICovCi0gIGJyZWFrcG9p bnRfcmVfc2V0X29iamZpbGUgKG9iamZpbGUpOworICBicmVha3BvaW50X3Jl X3NldCAoKTsKIH0KIAwKIC8qIE1hbnkgcGxhY2VzIGluIGdkYiB3YW50IHRv IHRlc3QganVzdCB0byBzZWUgaWYgd2UgaGF2ZSBhbnkgcGFydGlhbApJbmRl eDogc3ltZmlsZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvc3JjL3NyYy9nZGIvc3ltZmlsZS5jLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjIzMgpkaWZmIC11IC1wIC11IC1yMS4yMzIgc3ltZmlsZS5jCi0t LSBzeW1maWxlLmMJMTcgSnVuIDIwMDkgMTg6MzQ6MzQgLTAwMDAJMS4yMzIK KysrIHN5bWZpbGUuYwkyMiBKdW4gMjAwOSAyMTozODoxNSAtMDAwMApAQCAt OTE5LDcgKzkxOSw3IEBAIG5ld19zeW1maWxlX29iamZpbGUgKHN0cnVjdCBv YmpmaWxlICpvYmoKICAgICB9CiAgIGVsc2UgaWYgKChhZGRfZmxhZ3MgJiBT WU1GSUxFX0RFRkVSX0JQX1JFU0VUKSA9PSAwKQogICAgIHsKLSAgICAgIGJy ZWFrcG9pbnRfcmVfc2V0X29iamZpbGUgKG9iamZpbGUpOworICAgICAgYnJl YWtwb2ludF9yZV9zZXQgKCk7CiAgICAgfQogCiAgIC8qIFdlJ3JlIGRvbmUg cmVhZGluZyB0aGUgc3ltYm9sIGZpbGU7IGZpbmlzaCBvZmYgY29tcGxhaW50 cy4gICovCg== --001636426d4d4664c3046cf70f85--