From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18279 invoked by alias); 22 Jun 2009 18:56:41 -0000 Received: (qmail 18270 invoked by uid 22791); 22 Jun 2009 18:56:40 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Jun 2009 18:56:34 +0000 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id n5MIuVN1021567 for ; Mon, 22 Jun 2009 11:56:31 -0700 Received: from qyk26 (qyk26.prod.google.com [10.241.83.154]) by wpaz37.hot.corp.google.com with ESMTP id n5MIrp6u018001 for ; Mon, 22 Jun 2009 11:56:29 -0700 Received: by qyk26 with SMTP id 26so4168232qyk.1 for ; Mon, 22 Jun 2009 11:56:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.96.9 with SMTP id f9mr1254697qcn.78.1245696988727; Mon, 22 Jun 2009 11:56:28 -0700 (PDT) In-Reply-To: <200906221709.n5MH9xPY029467@d12av02.megacenter.de.ibm.com> References: <8ac60eac0905121420t3954685v4b5328d05e072f92@mail.gmail.com> <200906221709.n5MH9xPY029467@d12av02.megacenter.de.ibm.com> Date: Mon, 22 Jun 2009 18:56:00 -0000 Message-ID: <8ac60eac0906221156o91c8059t17d1dd1bd2752dd0@mail.gmail.com> Subject: Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs. From: Paul Pluzhnikov To: Ulrich Weigand Cc: Joel Brobecker , tromey@redhat.com, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=00163642719e82d144046cf46e90 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00575.txt.bz2 --00163642719e82d144046cf46e90 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 914 On Mon, Jun 22, 2009 at 10:09 AM, Ulrich Weigand wrote: > Paul Pluzhnikov wrote: > >> 2009-05-12 Paul Pluzhnikov ... > Maybe I'm missing something here, but this seems to break overlay > support. Yes, I believe your analysis is correct. > If you're going to reset only breakpoints > from one objfile, maybe you should likewise *delete* only breakpoints > from that objfile? That sounds like a good approach :-) Patch below tested on Linux/x86_64 with no new failures. Unfortunately I don't have any targets that support overlays, so I can't test this. Did this fail for you on spu? If so, does it pass with this patch? Thanks, -- Paul Pluzhnikov 2009-06-22 Paul Pluzhnikov * breakpoint.c (breakpoint_re_set_one): Add objfile parameter, delete overlay breakpoint only in the given objfile. (breakpoint_re_set_objfile): Adjust. --00163642719e82d144046cf46e90 Content-Type: text/plain; charset=US-ASCII; name="gdb-overlay-bp-20090622.txt" Content-Disposition: attachment; filename="gdb-overlay-bp-20090622.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fw9jrdjq0 Content-length: 4376 SW5kZXg6IGJyZWFrcG9pbnQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2JyZWFrcG9pbnQuYyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS40MDcKZGlmZiAtdSAtcCAtdSAtcjEuNDA3IGJy ZWFrcG9pbnQuYwotLS0gYnJlYWtwb2ludC5jCTE5IEp1biAyMDA5IDE1OjE0 OjExIC0wMDAwCTEuNDA3CisrKyBicmVha3BvaW50LmMJMjIgSnVuIDIwMDkg MTg6NDE6NDMgLTAwMDAKQEAgLTkwLDggKzkwLDYgQEAgc3RhdGljIHZvaWQg bWFwX2JyZWFrcG9pbnRfbnVtYmVycyAoY2hhcgogCiBzdGF0aWMgdm9pZCBp Z25vcmVfY29tbWFuZCAoY2hhciAqLCBpbnQpOwogCi1zdGF0aWMgaW50IGJy ZWFrcG9pbnRfcmVfc2V0X29uZSAodm9pZCAqKTsKLQogc3RhdGljIHZvaWQg Y2xlYXJfY29tbWFuZCAoY2hhciAqLCBpbnQpOwogCiBzdGF0aWMgdm9pZCBj YXRjaF9jb21tYW5kIChjaGFyICosIGludCk7CkBAIC03NjA3LDExICs3NjA1 LDkgQEAgdXBkYXRlX2JyZWFrcG9pbnRfbG9jYXRpb25zIChzdHJ1Y3QgYnJl YQogICAgVGhlIHZhbHVlIHdlIHJldHVybiBlbmRzIHVwIGJlaW5nIHRoZSBy ZXR1cm4gdmFsdWUgZnJvbSBjYXRjaF9lcnJvcnMuCiAgICBVbnVzZWQgaW4g dGhpcyBjYXNlLiAgKi8KIAotc3RhdGljIGludAotYnJlYWtwb2ludF9yZV9z ZXRfb25lICh2b2lkICpiaW50KQorc3RhdGljIHZvaWQKK2JyZWFrcG9pbnRf cmVfc2V0X29uZSAoc3RydWN0IGJyZWFrcG9pbnQgKmIsIHN0cnVjdCBvYmpm aWxlICpvYmpmaWxlKQogewotICAvKiBnZXQgcGFzdCBjYXRjaF9lcnJzICov Ci0gIHN0cnVjdCBicmVha3BvaW50ICpiID0gKHN0cnVjdCBicmVha3BvaW50 ICopIGJpbnQ7CiAgIHN0cnVjdCB2YWx1ZSAqbWFyazsKICAgaW50IGk7CiAg IGludCBub3RfZm91bmQgPSAwOwpAQCAtNzYyOCw3ICs3NjI0LDcgQEAgYnJl YWtwb2ludF9yZV9zZXRfb25lICh2b2lkICpiaW50KQogICAgIGNhc2UgYnBf bm9uZToKICAgICAgIHdhcm5pbmcgKF8oImF0dGVtcHRlZCB0byByZXNldCBh cHBhcmVudGx5IGRlbGV0ZWQgYnJlYWtwb2ludCAjJWQ/IiksCiAJICAgICAg IGItPm51bWJlcik7Ci0gICAgICByZXR1cm4gMDsKKyAgICAgIHJldHVybjsK ICAgICBjYXNlIGJwX2JyZWFrcG9pbnQ6CiAgICAgY2FzZSBicF9oYXJkd2Fy ZV9icmVha3BvaW50OgogICAgIGNhc2UgYnBfdHJhY2Vwb2ludDoKQEAgLTc2 MzYsNyArNzYzMiw3IEBAIGJyZWFrcG9pbnRfcmVfc2V0X29uZSAodm9pZCAq YmludCkKIAl7CiAJICAvKiBBbnl0aGluZyB3aXRob3V0IGEgc3RyaW5nIGNh bid0IGJlIHJlLXNldC4gKi8KIAkgIGRlbGV0ZV9icmVha3BvaW50IChiKTsK LQkgIHJldHVybiAwOworCSAgcmV0dXJuOwogCX0KIAogICAgICAgc2V0X2xh bmd1YWdlIChiLT5sYW5ndWFnZSk7CkBAIC03NzM5LDEyICs3NzM1LDE3IEBA IGJyZWFrcG9pbnRfcmVfc2V0X29uZSAodm9pZCAqYmludCkKIAogICAgIGRl ZmF1bHQ6CiAgICAgICBwcmludGZfZmlsdGVyZWQgKF8oIkRlbGV0aW5nIHVu a25vd24gYnJlYWtwb2ludCB0eXBlICVkXG4iKSwgYi0+dHlwZSk7Ci0gICAg ICAvKiBmYWxsIHRocm91Z2ggKi8KLSAgICAgIC8qIERlbGV0ZSBvdmVybGF5 IGV2ZW50IGJyZWFrcG9pbnRzOyB0aGV5IHdpbGwgYmUgcmVzZXQgbGF0ZXIg YnkKLSAgICAgICAgIGJyZWFrcG9pbnRfcmVfc2V0LiAgKi8KLSAgICBjYXNl IGJwX292ZXJsYXlfZXZlbnQ6CiAgICAgICBkZWxldGVfYnJlYWtwb2ludCAo Yik7CiAgICAgICBicmVhazsKKyAgICBjYXNlIGJwX292ZXJsYXlfZXZlbnQ6 CisgICAgICBpZiAob2JqZmlsZSA9PSBOVUxMCisgICAgICAgICAgfHwgbG9v a3VwX21pbmltYWxfc3ltYm9sX3RleHQgKGItPmFkZHJfc3RyaW5nLCBvYmpm aWxlKSkKKyAgICAgICAgeworICAgICAgICAgIC8qIERlbGV0ZSBvdmVybGF5 IGV2ZW50IGJyZWFrcG9pbnRzOyB0aGV5IHdpbGwgYmUgcmVzZXQgbGF0ZXIg YnkKKyAgICAgICAgICAgICBicmVha3BvaW50X3JlX3NldC4gICovCisgICAg ICAgICAgZGVsZXRlX2JyZWFrcG9pbnQgKGIpOworICAgICAgICB9CisgICAg ICBicmVhazsKIAogICAgICAgLyogVGhpcyBicmVha3BvaW50IGlzIHNwZWNp YWwsIGl0J3Mgc2V0IHVwIHdoZW4gdGhlIGluZmVyaW9yCiAgICAgICAgICBz dGFydHMgYW5kIHdlIHJlYWxseSBkb24ndCB3YW50IHRvIHRvdWNoIGl0LiAg Ki8KQEAgLTc3NjcsOCArNzc2OCw2IEBAIGJyZWFrcG9pbnRfcmVfc2V0X29u ZSAodm9pZCAqYmludCkKICAgICBjYXNlIGJwX2xvbmdqbXBfcmVzdW1lOgog ICAgICAgYnJlYWs7CiAgICAgfQotCi0gIHJldHVybiAwOwogfQogCiAvKiBS ZS1zZXQgYWxsIGJyZWFrcG9pbnRzIGFmdGVyIHN5bWJvbHMgaGF2ZSBiZWVu IHJlLWxvYWRlZC4KQEAgLTc3ODcsMTIgKzc3ODYsMTUgQEAgYnJlYWtwb2lu dF9yZV9zZXRfb2JqZmlsZSAoc3RydWN0IG9iamZpbAogICBzYXZlX2lucHV0 X3JhZGl4ID0gaW5wdXRfcmFkaXg7CiAgIEFMTF9CUkVBS1BPSU5UU19TQUZF IChiLCB0ZW1wKQogICB7Ci0gICAgLyogRm9ybWF0IHBvc3NpYmxlIGVycm9y IG1zZyAqLwotICAgIGNoYXIgKm1lc3NhZ2UgPSB4c3RycHJpbnRmICgiRXJy b3IgaW4gcmUtc2V0dGluZyBicmVha3BvaW50ICVkOiAiLAotCQkJCWItPm51 bWJlcik7Ci0gICAgc3RydWN0IGNsZWFudXAgKmNsZWFudXBzID0gbWFrZV9j bGVhbnVwICh4ZnJlZSwgbWVzc2FnZSk7Ci0gICAgY2F0Y2hfZXJyb3JzIChi cmVha3BvaW50X3JlX3NldF9vbmUsIGIsIG1lc3NhZ2UsIFJFVFVSTl9NQVNL X0FMTCk7Ci0gICAgZG9fY2xlYW51cHMgKGNsZWFudXBzKTsKKyAgICB2b2xh dGlsZSBzdHJ1Y3QgZ2RiX2V4Y2VwdGlvbiBleDsKKworICAgIFRSWV9DQVRD SCAoZXgsIFJFVFVSTl9NQVNLX0FMTCkKKyAgICAgIHsKKyAgICAgICAgYnJl YWtwb2ludF9yZV9zZXRfb25lIChiLCBvYmpmaWxlKTsKKyAgICAgIH0KKyAg ICBpZiAoZXgucmVhc29uIDwgMCkKKyAgICAgIGV4Y2VwdGlvbl9mcHJpbnRm IChnZGJfc3RkZXJyLCBleCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAi RXJyb3IgaW4gcmUtc2V0dGluZyBicmVha3BvaW50ICVkOiAiLCBiLT5udW1i ZXIpOwogICB9CiAgIHNldF9sYW5ndWFnZSAoc2F2ZV9sYW5ndWFnZSk7CiAg IGlucHV0X3JhZGl4ID0gc2F2ZV9pbnB1dF9yYWRpeDsK --00163642719e82d144046cf46e90--