From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1461 invoked by alias); 11 Jun 2009 01:40:05 -0000 Received: (qmail 1450 invoked by uid 22791); 11 Jun 2009 01:40:04 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Jun 2009 01:39:57 +0000 Received: from spaceape24.eur.corp.google.com (spaceape24.eur.corp.google.com [172.28.16.76]) by smtp-out.google.com with ESMTP id n5B1dsxl027761 for ; Thu, 11 Jun 2009 02:39:54 +0100 Received: from qw-out-1920.google.com (qwa14.prod.google.com [10.241.193.14]) by spaceape24.eur.corp.google.com with ESMTP id n5B1dqwg022121 for ; Wed, 10 Jun 2009 18:39:52 -0700 Received: by qw-out-1920.google.com with SMTP id 14so723644qwa.36 for ; Wed, 10 Jun 2009 18:39:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.110.6 with SMTP id l6mr441632qcp.52.1244684392108; Wed, 10 Jun 2009 18:39:52 -0700 (PDT) In-Reply-To: References: <20090527001157.934BD76BC0@localhost> <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> Date: Thu, 11 Jun 2009 01:40:00 -0000 Message-ID: <8ac60eac0906101839t4d3978fyc1c6d3b3e2eccb6e@mail.gmail.com> Subject: Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections. From: Paul Pluzhnikov To: Tom Tromey Cc: gdb-patches@sources.redhat.com Content-Type: multipart/mixed; boundary=00163631053b0c9546046c08aba1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00285.txt.bz2 --00163631053b0c9546046c08aba1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1175 On Sat, May 30, 2009 at 3:36 PM, Tom Tromey wrote: >>>>>> "Paul" =3D=3D Paul Pluzhnikov writes: > > Tom> It has a number of minor formatting problems, mostly missing spaces > Tom> before open parens. > > Paul> Sorry, these get me every time :-( > > Yeah. Whatever happened to running gdb_indent.sh? Running gdb_indent.sh on these sources produces way too many incorrect indentations :-( I tried my best to have a space before parens this time. > Paul> I would have used bfd_get_file_window(), but it's only compiled in > Paul> when --use-mmap was given to bfd/configure. > Paul> Is there a way to turn that on for GDB? > > Paul> Is it ok to do this in gdb/dwarf2read.c: > Paul> =A0 if (info->size > 4 * pagesize && (sectp->flags & SEC_RELOC) =3D= =3D 0 > Paul> =A0 =A0 =A0 && (abfd->flags & BFD_IN_MEMORY) =3D=3D 0) > > I don't know the answer to either of these. > If nobody here knows, I suggest asking on the binutils list. > If they aren't ok, maybe we could add a new BFD function for this. bfd_mmap is now checking in; attached patch uses it. Tested on Linux/x86_64 with no regressions. Thanks, --=20 Paul Pluzhnikov --00163631053b0c9546046c08aba1 Content-Type: text/plain; charset=US-ASCII; name="bfd-mmap-patch-20090610.txt" Content-Disposition: attachment; filename="bfd-mmap-patch-20090610.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fvsswe810 Content-length: 6674 SW5kZXg6IGJmZC1pbjIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3NyYy9zcmMvYmZkL2JmZC1pbjIuaCx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS40ODIKZGlmZiAtdSAtcCAtdSAtcjEuNDgyIGJmZC1pbjIu aAotLS0gYmZkLWluMi5oCTEgSnVuIDIwMDkgMTM6MTE6NTEgLTAwMDAJMS40 ODIKKysrIGJmZC1pbjIuaAkxMCBKdW4gMjAwOSAxNzowMToyOCAtMDAwMApA QCAtNDYzLDYgKzQ2Myw3IEBAIGV4dGVybiBpbnQgYmZkX3NlZWsgKGJmZCAq LCBmaWxlX3B0ciwgaW4KIGV4dGVybiBmaWxlX3B0ciBiZmRfdGVsbCAoYmZk ICopOwogZXh0ZXJuIGludCBiZmRfZmx1c2ggKGJmZCAqKTsKIGV4dGVybiBp bnQgYmZkX3N0YXQgKGJmZCAqLCBzdHJ1Y3Qgc3RhdCAqKTsKK2V4dGVybiB2 b2lkICpiZmRfbW1hcCAoYmZkICosIHZvaWQgKiwgYmZkX3NpemVfdHlwZSwg aW50LCBpbnQsIGZpbGVfcHRyKTsKIAogLyogRGVwcmVjYXRlZCBvbGQgcm91 dGluZXMuICAqLwogI2lmIF9fR05VQ19fCkluZGV4OiBiZmRpby5jCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9iZmQv YmZkaW8uYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMQpkaWZmIC11IC1w IC11IC1yMS4yMSBiZmRpby5jCi0tLSBiZmRpby5jCTI0IE1heSAyMDA5IDEx OjQ3OjI3IC0wMDAwCTEuMjEKKysrIGJmZGlvLmMJMTAgSnVuIDIwMDkgMTc6 MDE6MjggLTAwMDAKQEAgLTE1OCw2ICsxNTgsOCBAQCBERVNDUklQVElPTgog LiAgaW50ICgqYmNsb3NlKSAoc3RydWN0IGJmZCAqYWJmZCk7CiAuICBpbnQg KCpiZmx1c2gpIChzdHJ1Y3QgYmZkICphYmZkKTsKIC4gIGludCAoKmJzdGF0 KSAoc3RydWN0IGJmZCAqYWJmZCwgc3RydWN0IHN0YXQgKnNiKTsKKy4gIHZv aWQqICgqYm1tYXApIChzdHJ1Y3QgYmZkICphYmZkLCB2b2lkICphZGRyLCBi ZmRfc2l6ZV90eXBlIGxlbiwKKy4gICAgICAgICAgICAgICAgICBpbnQgcHJv dCwgaW50IGZsYWdzLCBmaWxlX3B0ciBvZmZzZXQpOwogLn07CiAKICovCkBA IC01MTEsMyArNTEzLDMxIEBAIGJmZF9nZXRfc2l6ZSAoYmZkICphYmZkKQog CiAgIHJldHVybiBidWYuc3Rfc2l6ZTsKIH0KKworCisvKgorRlVOQ1RJT04K KwliZmRfbW1hcAorCitTWU5PUFNJUworCXZvaWQgKmJmZF9tbWFwIChiZmQg KmFiZmQsIHZvaWQgKmFkZHIsIGJmZF9zaXplX3R5cGUgbGVuLAorCSAgICAg ICAgICAgICAgICBpbnQgcHJvdCwgaW50IGZsYWdzLCBmaWxlX3B0ciBvZmZz ZXQpOworCitERVNDUklQVElPTgorCVJldHVybiBtbWFwKCllZCByZWdpb24g b2YgdGhlIGZpbGUsIGlmIHBvc3NpYmxlIGFuZCBpbXBsZW1lbnRlZC4KKwor Ki8KKwordm9pZCAqCitiZmRfbW1hcCAoYmZkICphYmZkLCB2b2lkICphZGRy LCBiZmRfc2l6ZV90eXBlIGxlbiwKKwkgIGludCBwcm90LCBpbnQgZmxhZ3Ms IGZpbGVfcHRyIG9mZnNldCkKK3sKKyAgdm9pZCAqcmV0ID0gKHZvaWQgKikt MTsKKyAgaWYgKChhYmZkLT5mbGFncyAmIEJGRF9JTl9NRU1PUlkpICE9IDAp CisgICAgcmV0dXJuIHJldDsKKworICBpZiAoYWJmZC0+aW92ZWMgPT0gTlVM TCkKKyAgICByZXR1cm4gcmV0OworCisgIHJldHVybiBhYmZkLT5pb3ZlYy0+ Ym1tYXAgKGFiZmQsIGFkZHIsIGxlbiwgcHJvdCwgZmxhZ3MsIG9mZnNldCk7 Cit9CkluZGV4OiBjYWNoZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvc3JjL3NyYy9iZmQvY2FjaGUuYyx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS4zNApkaWZmIC11IC1wIC11IC1yMS4zNCBjYWNoZS5jCi0t LSBjYWNoZS5jCTMwIE9jdCAyMDA4IDA5OjA1OjMyIC0wMDAwCTEuMzQKKysr IGNhY2hlLmMJMTAgSnVuIDIwMDkgMTc6MDE6MjggLTAwMDAKQEAgLTQ2LDYg KzQ2LDEwIEBAIFNVQlNFQ1RJT04KICNpbmNsdWRlICJsaWJiZmQuaCIKICNp bmNsdWRlICJsaWJpYmVydHkuaCIKIAorI2lmZGVmIEhBVkVfTU1BUAorI2lu Y2x1ZGUgPHN5cy9tbWFuLmg+CisjZW5kaWYKKwogLyogSW4gc29tZSBjYXNl cyB3ZSBjYW4gb3B0aW1pemUgY2FjaGUgb3BlcmF0aW9uIHdoZW4gcmVvcGVu aW5nIGZpbGVzLgogICAgRm9yIGluc3RhbmNlLCBhIGZsdXNoIGlzIGVudGly ZWx5IHVubmVjZXNzYXJ5IGlmIHRoZSBmaWxlIGlzIGFscmVhZHkKICAgIGNs b3NlZCwgc28gYSBmbHVzaCB3b3VsZCB1c2UgQ0FDSEVfTk9fT1BFTi4gIFNp bWlsYXJseSwgYSBzZWVrIHVzaW5nCkBAIC0zODgsMTAgKzM5MiwzOCBAQCBj YWNoZV9ic3RhdCAoc3RydWN0IGJmZCAqYWJmZCwgc3RydWN0IHN0CiAgIHJl dHVybiBzdHM7CiB9CiAKK3N0YXRpYyB2b2lkICoKK2NhY2hlX2JtbWFwIChz dHJ1Y3QgYmZkICphYmZkIEFUVFJJQlVURV9VTlVTRUQsCisJICAgICB2b2lk ICphZGRyIEFUVFJJQlVURV9VTlVTRUQsCisJICAgICBiZmRfc2l6ZV90eXBl IGxlbiBBVFRSSUJVVEVfVU5VU0VELAorCSAgICAgaW50IHByb3QgQVRUUklC VVRFX1VOVVNFRCwKKwkgICAgIGludCBmbGFncyBBVFRSSUJVVEVfVU5VU0VE LAorCSAgICAgZmlsZV9wdHIgb2Zmc2V0IEFUVFJJQlVURV9VTlVTRUQpCit7 CisgIHZvaWQgKnJldCA9ICh2b2lkICopIC0xOworCisgIGlmICgoYWJmZC0+ ZmxhZ3MgJiBCRkRfSU5fTUVNT1JZKSAhPSAwKQorICAgIGFib3J0ICgpOwor I2lmZGVmIEhBVkVfTU1BUAorICBlbHNlCisgICAgeworICAgICAgRklMRSAq ZiA9IGJmZF9jYWNoZV9sb29rdXAgKGFiZmQsIENBQ0hFX05PX1NFRUtfRVJS T1IpOworICAgICAgaWYgKGYgPT0gTlVMTCkKKwlyZXR1cm4gcmV0OworCisg ICAgICByZXQgPSBtbWFwIChhZGRyLCBsZW4sIHByb3QsIGZsYWdzLCBmaWxl bm8gKGYpLCBvZmZzZXQpOworICAgICAgaWYgKHJldCA9PSAodm9pZCAqKSAt MSkKKwliZmRfc2V0X2Vycm9yIChiZmRfZXJyb3Jfc3lzdGVtX2NhbGwpOwor ICAgIH0KKyNlbmRpZgorCisgIHJldHVybiByZXQ7Cit9CisKIHN0YXRpYyBj b25zdCBzdHJ1Y3QgYmZkX2lvdmVjIGNhY2hlX2lvdmVjID0KIHsKICAgJmNh Y2hlX2JyZWFkLCAmY2FjaGVfYndyaXRlLCAmY2FjaGVfYnRlbGwsICZjYWNo ZV9ic2VlaywKLSAgJmNhY2hlX2JjbG9zZSwgJmNhY2hlX2JmbHVzaCwgJmNh Y2hlX2JzdGF0CisgICZjYWNoZV9iY2xvc2UsICZjYWNoZV9iZmx1c2gsICZj YWNoZV9ic3RhdCwgJmNhY2hlX2JtbWFwCiB9OwogCiAvKgpJbmRleDogbGli YmZkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9z cmMvc3JjL2JmZC9saWJiZmQuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4y MTYKZGlmZiAtdSAtcCAtdSAtcjEuMjE2IGxpYmJmZC5oCi0tLSBsaWJiZmQu aAkxIEp1biAyMDA5IDEzOjExOjUyIC0wMDAwCTEuMjE2CisrKyBsaWJiZmQu aAkxMCBKdW4gMjAwOSAxNzowMToyOCAtMDAwMApAQCAtNzczLDYgKzc3Myw5 IEBAIHN0cnVjdCBiZmRfaW92ZWMKICAgaW50ICgqYmNsb3NlKSAoc3RydWN0 IGJmZCAqYWJmZCk7CiAgIGludCAoKmJmbHVzaCkgKHN0cnVjdCBiZmQgKmFi ZmQpOwogICBpbnQgKCpic3RhdCkgKHN0cnVjdCBiZmQgKmFiZmQsIHN0cnVj dCBzdGF0ICpzYik7CisgIC8qIEp1c3QgbGlrZSBtbWFwOiAodm9pZCopLTEg b24gZmFpbHVyZSwgbW1hcHBlZCBhZGRyZXNzIG9uIHN1Y2Nlc3MuICAqLwor ICB2b2lkICooKmJtbWFwKSAoc3RydWN0IGJmZCAqYWJmZCwgdm9pZCAqYWRk ciwgYmZkX3NpemVfdHlwZSBsZW4sCisgICAgICAgICAgICAgICAgICBpbnQg cHJvdCwgaW50IGZsYWdzLCBmaWxlX3B0ciBvZmZzZXQpOwogfTsKIC8qIEV4 dHJhY3RlZCBmcm9tIGJmZHdpbi5jLiAgKi8KIHN0cnVjdCBfYmZkX3dpbmRv d19pbnRlcm5hbCB7CkluZGV4OiBvcG5jbHMuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvYmZkL29wbmNscy5jLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjUzCmRpZmYgLXUgLXAgLXUgLXIxLjUz IG9wbmNscy5jCi0tLSBvcG5jbHMuYwkyMyBBdWcgMjAwOCAwODowODo1OCAt MDAwMAkxLjUzCisrKyBvcG5jbHMuYwkxMCBKdW4gMjAwOSAxNzowMToyOCAt MDAwMApAQCAtNTA1LDkgKzUwNSwyMCBAQCBvcG5jbHNfYnN0YXQgKHN0cnVj dCBiZmQgKmFiZmQsIHN0cnVjdCBzCiAgIHJldHVybiAodmVjLT5zdGF0KSAo YWJmZCwgdmVjLT5zdHJlYW0sIHNiKTsKIH0KIAorc3RhdGljIHZvaWQgKgor b3BuY2xzX2JtbWFwIChzdHJ1Y3QgYmZkICphYmZkIEFUVFJJQlVURV9VTlVT RUQsCisJICAgICAgdm9pZCAqYWRkciBBVFRSSUJVVEVfVU5VU0VELAorCSAg ICAgIGJmZF9zaXplX3R5cGUgbGVuIEFUVFJJQlVURV9VTlVTRUQsCisJICAg ICAgaW50IHByb3QgQVRUUklCVVRFX1VOVVNFRCwKKwkgICAgICBpbnQgZmxh Z3MgQVRUUklCVVRFX1VOVVNFRCwKKwkgICAgICBmaWxlX3B0ciBvZmZzZXQg QVRUUklCVVRFX1VOVVNFRCkKK3sKKyAgcmV0dXJuICh2b2lkICopIC0xOwor fQorCiBzdGF0aWMgY29uc3Qgc3RydWN0IGJmZF9pb3ZlYyBvcG5jbHNfaW92 ZWMgPSB7CiAgICZvcG5jbHNfYnJlYWQsICZvcG5jbHNfYndyaXRlLCAmb3Bu Y2xzX2J0ZWxsLCAmb3BuY2xzX2JzZWVrLAotICAmb3BuY2xzX2JjbG9zZSwg Jm9wbmNsc19iZmx1c2gsICZvcG5jbHNfYnN0YXQKKyAgJm9wbmNsc19iY2xv c2UsICZvcG5jbHNfYmZsdXNoLCAmb3BuY2xzX2JzdGF0LCAmb3BuY2xzX2Jt bWFwCiB9OwogCiBiZmQgKgo= --00163631053b0c9546046c08aba1--