On Mon, Apr 20, 2009 at 6:06 PM, Tom Tromey <tromey@redhat.com> wrote:

> Paul> To address the repeated scanning for objective-c, I propose adding
> Paul> n_objc_syms to the struct objstats, initializing that field to ~0,
>
> I wonder whether it should use the generic per-objfile data storage
> stuff, rather than sticking ObjC-specific stuff directly into the
> objfile.

Thanks, this is probably a good idea. I'll work on that next.

> Paul>  /* Re-set all breakpoints after symbols have been re-loaded.  */
> Paul>  void
> Paul> -breakpoint_re_set (void)
> Paul> +breakpoint_re_set_objfile (struct objfile *objfile)
>
> The new argument needs a description in the function header.

Done.

OK to commit?

Thanks,
-- 
Paul Pluzhnikov


2009-04-29  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* breakpoint.h: Add breakpoint_re_set_objfile prototype.

	* breakpoint.c (breakpoint_re_set_objfile): Don't rescan
	all objfiles unnecessarily.
	(breakpoint_re_set): New function.

	* symfile.c (new_symfile_objfile): Call breakpoint_re_set_objfile
	instead of breakpoint_re_set.

	* objfiles.c (objfile_relocate): Likewise.