From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1950 invoked by alias); 18 Mar 2009 05:45:52 -0000 Received: (qmail 1942 invoked by uid 22791); 18 Mar 2009 05:45:51 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Mar 2009 05:45:45 +0000 Received: from zps35.corp.google.com (zps35.corp.google.com [172.25.146.35]) by smtp-out.google.com with ESMTP id n2I5jeuf021809 for ; Wed, 18 Mar 2009 05:45:41 GMT Received: from gxk3 (gxk3.prod.google.com [10.202.11.3]) by zps35.corp.google.com with ESMTP id n2I5jcX6011033 for ; Tue, 17 Mar 2009 22:45:39 -0700 Received: by gxk3 with SMTP id 3so623407gxk.16 for ; Tue, 17 Mar 2009 22:45:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.58.20 with SMTP id g20mr92848wfa.191.1237355138189; Tue, 17 Mar 2009 22:45:38 -0700 (PDT) In-Reply-To: <200903180412.43887.pedro@codesourcery.com> References: <20090205030257.8A6073A6B7A@localhost> <20090318031516.GL31979@adacore.com> <8ac60eac0903172024g4e381249t43bac2b4c9769a04@mail.gmail.com> <200903180412.43887.pedro@codesourcery.com> Date: Wed, 18 Mar 2009 06:54:00 -0000 Message-ID: <8ac60eac0903172245w65d7a109pfa3a1866e102423d@mail.gmail.com> Subject: Re: [patch] Fix a crash when displaying variables from shared ?library. From: Paul Pluzhnikov To: Pedro Alves Cc: Joel Brobecker , gdb-patches@sourceware.org, tromey@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00367.txt.bz2 On Tue, Mar 17, 2009 at 9:12 PM, Pedro Alves wrote: >> Of course we might just as well skip the test, since it's not going >> to test much in that case. > > Or that is fine with me too. I just committed this: Index: gdb.base/solib-display.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/solib-display.exp,v retrieving revision 1.1 diff -u -p -u -r1.1 solib-display.exp --- gdb.base/solib-display.exp 5 Mar 2009 23:45:14 -0000 1.1 +++ gdb.base/solib-display.exp 18 Mar 2009 05:41:35 -0000 @@ -28,7 +28,7 @@ # (and thus aren't affected by shared library unloading) are not # disabled prematurely. -if [skip_shlib_tests] then { +if { [skip_shlib_tests] || [is_remote target] } { return 0 } -- Paul Pluzhnikov