From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20856 invoked by alias); 12 Mar 2009 01:11:58 -0000 Received: (qmail 20137 invoked by uid 22791); 12 Mar 2009 01:11:55 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Mar 2009 01:11:47 +0000 Received: from spaceape14.eur.corp.google.com (spaceape14.eur.corp.google.com [172.28.16.148]) by smtp-out.google.com with ESMTP id n2C1BjSO016753 for ; Thu, 12 Mar 2009 01:11:45 GMT Received: from wf-out-1314.google.com (wfd26.prod.google.com [10.142.4.26]) by spaceape14.eur.corp.google.com with ESMTP id n2C1Bcmg030733 for ; Wed, 11 Mar 2009 18:11:43 -0700 Received: by wf-out-1314.google.com with SMTP id 26so310839wfd.8 for ; Wed, 11 Mar 2009 18:11:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.156.19 with SMTP id d19mr4009218wfe.6.1236820298230; Wed, 11 Mar 2009 18:11:38 -0700 (PDT) In-Reply-To: <20090310133745.GA4891@caradoc.them.org> References: <8ac60eac0903021830w363783ear7d4c8fc1177d6448@mail.gmail.com> <8ac60eac0903041124s1aafb562u225f268c4d1511dd@mail.gmail.com> <20090305200415.GC3744@adacore.com> <8ac60eac0903051546r1eaffc89tf1f35b21e6dc1b40@mail.gmail.com> <8ac60eac0903051906r5d41990bwcaccdfb4accef562@mail.gmail.com> <20090306174822.GJ3744@adacore.com> <8ac60eac0903061406t610ba1a1y1c62e5ee30332c7c@mail.gmail.com> <20090309183316.GA4561@adacore.com> <8ac60eac0903091624w6ec724e7s14fbfd9febc7e9c3@mail.gmail.com> <20090310133745.GA4891@caradoc.them.org> Date: Thu, 12 Mar 2009 02:45:00 -0000 Message-ID: <8ac60eac0903111811n4369527et4cdeea4b09f4601f@mail.gmail.com> Subject: Re: [patch] Fix a crash when displaying variables from shared library. From: Paul Pluzhnikov To: Paul Pluzhnikov , Joel Brobecker , tromey@redhat.com, Pedro Alves , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=000e0cd17b9a86ec360464e1aa0d X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00164.txt.bz2 --000e0cd17b9a86ec360464e1aa0d Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 815 On Tue, Mar 10, 2009 at 6:37 AM, Daniel Jacobowitz wrote: > Disabling a shlib_event breakpoint is pretty weird - there won't be an > event to restore it, so unless we're restarting the program it won't > be enabled again ever. If we're disabling a step-return or finish > breakpoint, we'll lose control of the inferior. And so forth... Thanks, I think I understood how this works now. Attached patch is simply a cleanup (i.e. I dont't really care if it is applied or not, though I think it is more efficient and easier to understand the source). It introduces no regressions of Linux/x86_64. OK to commit? -- Paul Pluzhnikov 2009-03-11 Paul Pluzhnikov * breakpoint.c (disable_breakpoints_in_shlibs): Use solib_contains_address_p instead of searching. --000e0cd17b9a86ec360464e1aa0d Content-Type: text/plain; charset=US-ASCII; name="gdb-rename-solib-20090309.txt" Content-Disposition: attachment; filename="gdb-rename-solib-20090309.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fs6qrun50 Content-length: 2989 SW5kZXg6IGJyZWFrcG9pbnQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2JyZWFrcG9pbnQuYyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS4zODMKZGlmZiAtdSAtcCAtdSAtcjEuMzgzIGJy ZWFrcG9pbnQuYwotLS0gYnJlYWtwb2ludC5jCTExIE1hciAyMDA5IDIwOjI2 OjAyIC0wMDAwCTEuMzgzCisrKyBicmVha3BvaW50LmMJMTIgTWFyIDIwMDkg MDE6MDQ6MzQgLTAwMDAKQEAgLTQ0NDIsNyArNDQ0Miw3IEBAIGRpc2FibGVf YnJlYWtwb2ludHNfaW5fc2hsaWJzICh2b2lkKQogICAgICAgIGFsbCBicmVh a3BvaW50cy4gIElmIHdlIGRvbid0IHNldCBzaGxpYl9kaXNhYmxlZCBoZXJl LCB3ZSdsbCB0cnkKICAgICAgICB0byBpbnNlcnQgdGhvc2UgYnJlYWtwb2lu dHMgYW5kIGZhaWwuICAqLwogICAgIGlmICgoKGItPnR5cGUgPT0gYnBfYnJl YWtwb2ludCkgfHwgKGItPnR5cGUgPT0gYnBfaGFyZHdhcmVfYnJlYWtwb2lu dCkpCi0JJiYgIWxvYy0+c2hsaWJfZGlzYWJsZWQKKyAJJiYgIWxvYy0+c2hs aWJfZGlzYWJsZWQKICNpZmRlZiBQQ19TT0xJQgogCSYmIFBDX1NPTElCIChs b2MtPmFkZHJlc3MpCiAjZWxzZQpAQCAtNDQ3NywyOCArNDQ3NywyMiBAQCBk aXNhYmxlX2JyZWFrcG9pbnRzX2luX3VubG9hZGVkX3NobGliIChzCiAgICAg c3RydWN0IGJyZWFrcG9pbnQgKmIgPSBsb2MtPm93bmVyOwogICAgIGlmICgo bG9jLT5sb2NfdHlwZSA9PSBicF9sb2NfaGFyZHdhcmVfYnJlYWtwb2ludAog CSB8fCBsb2MtPmxvY190eXBlID09IGJwX2xvY19zb2Z0d2FyZV9icmVha3Bv aW50KQotCSYmICFsb2MtPnNobGliX2Rpc2FibGVkKQorCSYmICFsb2MtPnNo bGliX2Rpc2FibGVkCisJJiYgKGItPnR5cGUgPT0gYnBfYnJlYWtwb2ludCB8 fCBiLT50eXBlID09IGJwX2hhcmR3YXJlX2JyZWFrcG9pbnQpCisJJiYgc29s aWJfY29udGFpbnNfYWRkcmVzc19wIChzb2xpYiwgbG9jLT5hZGRyZXNzKSkK ICAgICAgIHsKLSNpZmRlZiBQQ19TT0xJQgotCWNoYXIgKnNvX25hbWUgPSBQ Q19TT0xJQiAobG9jLT5hZGRyZXNzKTsKLSNlbHNlCi0JY2hhciAqc29fbmFt ZSA9IHNvbGliX25hbWVfZnJvbV9hZGRyZXNzIChsb2MtPmFkZHJlc3MpOwot I2VuZGlmCi0JaWYgKHNvX25hbWUgJiYgIXN0cmNtcCAoc29fbmFtZSwgc29s aWItPnNvX25hbWUpKQotICAgICAgICAgIHsKLQkgICAgbG9jLT5zaGxpYl9k aXNhYmxlZCA9IDE7Ci0JICAgIC8qIEF0IHRoaXMgcG9pbnQsIHdlIGNhbm5v dCByZWx5IG9uIHJlbW92ZV9icmVha3BvaW50Ci0JICAgICAgIHN1Y2NlZWRp bmcgc28gd2UgbXVzdCBtYXJrIHRoZSBicmVha3BvaW50IGFzIG5vdCBpbnNl cnRlZAotCSAgICAgICB0byBwcmV2ZW50IGZ1dHVyZSBlcnJvcnMgb2NjdXJy aW5nIGluIHJlbW92ZV9icmVha3BvaW50cy4gICovCi0JICAgIGxvYy0+aW5z ZXJ0ZWQgPSAwOwotCSAgICBpZiAoIWRpc2FibGVkX3NobGliX2JyZWFrcykK LQkgICAgICB7Ci0JCXRhcmdldF90ZXJtaW5hbF9vdXJzX2Zvcl9vdXRwdXQg KCk7Ci0JCXdhcm5pbmcgKF8oIlRlbXBvcmFyaWx5IGRpc2FibGluZyBicmVh a3BvaW50cyBmb3IgdW5sb2FkZWQgc2hhcmVkIGxpYnJhcnkgXCIlc1wiIiks Ci0JCQkgIHNvX25hbWUpOwotCSAgICAgIH0KLQkgICAgZGlzYWJsZWRfc2hs aWJfYnJlYWtzID0gMTsKKwlsb2MtPnNobGliX2Rpc2FibGVkID0gMTsKKwkv KiBBdCB0aGlzIHBvaW50LCB3ZSBjYW5ub3QgcmVseSBvbiByZW1vdmVfYnJl YWtwb2ludAorCSAgIHN1Y2NlZWRpbmcgc28gd2UgbXVzdCBtYXJrIHRoZSBi cmVha3BvaW50IGFzIG5vdCBpbnNlcnRlZAorCSAgIHRvIHByZXZlbnQgZnV0 dXJlIGVycm9ycyBvY2N1cnJpbmcgaW4gcmVtb3ZlX2JyZWFrcG9pbnRzLiAg Ki8KKwlsb2MtPmluc2VydGVkID0gMDsKKwlpZiAoIWRpc2FibGVkX3NobGli X2JyZWFrcykKKwkgIHsKKwkgICAgdGFyZ2V0X3Rlcm1pbmFsX291cnNfZm9y X291dHB1dCAoKTsKKwkgICAgd2FybmluZyAoXygiVGVtcG9yYXJpbHkgZGlz YWJsaW5nIGJyZWFrcG9pbnRzIGZvciB1bmxvYWRlZCBzaGFyZWQgbGlicmFy eSBcIiVzXCIiKSwKKwkJICAgICBzb2xpYi0+c29fbmFtZSk7CiAJICB9CisJ ZGlzYWJsZWRfc2hsaWJfYnJlYWtzID0gMTsKICAgICAgIH0KICAgfQogfQo= --000e0cd17b9a86ec360464e1aa0d--