From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9410 invoked by alias); 6 Mar 2009 18:31:58 -0000 Received: (qmail 9398 invoked by uid 22791); 6 Mar 2009 18:31:57 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Mar 2009 18:31:52 +0000 Received: from zps75.corp.google.com (zps75.corp.google.com [172.25.146.75]) by smtp-out.google.com with ESMTP id n26IVmob028118 for ; Fri, 6 Mar 2009 18:31:48 GMT Received: from wf-out-1314.google.com (wfd26.prod.google.com [10.142.4.26]) by zps75.corp.google.com with ESMTP id n26IVOFF011758 for ; Fri, 6 Mar 2009 10:31:46 -0800 Received: by wf-out-1314.google.com with SMTP id 26so652803wfd.32 for ; Fri, 06 Mar 2009 10:31:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.186.9 with SMTP id j9mr1218342wff.5.1236364306401; Fri, 06 Mar 2009 10:31:46 -0800 (PST) In-Reply-To: <20090306174822.GJ3744@adacore.com> References: <20090223010759.GA30997@adacore.com> <8ac60eac0902231012lb42bcb1q8b8cf19ad2ac192@mail.gmail.com> <8ac60eac0903021830w363783ear7d4c8fc1177d6448@mail.gmail.com> <8ac60eac0903041124s1aafb562u225f268c4d1511dd@mail.gmail.com> <20090305200415.GC3744@adacore.com> <8ac60eac0903051546r1eaffc89tf1f35b21e6dc1b40@mail.gmail.com> <8ac60eac0903051906r5d41990bwcaccdfb4accef562@mail.gmail.com> <20090306174822.GJ3744@adacore.com> Date: Fri, 06 Mar 2009 18:31:00 -0000 Message-ID: <8ac60eac0903061031n82e758cp1b56bf374a3de838@mail.gmail.com> Subject: Re: [patch] Fix a crash when displaying variables from shared library. From: Paul Pluzhnikov To: Joel Brobecker Cc: tromey@redhat.com, Pedro Alves , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=000e0cd28d764bccd90464777f7e X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org X-SW-Source: 2009-03/txt/msg00083.txt.bz2 --000e0cd28d764bccd90464777f7e Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 903 On Fri, Mar 6, 2009 at 9:48 AM, Joel Brobecker wrote: > (On a side note - I think that "solib_address" is a bad name. > Independently of this change, we should think about changing it > to "solib_name_from_address" one of these days). Attached patch does that. I didn't touch similarly mis-named xcoff_solib_address, because I can't see any use of that symbol. Perhaps it should be deleted? If it's a debug-only helper, I can rename it and add a comment to that effect. Thanks, -- Paul Pluzhnikov 2009-03-06 Paul Pluzhnikov Rename solib_address to solib_name_from_address. * breakpoint.c (insert_bp_location, disable_breakpoints_in_shlibs) (disable_breakpoints_in_unloaded_shlib): Update. * printcmd.c (display_uses_solib_p): Likewise. * stack.c (print_frame): Likewise. * solib.c: Rename. * solib.h: Rename. --000e0cd28d764bccd90464777f7e Content-Type: text/plain; charset=US-ASCII; name="gdb-rename-solib-20090306.txt" Content-Disposition: attachment; filename="gdb-rename-solib-20090306.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_frz7d93b0 Content-length: 5909 SW5kZXg6IGJyZWFrcG9pbnQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2JyZWFrcG9pbnQuYyx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS4zODEKZGlmZiAtdSAtcCAtdSAtcjEuMzgxIGJy ZWFrcG9pbnQuYwotLS0gYnJlYWtwb2ludC5jCTUgTWFyIDIwMDkgMjI6Mzc6 MTAgLTAwMDAJMS4zODEKKysrIGJyZWFrcG9pbnQuYwk2IE1hciAyMDA5IDE4 OjIzOjQ2IC0wMDAwCkBAIC0xMTYwLDcgKzExNjAsNyBAQCBOb3RlOiBhdXRv bWF0aWNhbGx5IHVzaW5nIGhhcmR3YXJlIGJyZWFrCiAgICAgICBpZiAodmFs KQogCXsKIAkgIC8qIENhbid0IHNldCB0aGUgYnJlYWtwb2ludC4gICovCi0J ICBpZiAoc29saWJfYWRkcmVzcyAoYnB0LT5hZGRyZXNzKSkKKwkgIGlmIChz b2xpYl9uYW1lX2Zyb21fYWRkcmVzcyAoYnB0LT5hZGRyZXNzKSkKIAkgICAg ewogCSAgICAgIC8qIFNlZSBhbHNvOiBkaXNhYmxlX2JyZWFrcG9pbnRzX2lu X3NobGlicy4gKi8KIAkgICAgICB2YWwgPSAwOwpAQCAtMTYyOSw3ICsxNjI5 LDcgQEAgcmVtb3ZlX2JyZWFrcG9pbnQgKHN0cnVjdCBicF9sb2NhdGlvbiAq YgogICAgICAgLyogSW4gc29tZSBjYXNlcywgd2UgbWlnaHQgbm90IGJlIGFi bGUgdG8gcmVtb3ZlIGEgYnJlYWtwb2ludAogCSBpbiBhIHNoYXJlZCBsaWJy YXJ5IHRoYXQgaGFzIGFscmVhZHkgYmVlbiByZW1vdmVkLCBidXQgd2UKIAkg aGF2ZSBub3QgeWV0IHByb2Nlc3NlZCB0aGUgc2hsaWIgdW5sb2FkIGV2ZW50 LiAgKi8KLSAgICAgIGlmICh2YWwgJiYgc29saWJfYWRkcmVzcyAoYi0+YWRk cmVzcykpCisgICAgICBpZiAodmFsICYmIHNvbGliX25hbWVfZnJvbV9hZGRy ZXNzIChiLT5hZGRyZXNzKSkKIAl2YWwgPSAwOwogCiAgICAgICBpZiAodmFs KQpAQCAtNDQzOSw3ICs0NDM5LDcgQEAgZGlzYWJsZV9icmVha3BvaW50c19p bl9zaGxpYnMgKHZvaWQpCiAjaWZkZWYgUENfU09MSUIKIAkmJiBQQ19TT0xJ QiAobG9jLT5hZGRyZXNzKQogI2Vsc2UKLQkmJiBzb2xpYl9hZGRyZXNzIChs b2MtPmFkZHJlc3MpCisJJiYgc29saWJfbmFtZV9mcm9tX2FkZHJlc3MgKGxv Yy0+YWRkcmVzcykKICNlbmRpZgogCSkKICAgICAgIHsKQEAgLTQ0NzUsNyAr NDQ3NSw3IEBAIGRpc2FibGVfYnJlYWtwb2ludHNfaW5fdW5sb2FkZWRfc2hs aWIgKHMKICNpZmRlZiBQQ19TT0xJQgogCWNoYXIgKnNvX25hbWUgPSBQQ19T T0xJQiAobG9jLT5hZGRyZXNzKTsKICNlbHNlCi0JY2hhciAqc29fbmFtZSA9 IHNvbGliX2FkZHJlc3MgKGxvYy0+YWRkcmVzcyk7CisJY2hhciAqc29fbmFt ZSA9IHNvbGliX25hbWVfZnJvbV9hZGRyZXNzIChsb2MtPmFkZHJlc3MpOwog I2VuZGlmCiAJaWYgKHNvX25hbWUgJiYgIXN0cmNtcCAoc29fbmFtZSwgc29s aWItPnNvX25hbWUpKQogICAgICAgICAgIHsKSW5kZXg6IHByaW50Y21kLmMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3Jj L2dkYi9wcmludGNtZC5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE0NQpk aWZmIC11IC1wIC11IC1yMS4xNDUgcHJpbnRjbWQuYwotLS0gcHJpbnRjbWQu Ywk1IE1hciAyMDA5IDIzOjQ1OjE0IC0wMDAwCTEuMTQ1CisrKyBwcmludGNt ZC5jCTYgTWFyIDIwMDkgMTg6MjM6NDYgLTAwMDAKQEAgLTE3NjcsNyArMTc2 Nyw3IEBAIGRpc3BsYXlfdXNlc19zb2xpYl9wIChjb25zdCBzdHJ1Y3QgZGlz cGwKICAgc3RydWN0IGV4cHJlc3Npb24gKmNvbnN0IGV4cCA9IGQtPmV4cDsK IAogICBpZiAoZC0+YmxvY2sgIT0gTlVMTAotICAgICAgJiYgc29saWJfYWRk cmVzcyAoZC0+YmxvY2stPnN0YXJ0YWRkcikgPT0gc29saWItPnNvX25hbWUp CisgICAgICAmJiBzb2xpYl9uYW1lX2Zyb21fYWRkcmVzcyAoZC0+YmxvY2st PnN0YXJ0YWRkcikgPT0gc29saWItPnNvX25hbWUpCiAgICAgcmV0dXJuIDE7 CiAKICAgZm9yIChpID0gMDsgaSA8IGV4cC0+bmVsdHM7ICkKQEAgLTE3ODMs NyArMTc4Myw3IEBAIGRpc3BsYXlfdXNlc19zb2xpYl9wIChjb25zdCBzdHJ1 Y3QgZGlzcGwKIAkgICAgU1lNQk9MX09CSl9TRUNUSU9OIChzeW1ib2wpOwog CiAJICBpZiAoYmxvY2sgIT0gTlVMTAotCSAgICAgICYmIHNvbGliX2FkZHJl c3MgKGJsb2NrLT5zdGFydGFkZHIpID09IHNvbGliLT5zb19uYW1lKQorCSAg ICAgICYmIHNvbGliX25hbWVfZnJvbV9hZGRyZXNzIChibG9jay0+c3RhcnRh ZGRyKSA9PSBzb2xpYi0+c29fbmFtZSkKIAkgICAgcmV0dXJuIDE7CiAKIAkg IGlmIChzZWN0aW9uICYmIHNlY3Rpb24tPm9iamZpbGUgPT0gc29saWItPm9i amZpbGUpCkluZGV4OiBzb2xpYi5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvc29saWIuYyx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xMTIKZGlmZiAtdSAtcCAtdSAtcjEuMTEyIHNvbGli LmMKLS0tIHNvbGliLmMJNSBNYXIgMjAwOSAyMzo0NToxNCAtMDAwMAkxLjEx MgorKysgc29saWIuYwk2IE1hciAyMDA5IDE4OjIzOjQ2IC0wMDAwCkBAIC04 MzgsMTEgKzgzOCwxMiBAQCBpbmZvX3NoYXJlZGxpYnJhcnlfY29tbWFuZCAo Y2hhciAqaWdub3JlCiAKICAgIEdMT0JBTCBGVU5DVElPTgogCi0gICBzb2xp Yl9hZGRyZXNzIC0tIGNoZWNrIHRvIHNlZSBpZiBhbiBhZGRyZXNzIGlzIGlu IGEgc2hhcmVkIGxpYgorICAgc29saWJfbmFtZV9mcm9tX2FkZHJlc3MgLS0g aWYgYW4gYWRkcmVzcyBpcyBpbiBhIHNoYXJlZCBsaWIsIHJldHVybgorICAg aXRzIG5hbWUuCiAKICAgIFNZTk9QU0lTCiAKLSAgIGNoYXIgKiBzb2xpYl9h ZGRyZXNzIChDT1JFX0FERFIgYWRkcmVzcykKKyAgIGNoYXIgKiBzb2xpYl9u YW1lX2Zyb21fYWRkcmVzcyAoQ09SRV9BRERSIGFkZHJlc3MpCiAKICAgIERF U0NSSVBUSU9OCiAKQEAgLTg1Niw3ICs4NTcsNyBAQCBpbmZvX3NoYXJlZGxp YnJhcnlfY29tbWFuZCAoY2hhciAqaWdub3JlCiAgKi8KIAogY2hhciAqCi1z b2xpYl9hZGRyZXNzIChDT1JFX0FERFIgYWRkcmVzcykKK3NvbGliX25hbWVf ZnJvbV9hZGRyZXNzIChDT1JFX0FERFIgYWRkcmVzcykKIHsKICAgc3RydWN0 IHNvX2xpc3QgKnNvID0gMDsJLyogbGluayBtYXAgc3RhdGUgdmFyaWFibGUg Ki8KIApJbmRleDogc29saWIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL3NvbGliLmgsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMjEKZGlmZiAtdSAtcCAtdSAtcjEuMjEgc29saWIuaAot LS0gc29saWIuaAkzIEphbiAyMDA5IDA1OjU3OjUzIC0wMDAwCTEuMjEKKysr IHNvbGliLmgJNiBNYXIgMjAwOSAxODoyMzo0NiAtMDAwMApAQCAtNDUsNyAr NDUsNyBAQCBleHRlcm4gdm9pZCBzb2xpYl9jcmVhdGVfaW5mZXJpb3JfaG9v ayAoCiAKIC8qIElmIEFERFIgbGllcyBpbiBhIHNoYXJlZCBsaWJyYXJ5LCBy ZXR1cm4gaXRzIG5hbWUuICAqLwogCi1leHRlcm4gY2hhciAqc29saWJfYWRk cmVzcyAoQ09SRV9BRERSKTsKK2V4dGVybiBjaGFyICpzb2xpYl9uYW1lX2Zy b21fYWRkcmVzcyAoQ09SRV9BRERSKTsKIAogLyogUmV0dXJuIDEgaWYgUEMg bGllcyBpbiB0aGUgZHluYW1pYyBzeW1ib2wgcmVzb2x1dGlvbiBjb2RlIG9m IHRoZQogICAgcnVuIHRpbWUgbG9hZGVyLiAgKi8KSW5kZXg6IHN0YWNrLmMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3Jj L2dkYi9zdGFjay5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE4NQpkaWZm IC11IC1wIC11IC1yMS4xODUgc3RhY2suYwotLS0gc3RhY2suYwkxMSBGZWIg MjAwOSAxNjowNzoyOCAtMDAwMAkxLjE4NQorKysgc3RhY2suYwk2IE1hciAy MDA5IDE4OjIzOjQ2IC0wMDAwCkBAIC03MzAsNyArNzMwLDcgQEAgcHJpbnRf ZnJhbWUgKHN0cnVjdCBmcmFtZV9pbmZvICpmcmFtZSwgaQogI2lmZGVmIFBD X1NPTElCCiAgICAgICBjaGFyICpsaWIgPSBQQ19TT0xJQiAoZ2V0X2ZyYW1l X3BjIChmcmFtZSkpOwogI2Vsc2UKLSAgICAgIGNoYXIgKmxpYiA9IHNvbGli X2FkZHJlc3MgKGdldF9mcmFtZV9wYyAoZnJhbWUpKTsKKyAgICAgIGNoYXIg KmxpYiA9IHNvbGliX25hbWVfZnJvbV9hZGRyZXNzIChnZXRfZnJhbWVfcGMg KGZyYW1lKSk7CiAjZW5kaWYKICAgICAgIGlmIChsaWIpCiAJewo= --000e0cd28d764bccd90464777f7e--