From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3952 invoked by alias); 6 Mar 2009 03:18:51 -0000 Received: (qmail 3944 invoked by uid 22791); 6 Mar 2009 03:18:51 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Mar 2009 03:18:46 +0000 Received: from zps35.corp.google.com (zps35.corp.google.com [172.25.146.35]) by smtp-out.google.com with ESMTP id n263IhDM014083 for ; Thu, 5 Mar 2009 19:18:44 -0800 Received: from rv-out-0506.google.com (rvbg9.prod.google.com [10.140.83.9]) by zps35.corp.google.com with ESMTP id n263IgTx007929 for ; Thu, 5 Mar 2009 19:18:42 -0800 Received: by rv-out-0506.google.com with SMTP id g9so274898rvb.7 for ; Thu, 05 Mar 2009 19:18:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.143.13.16 with SMTP id q16mr863667wfi.67.1236309522437; Thu, 05 Mar 2009 19:18:42 -0800 (PST) In-Reply-To: <8ac60eac0903051906r5d41990bwcaccdfb4accef562@mail.gmail.com> References: <20090205030257.8A6073A6B7A@localhost> <8ac60eac0902181458g39dfbce9k63c3329528b0aad5@mail.gmail.com> <20090223010759.GA30997@adacore.com> <8ac60eac0902231012lb42bcb1q8b8cf19ad2ac192@mail.gmail.com> <8ac60eac0903021830w363783ear7d4c8fc1177d6448@mail.gmail.com> <8ac60eac0903041124s1aafb562u225f268c4d1511dd@mail.gmail.com> <20090305200415.GC3744@adacore.com> <8ac60eac0903051546r1eaffc89tf1f35b21e6dc1b40@mail.gmail.com> <8ac60eac0903051906r5d41990bwcaccdfb4accef562@mail.gmail.com> Date: Fri, 06 Mar 2009 03:18:00 -0000 Message-ID: <8ac60eac0903051918hd560514g3979a4f3bc412060@mail.gmail.com> Subject: Re: [patch] Fix a crash when displaying variables from shared library. From: Paul Pluzhnikov To: Joel Brobecker Cc: tromey@redhat.com, Pedro Alves , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org X-SW-Source: 2009-03/txt/msg00077.txt.bz2 On Thu, Mar 5, 2009 at 7:06 PM, Paul Pluzhnikov wrote: > I am not sure whether: > A) bp_shlib_event type breakpoints should also be shlib_disable'd, or > B) disable_breakpoints_in_unloaded_shlib() should only warn about > bp_breakpoint and bp_hardware_breakpoint type, or > C) the call to "solib_address (block->startaddr)" should be replaced with > something like "solib_contains_p (solib, block->startaddr)" (which would > then work independently of the so_list_head). Or (D) remove (currently useless) block->startaddr checks, and rely solely on symbol->section->objfile == solib->objfile check. Thanks, -- Paul Pluzhnikov