Re: [patch] Fix a crash when displaying variables from shared library.

Tom Tromey
2009-02-11T01:46:06Z

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

>> http://sourceware.org/ml/gdb-patches/2009-02/msg00002.html

Paul> This turned out to be non-issue: disable_breakpoints_in_shlibs()
Paul> is called just a couple of lines above, so by the time we get into
Paul> disable_breakpoints_in_unloaded_shlib(), all of them already have
Paul> loc-> shlib_disable == 1, and it remains silent.

The comment in that function says that this is true for ELF shared
libraries, but not others.

But, it seems to me that notifying the observer here is the right
thing to do -- otherwise this observer is unreliable.

This patch is ok.

Tom