Re: [patch] Fix a crash when displaying variables from shared library.

Joel Brobecker
2009-03-06T17:48:32Z

> A) bp_shlib_event type breakpoints should also be shlib_disable'd, or

For this option, I'm not sure off the top of my head. I think it would
require careful analysis. If we were going this route, I would
definitely not approve the change just on my own (I'd ask for confirmation
from my fellow maintainers).

Let put this aside for now...

> C) the call to "solib_address (block->startaddr)" should be replaced with
> something like "solib_contains_p (solib, block->startaddr)" (which would
> then work independently of the so_list_head).

Duh! Yes - this sounds like a pretty simple way to do this. We know
which solib we're trying to match our expression against, why are we
iterating over all SOs again? I like your suggestion.

The body of solib_contains_p (can we rename it to "solib_contains_address"
or "solib_has_address") can be extracted from solib_address.

(On a side note - I think that "solib_address" is a bad name.
Independently of this change, we should think about changing it
to "solib_name_from_address" one of these days).

--
Joel