From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4234 invoked by alias); 14 Jul 2008 18:12:27 -0000 Received: (qmail 4220 invoked by uid 22791); 14 Jul 2008 18:12:26 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 Jul 2008 18:12:10 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id m6EIC2HG008543 for ; Mon, 14 Jul 2008 19:12:02 +0100 Received: from ti-out-0910.google.com (tim24.prod.google.com [10.110.13.24]) by wpaz5.hot.corp.google.com with ESMTP id m6EIC0Jv014994 for ; Mon, 14 Jul 2008 11:12:01 -0700 Received: by ti-out-0910.google.com with SMTP id 24so2539219tim.7 for ; Mon, 14 Jul 2008 11:12:00 -0700 (PDT) Received: by 10.150.133.17 with SMTP id g17mr20678921ybd.196.1216059119582; Mon, 14 Jul 2008 11:11:59 -0700 (PDT) Received: by 10.151.109.14 with HTTP; Mon, 14 Jul 2008 11:11:59 -0700 (PDT) Message-ID: <8ac60eac0807141111r58b047a3j7fd4a39080b1be19@mail.gmail.com> Date: Mon, 14 Jul 2008 18:12:00 -0000 From: "Paul Pluzhnikov" To: "Paul Pluzhnikov" , gdb-patches@sourceware.org Subject: Re: [RFA] Patch for PR gdb/2477 In-Reply-To: <20080714174245.GA9888@caradoc.them.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_68095_7784663.1216059119602" References: <20080714173149.A03E63A67B4@localhost> <20080714174245.GA9888@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00290.txt.bz2 ------=_Part_68095_7784663.1216059119602 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 912 On Mon, Jul 14, 2008 at 10:42 AM, Daniel Jacobowitz wrote: > There's nothing special about zero. It's just an unreadable memory > address; the same problem will reappear with any other invalid > pointer. There is something special about zero -- it very frequently occurs in correct C++ programs :) > So if we use TRY_CATCH and RETURN_MASK_ERROR around the call to > current_cp_abi.rtti_type, we can return NULL in the error case. Done. I've also added a "non-zero but invalid" pointer test at ~0UL. Is there a "canonical" invalid address I should be testing instead? Thanks, -- Paul Pluzhnikov ChangeLog 2008-07-14 Paul Pluzhnikov PR gdb/2477 * cp-abi.c (value_virtual_fn_field): Handle invalid pointers. testsuite/ChangeLog 2008-07-14 Paul Pluzhnikov * gdb.cp/class2.exp, gdb.cp/class2.cc: Test for PR2477. ------=_Part_68095_7784663.1216059119602 Content-Type: text/plain; name=gdb-patch-2477-20080714-2.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fine50nn0 Content-Disposition: attachment; filename=gdb-patch-2477-20080714-2.txt Content-length: 3587 SW5kZXg6IGdkYi9jcC1hYmkuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2NwLWFiaS5jLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjIxCmRpZmYgLXUgLXAgLXUgLXIxLjIxIGNwLWFiaS5j Ci0tLSBnZGIvY3AtYWJpLmMJMSBKYW4gMjAwOCAyMjo1MzowOSAtMDAwMAkx LjIxCisrKyBnZGIvY3AtYWJpLmMJMTQgSnVsIDIwMDggMTg6MDE6MTkgLTAw MDAKQEAgLTIyLDYgKzIyLDcgQEAKICNpbmNsdWRlICJ2YWx1ZS5oIgogI2lu Y2x1ZGUgImNwLWFiaS5oIgogI2luY2x1ZGUgImNvbW1hbmQuaCIKKyNpbmNs dWRlICJleGNlcHRpb25zLmgiCiAjaW5jbHVkZSAiZ2RiY21kLmgiCiAjaW5j bHVkZSAidWktb3V0LmgiCiAKQEAgLTg5LDkgKzkwLDE3IEBAIHZhbHVlX3Zp cnR1YWxfZm5fZmllbGQgKHN0cnVjdCB2YWx1ZSAqKmEKIHN0cnVjdCB0eXBl ICoKIHZhbHVlX3J0dGlfdHlwZSAoc3RydWN0IHZhbHVlICp2LCBpbnQgKmZ1 bGwsIGludCAqdG9wLCBpbnQgKnVzaW5nX2VuYykKIHsKKyAgc3RydWN0IHR5 cGUgKnJldCA9IE5VTEw7CisgIHN0cnVjdCBnZGJfZXhjZXB0aW9uIGU7CiAg IGlmICgoY3VycmVudF9jcF9hYmkucnR0aV90eXBlKSA9PSBOVUxMKQogICAg IHJldHVybiBOVUxMOwotICByZXR1cm4gKCpjdXJyZW50X2NwX2FiaS5ydHRp X3R5cGUpICh2LCBmdWxsLCB0b3AsIHVzaW5nX2VuYyk7CisgIFRSWV9DQVRD SCAoZSwgUkVUVVJOX01BU0tfRVJST1IpCisgICAgeworICAgICAgcmV0ID0g KCpjdXJyZW50X2NwX2FiaS5ydHRpX3R5cGUpICh2LCBmdWxsLCB0b3AsIHVz aW5nX2VuYyk7CisgICAgfQorICBpZiAoZS5yZWFzb24gPCAwKQorICAgIHJl dHVybiBOVUxMOworICByZXR1cm4gcmV0OwogfQogCiB2b2lkCkluZGV4OiBn ZGIvdGVzdHN1aXRlL2dkYi5jcC9jbGFzczIuY2MKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi90ZXN0c3VpdGUv Z2RiLmNwL2NsYXNzMi5jYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS42CmRp ZmYgLXUgLXAgLXUgLXIxLjYgY2xhc3MyLmNjCi0tLSBnZGIvdGVzdHN1aXRl L2dkYi5jcC9jbGFzczIuY2MJMSBKYW4gMjAwOCAyMjo1MzoxOSAtMDAwMAkx LjYKKysrIGdkYi90ZXN0c3VpdGUvZ2RiLmNwL2NsYXNzMi5jYwkxNCBKdWwg MjAwOCAxODowMToxOSAtMDAwMApAQCAtNDEsNiArNDEsMTIgQEAgQjo6fkIo KQogICBiMiA9IDkwMjsKIH0KIAorc3RydWN0IEMgOiBwdWJsaWMgQgorewor ICBBICpjMTsKKyAgQSAqYzI7Cit9OworCiAvLyBTdG9wIHRoZSBjb21waWxl ciBmcm9tIG9wdGltaXppbmcgYXdheSBkYXRhLgogdm9pZCByZWZlciAoQSAq KQogewpAQCAtNTcsMTYgKzYzLDE5IEBAIHZvaWQgcmVmZXIgKGVtcHR5ICop CiAKIGludCBtYWluICh2b2lkKQogewotICBBIGFscGhhLCAqYWFwLCAqYWJw OworICBBIGFscGhhLCAqYWFwLCAqYWJwLCAqYWNwOwogICBCIGJldGEsICpi YnA7CisgIEMgZ2FtbWE7CiAgIGVtcHR5IGU7CiAKICAgYWxwaGEuYTEgPSAx MDA7CiAgIGJldGEuYTEgPSAyMDA7IGJldGEuYjEgPSAyMDE7IGJldGEuYjIg PSAyMDI7CisgIGdhbW1hLmMxID0gMDsgZ2FtbWEuYzIgPSAoQSAqKSB+MFVM OwogCiAgIGFhcCA9ICZhbHBoYTsgcmVmZXIgKGFhcCk7CiAgIGFicCA9ICZi ZXRhOyAgcmVmZXIgKGFicCk7CiAgIGJicCA9ICZiZXRhOyAgcmVmZXIgKGJi cCk7CisgIGFjcCA9ICZnYW1tYTsgcmVmZXIgKGFjcCk7CiAgIHJlZmVyICgm ZSk7CiAKICAgcmV0dXJuIDA7ICAvLyBtYXJrZXIgcmV0dXJuIDAKSW5kZXg6 IGdkYi90ZXN0c3VpdGUvZ2RiLmNwL2NsYXNzMi5leHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi90ZXN0c3Vp dGUvZ2RiLmNwL2NsYXNzMi5leHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu NgpkaWZmIC11IC1wIC11IC1yMS42IGNsYXNzMi5leHAKLS0tIGdkYi90ZXN0 c3VpdGUvZ2RiLmNwL2NsYXNzMi5leHAJMSBKYW4gMjAwOCAyMjo1MzoxOSAt MDAwMAkxLjYKKysrIGdkYi90ZXN0c3VpdGUvZ2RiLmNwL2NsYXNzMi5leHAJ MTQgSnVsIDIwMDggMTg6MDE6MTkgLTAwMDAKQEAgLTExNywzICsxMTcsMTAg QEAgZ2RiX3Rlc3QgInByaW50ICogKEIgKikgYWJwIiBcCiAjIFByaW50aW5n IHRoZSB2YWx1ZSBvZiBhbiBvYmplY3QgY29udGFpbmluZyBubyBkYXRhIGZp ZWxkczoKIAogZ2RiX3Rlc3QgInAgZSIgIj0gXHs8Tm8gZGF0YSBmaWVsZHM+ XH0iICJwcmludCBvYmplY3Qgd2l0aCBubyBkYXRhIGZpZWxkcyIKKworIyBQ cmludGluZyBOVUxMIHBvaW50ZXJzIHdpdGggInNldCBwcmludCBvYmplY3Qg b24iCisKK2dkYl90ZXN0ICJzZXQgcHJpbnQgb2JqZWN0IG9uIiAiIgorZ2Ri X3Rlc3QgInAgYWNwIiAiPSBcXChDIFxcKlxcKSAweFxbYS1mMC05XF0rIgor Z2RiX3Rlc3QgInAgYWNwLT5jMSIgIlxcKEEgXFwqXFwpIDB4MCIKK2dkYl90 ZXN0ICJwIGFjcC0+YzIiICJcXChBIFxcKlxcKSAweGYrIgo= ------=_Part_68095_7784663.1216059119602--