From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22308 invoked by alias); 6 Jun 2008 00:52:36 -0000 Received: (qmail 22289 invoked by uid 22791); 6 Jun 2008 00:52:35 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Jun 2008 00:52:10 +0000 Received: from spaceape11.eur.corp.google.com (spaceape11.eur.corp.google.com [172.28.16.145]) by smtp-out.google.com with ESMTP id m560q4ML015752 for ; Fri, 6 Jun 2008 01:52:04 +0100 Received: from yw-out-1718.google.com (ywa6.prod.google.com [10.192.1.6]) by spaceape11.eur.corp.google.com with ESMTP id m560q3mt006492 for ; Fri, 6 Jun 2008 01:52:03 +0100 Received: by yw-out-1718.google.com with SMTP id 6so457212ywa.76 for ; Thu, 05 Jun 2008 17:52:03 -0700 (PDT) Received: by 10.151.156.1 with SMTP id i1mr2666503ybo.117.1212713523001; Thu, 05 Jun 2008 17:52:03 -0700 (PDT) Received: by 10.151.109.14 with HTTP; Thu, 5 Jun 2008 17:52:02 -0700 (PDT) Message-ID: <8ac60eac0806051752j5f15aa72r9574cfbc55f4ae98@mail.gmail.com> Date: Fri, 06 Jun 2008 00:52:00 -0000 From: "Paul Pluzhnikov" To: "Paul Pluzhnikov" , gdb-patches@sourceware.org, "Doug Evans" Subject: Re: [RFA] Patch for incorrect handling of references to pointers [pr1147] In-Reply-To: <20080605203748.GA3818@caradoc.them.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_4185_30349910.1212713523009" References: <8ac60eac0805081418md64f7bcha08664e9554e5750@mail.gmail.com> <20080605203748.GA3818@caradoc.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00089.txt.bz2 ------=_Part_4185_30349910.1212713523009 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 671 On Thu, Jun 5, 2008 at 1:37 PM, Daniel Jacobowitz wrote: > This is an unsafe use of send_gdb, because the gdb_expect might match > only the first of three expected prompts depending when there is a > pause in the output. Thanks, I believe to have fixed all the problems. New patch attached. -- Paul Pluzhnikov ChangeLog: 2008-06-05 Paul Pluzhnikov PR gdb/1147 * gdb/valopts.c (find_overload_match): Handle references to pointers. testsuite/ChangeLog: 2008-06-05 Paul Pluzhnikov * gdb.cp/call-c.exp: Test for incorrect handling of reference to pointer. * gdb.cp/call-c.cc: Likewise. ------=_Part_4185_30349910.1212713523009 Content-Type: text/plain; name=gdb-patch-1147-20080605.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fh4255je0 Content-Disposition: attachment; filename=gdb-patch-1147-20080605.txt Content-length: 2294 Q2hhbmdlTG9nOgoKMjAwOC0wNi0wNSAgUGF1bCBQbHV6aG5pa292ICA8cHBs dXpobmlrb3ZAZ29vZ2xlLmNvbT4KCglQUiBnZGIvMTE0NwoJKiBnZGIvdmFs b3B0cy5jIChmaW5kX292ZXJsb2FkX21hdGNoKTogSGFuZGxlIHJlZmVyZW5j ZXMKCXRvIHBvaW50ZXJzLgoKdGVzdHN1aXRlL0NoYW5nZUxvZzoKCjIwMDgt MDYtMDUgIFBhdWwgUGx1emhuaWtvdiAgPHBwbHV6aG5pa292QGdvb2dsZS5j b20+CgoJKiBnZGIuY3AvY2FsbC1jLmV4cDogVGVzdCBmb3IgaW5jb3JyZWN0 IGhhbmRsaW5nIG9mIHJlZmVyZW5jZQoJdG8gcG9pbnRlci4KCSogZ2RiLmNw L2NhbGwtYy5jYzogTGlrZXdpc2UuCgotLS0gZ2RiL3ZhbG9wcy5jLm9yaWcJ MjAwOC0wNi0wNSAxMzo1MzoyNC4wMDAwMDAwMDAgLTA3MDAKKysrIGdkYi92 YWxvcHMuYwkyMDA4LTA2LTA1IDEzOjU0OjAzLjE0MzQ2ODAwMCAtMDcwMApA QCAtMTk3Miw3ICsxOTcyLDggQEAgZmluZF9vdmVybG9hZF9tYXRjaCAoc3Ry dWN0IHR5cGUgKiphcmdfdAogICBpZiAob2JqcCkKICAgICB7CiAgICAgICBp ZiAoVFlQRV9DT0RFICh2YWx1ZV90eXBlICh0ZW1wKSkgIT0gVFlQRV9DT0RF X1BUUgotCSAgJiYgVFlQRV9DT0RFICh2YWx1ZV90eXBlICgqb2JqcCkpID09 IFRZUEVfQ09ERV9QVFIpCisJICAmJiAoVFlQRV9DT0RFICh2YWx1ZV90eXBl ICgqb2JqcCkpID09IFRZUEVfQ09ERV9QVFIKKwkgICAgICB8fCBUWVBFX0NP REUgKHZhbHVlX3R5cGUgKCpvYmpwKSkgPT0gVFlQRV9DT0RFX1JFRikpCiAJ ewogCSAgdGVtcCA9IHZhbHVlX2FkZHIgKHRlbXApOwogCX0KLS0tIGdkYi90 ZXN0c3VpdGUvZ2RiLmNwL2NhbGwtYy5jYy5vcmlnCTIwMDgtMDUtMDggMTQ6 MDE6NTcuMDAwMDAwMDAwIC0wNzAwCisrKyBnZGIvdGVzdHN1aXRlL2dkYi5j cC9jYWxsLWMuY2MJMjAwOC0wNi0wNSAxNzozMDowOS4wMDk4OTAwMDAgLTA3 MDAKQEAgLTIxLDcgKzIxLDE4IEBAIGludCBmdW5jKGludCB4KQogICAgcmV0 dXJuIHg7CiB9CiAKK3N0cnVjdCBGb28geworICBGb28oKSA6IHhfKDEpIHsg fQorICBpbnQgZnVuYygpIGNvbnN0IHsgcmV0dXJuIHhfOyB9CisgcHJpdmF0 ZToKKyAgaW50IHhfOworfTsKKwogaW50IG1haW4oKQogeworICAgIEZvbyBm OworICAgIEZvbyAqcGYgPSAmZjsKKyAgICBGb28qICZyZiA9IHBmOworICAg IHJmLT5mdW5jKCk7IC8qIHNldCBicmVha3BvaW50IGhlcmUgKi8KICAgICBy ZXR1cm4gZnVuYygwKTsKIH0KLS0tIGdkYi90ZXN0c3VpdGUvZ2RiLmNwL2Nh bGwtYy5leHAub3JpZwkyMDA4LTA1LTA4IDE0OjAxOjU3LjAwMDAwMDAwMCAt MDcwMAorKysgZ2RiL3Rlc3RzdWl0ZS9nZGIuY3AvY2FsbC1jLmV4cAkyMDA4 LTA2LTA1IDE3OjMxOjE5LjcwMDAyNTAwMCAtMDcwMApAQCAtNDMsNCArNDMs OSBAQCBnZGJfbG9hZCAke2JpbmZpbGV9CiAKIHJ1bnRvX21haW4KIAorZ2Ri X3Rlc3QgImIgW2dkYl9nZXRfbGluZV9udW1iZXIge2JyZWFrcG9pbnQgaGVy ZX0gJHt0ZXN0ZmlsZX0uY2MgXSIgXAorCSAiLipCcmVha3BvaW50IC4qY2Fs bC1jLioiCisKIGdkYl90ZXN0ICJwcmludCBmb28oMSkiICJcXFwkJGRlY2lt YWwgPSAxIgorZ2RiX3Rlc3QgImNvbnRpbnVlIiAiLipicmVha3BvaW50IGhl cmUuKiIgImNvbnRpbnVlIHRvIGJwIgorZ2RiX3Rlc3QgInByaW50IHJmLT5m dW5jKCkiICJcXFwkJGRlY2ltYWwgPSAxIgo= ------=_Part_4185_30349910.1212713523009--