Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Paul Pluzhnikov" <ppluzhnikov@google.com>
To: "Pedro Alves" <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Fix for gdb crash in "info thread" after exec().
Date: Wed, 28 May 2008 17:49:00 -0000	[thread overview]
Message-ID: <8ac60eac0805271625j5a864522x6afb85f234e7c2c8@mail.gmail.com> (raw)
In-Reply-To: <200805272106.16082.pedro@codesourcery.com>

On Tue, May 27, 2008 at 1:06 PM, Pedro Alves <pedro@codesourcery.com> wrote:

> Could you confirm that this hunk of my patch,
>
> Index: src/gdb/linux-thread-db.c
> ===================================================================
> --- src.orig/gdb/linux-thread-db.c      2008-05-06 12:22:31.000000000 +0100
> +++ src/gdb/linux-thread-db.c   2008-05-06 12:53:18.000000000 +0100
> @@ -840,7 +840,7 @@ thread_db_wait (ptid_t ptid, struct targ
>       unpush_target (&thread_db_ops);
>       using_thread_db = 0;
>
> -      return pid_to_ptid (GET_PID (ptid));
> +      return ptid;
>     }
>
>   /* If we do not know about the main thread yet, this would be a good time
> to
>
> ... fixes the issue,

Confirmed.

> and that you were hitting that new_thread_event piece
> in infrun.c:handle_inferior_event while handling a TARGET_WAITKIND_EXECD ?

I am not sure I understand that second question correctly.

The 'ecs->new_thread_event' is set to 0 while handling
TARGET_WAITKIND_EXECD, and add_thread() is not called for it.

> We may need some more interface cleanup to clear the current thread
> list across an exec, if the original process had threads, but I don't
> think your call is in the right place.

Yes, it did feel out of place to me as well.

Thanks,
-- 
Paul Pluzhnikov


  parent reply	other threads:[~2008-05-27 23:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20 22:12 Paul Pluzhnikov
2008-05-28  7:10 ` Paul Pluzhnikov
2008-05-28 15:27   ` Pedro Alves
2008-05-28 17:10     ` Paul Pluzhnikov
2008-05-28 21:25       ` [new patch] " Pedro Alves
2008-05-28 21:34         ` Paul Pluzhnikov
2008-05-28 22:24           ` Pedro Alves
2008-06-05  1:16             ` Paul Pluzhnikov
2008-06-05 17:23               ` Michael Snyder
2008-06-05 20:43                 ` Daniel Jacobowitz
2008-06-05 21:07                   ` Pedro Alves
2008-05-28 17:49     ` Paul Pluzhnikov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-05-13 18:07 Paul Pluzhnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac60eac0805271625j5a864522x6afb85f234e7c2c8@mail.gmail.com \
    --to=ppluzhnikov@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox