Re: [RFC] gdb could leave inferior running as a background process

["Paul Pluzhnikov" <ppluzhnikov@google.com>]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

On Tue, Apr 22, 2008 at 8:55 AM, Daniel Jacobowitz <drow@false.org> wrote:

>  Sorry, don't think this will work reliably.  If the target tried to
>  read after it was resumed but before the call to target_wait, and GDB
>  had the terminal, then it will have a pending SIGTTIN already at this
>  point.

I see.

My preferred way of fixing this was to have warning() restore
terminal to inferior if it wasn't ours when warning was called,
but that's not how the rest of the code is structured.

Would attached patch work better then?

Thanks,
-- 
Paul Pluzhnikov


2008-04-22  Paul Pluzhnikov  <ppluzhnikov@google.com>

     * gdb/target.h (target_resume): Call target_terminal_inferior before
     resuming inferior.

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 584 bytes --]

2008-04-22  Paul Pluzhnikov  <ppluzhnikov@google.com>

     * gdb/target.h (target_resume): Call target_terminal_inferior before
     resuming inferior.

--- ../../../vendor_src/gdb/gdb-6.8.x/gdb/target.h	2008-03-25 09:51:34.779643000 -0700
+++ gdb/target.h	2008-04-22 09:27:16.894610000 -0700
@@ -573,6 +573,7 @@ extern void target_disconnect (char *, i
 #define	target_resume(ptid, step, siggnal)				\
   do {									\
     dcache_invalidate(target_dcache);					\
+    target_terminal_inferior ();					\
     (*current_target.to_resume) (ptid, step, siggnal);			\
   } while (0)