From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Y4S3Epkgq1/UGwAAWB0awg (envelope-from ) for ; Tue, 10 Nov 2020 18:22:01 -0500 Received: by simark.ca (Postfix, from userid 112) id 3FF661F08B; Tue, 10 Nov 2020 18:22:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7229F1E58D for ; Tue, 10 Nov 2020 18:22:00 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 310573851C2B; Tue, 10 Nov 2020 23:22:00 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A29813851C2B for ; Tue, 10 Nov 2020 23:21:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A29813851C2B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 459361E58D; Tue, 10 Nov 2020 18:21:57 -0500 (EST) Subject: Re: RFA: Add support for DWARF-based fixed point types To: Joel Brobecker , gdb-patches@sourceware.org References: <1604817017-25807-1-git-send-email-brobecker@adacore.com> From: Simon Marchi Message-ID: <8ab4e727-51f8-1652-a143-424079ad4ae1@simark.ca> Date: Tue, 10 Nov 2020 18:21:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1604817017-25807-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-08 1:30 a.m., Joel Brobecker wrote: > Hello, > > This patch series adds support for fixed point types described > using a pure DWARF approach. While the main trigger was the desire > to deprecate the GNAT encodings used in the case of Ada fixed point > types, the implementation is done in a way that support is generic. > Other languages which have support for such kinds of types should > have little work to do to support them as well. > > The implementation is based on top of GMP: We use GMP to store and > operate on rational values, with the added bonus that there is no > size limit on either the numerator nor denominator. As discussed > previously, the dependency on GMP is made mandatory > (https://sourceware.org/pipermail/gdb-patches/2018-March/147373.html). > > One part that this patch series does not include is function calls > and returns. Since those changes are all arch-specific, I will > submit them in a separate series of its own, to avoid those other > patches getting lost in this patch series. > > Each patch of this series has been tested on x86_64-linux using > our testsuite. In addition, these changes have been tested using > AdaCore's testing, on numerous architectures and OSes. > > Looking forward to everyone's feedback! Hi Joel, I gave some comments that are more on the coding style side of things, since I am that that familiar with fixed point types. In general it seemed to make sense. I'm fine with you merging this series, addressing the comments as you see fit. Simon