Re: [PATCH][gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp

Simon Marchi
2020-02-17T20:52:08Z

On 2020-02-13 10:02 a.m., Tom de Vries wrote:
> On 13-02-2020 15:32, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> 2020-02-13 Tom de Vries <tdevries@suse.de>
>>
>> Tom> * gdb.base/gdb-caching-proc.exp (ignore_pass, ignore_fail)
>> Tom> (ignore_unsupported): New proc.
>> Tom> (test_proc): Temporarily rename pass/fail/ignore to
>> Tom> ignore_{pass,fail,ignore} in order to ignore PASS/FAIL/IGNORE messages
>> Tom> from the tested procs.
>>
>> Can we just require that caching proc bodies not invoke tests?
>>
>
> We could, I don't have preference one way or the other.
>
> If I remove all the fail calls from gnat_runtime_has_debug_info, we
> still get these PASSes from gdb_compile_ada:
> ...
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: compilation gnat_debug_info_test.adb
> PASS: gdb.base/gdb-caching-proc.exp: gnat_runtime_has_debug_info consistency
> ...
>
> But we can factor that out, I've already done that once here (
> https://sourceware.org/ml/gdb-patches/2019-10/msg01109.html ).
>
> Simon, WDYT?
>
> Thanks,
> - Tom
>

If you can indeed do that, I think it would be best.

Simon