Re: [PATCH][gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp

Tom Tromey
2020-02-13T14:32:38Z

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> 2020-02-13 Tom de Vries <tdevries@suse.de>

Tom> * gdb.base/gdb-caching-proc.exp (ignore_pass, ignore_fail)
Tom> (ignore_unsupported): New proc.
Tom> (test_proc): Temporarily rename pass/fail/ignore to
Tom> ignore_{pass,fail,ignore} in order to ignore PASS/FAIL/IGNORE messages
Tom> from the tested procs.

Can we just require that caching proc bodies not invoke tests?

Tom> + rename pass save_pass
Tom> + rename fail save_fail
Tom> + rename unsupported save_unsupported
Tom> + rename ignore_pass pass
Tom> + rename ignore_fail fail
Tom> + rename ignore_unsupported unsupported

In this situation perhaps it's best to catch any errors in the body, so
that the code to rename things back will always be run.

Then it could re-throw the error if needed at the end.

Tom