From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yeM4EaJfqGmDQBQAWB0awg (envelope-from ) for ; Wed, 04 Mar 2026 11:36:50 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=C2Xb5Aa8; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=C2Xb5Aa8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3FDF11E089; Wed, 04 Mar 2026 11:36:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0B3A41E089 for ; Wed, 04 Mar 2026 11:36:49 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8C51B4BA23E1 for ; Wed, 4 Mar 2026 16:36:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C51B4BA23E1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=C2Xb5Aa8; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=C2Xb5Aa8 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010030.outbound.protection.outlook.com [52.101.69.30]) by sourceware.org (Postfix) with ESMTPS id 820934BA2E12 for ; Wed, 4 Mar 2026 16:32:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 820934BA2E12 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 820934BA2E12 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.69.30 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1772641923; cv=pass; b=bX5JUi+zwZxuxYc60Z5Lxe3vbtM/I5UB5zQUfdQ38Yel+pcXZh1CXwaciUnmWCbbmXmYH9DrHIjIsIBGxWvDc8Aw+onrsgjOCya5ms6iLnZrQA7hKlaUKa3MkHTNERYsqk7Ev3KdDF0pSQKvr+M6Oe3IMLJfsM7pW8FijHXlUOo= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1772641923; c=relaxed/simple; bh=NZsfEwozHRWeAfb292+rF6r9TyZWpN0bS/dE+Zcg4vg=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=KakapY1X5rsaasSCurmncGne/IivNUWBYxGNlXJL2fmNEtgvfXq5ixx1g9HVleGJHJ1ACtqLRhkw8oOlLkbhbVX2X+IfrV6syaHvCUz9JwRaIvUzac3zJW0bjsaLGFW3xIR+Kf1xbKE04TdAiAu0m9b5PVdbRnPQiwGwuTg4e+c= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 820934BA2E12 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=Lmm5vO5aFBSM2X2HrMm5idU4HWBofLXl5xaznZQfXO7K91MJymsIrx4LJap+RVtZL//5Vvw4fkhDYLKpglFhpEpnu7UpT8D0a5l+fAKMou78DgMta77C7NOLyTsp3yX6rg3RPUjtSxi/QETjGPwEO5EIcLNqxGoa+HiwHpMRVU8b3juStxtZEzsC4YrnJHRfKTOEHEatRtRjD9JiHGF19YQto6w47AA1oYsIyAtbTBYzGWvuElYGwB4GJvtFZj+P1hmAXreK3stfHOlNRQ8zy+DEr9W01MLAahg70BFXas4McTyQmGy52ulPinh72GEkgWxijgdGQb1AOftEg1/8TA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5LEDKRhxo/RoDq4NM5UVW5RCbNXfNfHT6XxWlrj9Yeg=; b=ZA0em2vO26+n5iJqBIORtI0B8w7jOGBSqS4vMYSOCf/v3jefK0TiZkA2QqP+l4umij4gGdqcj77D3U72NmqLMFLbuACN2Lyyve2FHDV+SS4CO5g8Lh1Ne7OFcwtPGcUh8TL+X/PdwxZUUT7C2UDB3MZ8BtBy98xAuP1pCR+/dgCCg/38AzdTZl2W7bm11JUGBM05CZkvasFbU1ZNhQtrubPovUYOOYFqMMTTeSXjRL/6k+U1SE3YHYNTYHzQtSMqeNKk535qLrBjeQ5juDhPRWiQk8vAToEP8M9TpGdQZx3qkgP+zXm12D2pXWy8+ezTziGAvBAWXChz1kRarN7E5Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=tromey.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5LEDKRhxo/RoDq4NM5UVW5RCbNXfNfHT6XxWlrj9Yeg=; b=C2Xb5Aa8Il9Am9xc0p3d1pYYQB4kGZtNHJ4KSYMEfWMpMhDCHeFuAfhikPtXLeY4UDNvUuYvI5+KH4maxkUQjlKzbTJ5AvoDoCFHRirSbHf0i4q7oP4WN+5X0lRXigFnBfpsjP6MKWM/qglo/xc3UM5zdLxNOD/Sjl8N7VB/KZ4= Received: from DB8P191CA0012.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::22) by DBBPR08MB6154.eurprd08.prod.outlook.com (2603:10a6:10:1f4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.17; Wed, 4 Mar 2026 16:31:57 +0000 Received: from DB5PEPF00014B92.eurprd02.prod.outlook.com (2603:10a6:10:130:cafe::1a) by DB8P191CA0012.outlook.office365.com (2603:10a6:10:130::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.22 via Frontend Transport; Wed, 4 Mar 2026 16:31:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB5PEPF00014B92.mail.protection.outlook.com (10.167.8.230) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Wed, 4 Mar 2026 16:31:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dk1719B4SEENhd2HktOQtGMM7xNc6uniTycwIuL0zyXqI8B7klef1k2pfH8lbyel7m6IWHk0sMrQgZF2/PIIJVBfUtqdHB+4Rpx5ZvjpCbFEOb8q1qFEltxUDMARu4MOqBYu6+WYzk29RPyRbF3g6uCN6YSDWHT8LDC2wDESFtGccXMKgqjibdlSlHTzic/Xe2LlvujLvxCONRybQ6ElrX/JyuewLopoOxDPUJBtdlo2tnozDUfTyn0katp/e5xHLd7pCJNTxhadSpb7Nr1aqP+zoYi81qZCWYBHTLWvkdmoekqql2E5/KldlHcA1BnUt2MBYuGH7q53fk+wvGavxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5LEDKRhxo/RoDq4NM5UVW5RCbNXfNfHT6XxWlrj9Yeg=; b=SInDzQKNGFP3gJa1zld1mL5SsnlMQWXwcOsMLjuafZqZ9t9k3LsLjjwx2LfXIGV8u8B1cgglpSilv43ZVWgsk/iosSv34Z6b6hXUjMiQxFUJtcrRP65oL2qPfAPmwihm3HbWLvbDJS3UFNKFxEQDzdSNyZLJ9GykR7phvdZkSnbzXEp9wBeDWNHPFabxGN/bSspi+5S3o4y+7JwYxvcXq8lplVxuFbKEZrzeBs8ESbwm7b8PrMA4e4XUrD2u3wt5G27mxqlo0j+9jOUBBFwIlgxyN+hlnIUueIdxBzQeOggiOA/qv+cUUAMCv+RBwiN0kIi4jUPU38kYYEwdoOlMrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5LEDKRhxo/RoDq4NM5UVW5RCbNXfNfHT6XxWlrj9Yeg=; b=C2Xb5Aa8Il9Am9xc0p3d1pYYQB4kGZtNHJ4KSYMEfWMpMhDCHeFuAfhikPtXLeY4UDNvUuYvI5+KH4maxkUQjlKzbTJ5AvoDoCFHRirSbHf0i4q7oP4WN+5X0lRXigFnBfpsjP6MKWM/qglo/xc3UM5zdLxNOD/Sjl8N7VB/KZ4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB3PR08MB9010.eurprd08.prod.outlook.com (2603:10a6:10:42b::8) by AMDPR08MB11650.eurprd08.prod.outlook.com (2603:10a6:20b:73b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Wed, 4 Mar 2026 16:30:55 +0000 Received: from DB3PR08MB9010.eurprd08.prod.outlook.com ([fe80::f37c:c9c2:6d9a:9543]) by DB3PR08MB9010.eurprd08.prod.outlook.com ([fe80::f37c:c9c2:6d9a:9543%5]) with mapi id 15.20.9654.022; Wed, 4 Mar 2026 16:30:55 +0000 Message-ID: <8a9cd094-eb92-4b92-a0a8-5e556e412e67@arm.com> Date: Wed, 4 Mar 2026 16:30:54 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/9] gdb: introduce rgb_color type to simplify existing code To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260303161659.397427-1-matthieu.longo@arm.com> <20260303161659.397427-3-matthieu.longo@arm.com> <87342gsrrh.fsf@tromey.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <87342gsrrh.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0256.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:375::10) To DB3PR08MB9010.eurprd08.prod.outlook.com (2603:10a6:10:42b::8) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB3PR08MB9010:EE_|AMDPR08MB11650:EE_|DB5PEPF00014B92:EE_|DBBPR08MB6154:EE_ X-MS-Office365-Filtering-Correlation-Id: a49ab251-2dd9-46f6-defd-08de7a0b8dd9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info-Original: L+j29UrRLtf6Kx2L3dPIqo+CFoMnPeEKWZ1KY/21vKi7C6T20rY+nXH2dIpP/WAFSM1YHeKlOGLgOT4rv2XDwcGns0z2Qs4Rj+tXa/yX6kxhkYN2nVl0oKVMM76vukOm388bS5QwnWCMEgFD9quUomeKOC2lZ0EuMTqg08v5xky/aq9gUTwopm7vSJKZ+105qZP68q8P5i8MJ/1ySkUtSlg+c5oegQzv8gaA2QjBF1Fr8JuxWUY+ge13TLdZjq2X8OPqFEDmNM6IqD6VvyPixPs4y9O+uE5X6ziU+fFaOvDKyQXPtnUYoberTgSHVnraKIGYzrXFdreRqL3uFMe31r5BmYTFAX3HbT7KXEPX0Biv5jAJbQn7VSQ7EqRJKREmmFJzCu0Sxo7H60C8yRTWtYvGjsZRbKW6nXMqEO6aHMO286D9UPLUJf2Cs0QGeA3qdelCEf2iydyB93Z/ltSHLxrAc9g8Y+OW4sjdmNsAuidXvWMzzA29xxjpVv5EErSnSEmQosNv4E6mdxGK5KineOljvfE40aiDMS5kKZK6FPFoH7LjUcyWBChZHsZ2FRdXhWZp/26+yNREMoLdjswIKLwKYqEr7CDYIJZQpYel4jQ2C84ukseoD8RUnHjbfcoUOzc9vCsP+Fu5mNq+FPqJj2j7zZ7kusGmkI+gLxem5/+GixmvLvEfREFSKbS7suqGO08Y9dTEqe7F+y5Ro5JQUK4ZNAwgRsRT0geXH3jYgkA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR08MB9010.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMDPR08MB11650 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B92.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8adde430-d8f6-423d-df44-08de7a0b68b8 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|35042699022|14060799003|82310400026|36860700016; X-Microsoft-Antispam-Message-Info: aXv64m3Jw1pXyaMLS903Ol7SXyzd+jQpOM+tvGibV1WQjf+te+kAMGSfHCalb5quuNbWm3Y5ja5QdJXINmfYUBwWqZf0Dn13Mxbw2+7pbhMtUAwJ92p0hb99GCy/GuAbvYhtysPn9gEyOetcsKVcYyy9OB1ar0WcpqGFKKSuZ1bAAIX/33HAeXWkWN8LZHlC9dQZQR619YMuUbUfH3BNB2BSZR1+emeb/dGzGahOqyM5QAW2cX0LSPUcln5yhWVJ4PR92kV1y7VIJ6UTMThH9+CraTzglPgP9bF8hpdBiHc2v1BuW9/4X+qsaPscaUsmAKPyOgewi+V6voEZMvA5TIXuEI4DZXTa8RvJ/w8GyIzIC5ei2oAHs8Z7Wqj8Sun61xCUdVPTDAsaCwHAp+iDDs7ceXpfKkh4i/Px2xrrD4uGj46PlQXtmlHMu8K6vxK+GCZYaHED3uZHU1XMLgWkpaX515KPAuxtLryv8URvwwsQTtcubRZk/jb+s6kn2edSjZIKsQGhNObh2ZzaulTdRI71V5NErX9EU0Y512/G9G+aV+Irq0NHbOvRA5exkZcSvs5B/oEGZDu8dKYVa4WwNh65qI9o5BBmtaAzgLYXvFrBH3zvzmydtfo2HxI8Db1cRl36MeQpj989xkX30d0HL7JPP1PjxDMhJopck37KRCxm/Nb/MZ+tTXjJDUIzNIHTH56sUfDZvxoI+wx00r9zmL+tiqwarKXrc80dnvG3e8I4uj89aMJ7vfiBWyD23BYrawl4J1hTVc16fnODI76ufQ== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(1800799024)(35042699022)(14060799003)(82310400026)(36860700016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8PO5uiHeigkHsDtFo2wxoKkDfc5hIPof3lrtBXFg3yIDw6HwzH1NRJh9qR2fT1XtDavdeSZ6EVVFhvwSVG8ztEMsllD4zosRLKIntxDa1rP0EAIYYLBT2KmJHjVfcb5XTNBZkDeuN2bqgpu7bFfLNMSmt/27LiZjQnkkwgo2MlNVj8ArtW6I3ZLNVR61vD8cQd0EmKFAEsagcSxHmav+wNkSKyUsLanUaUCf4lD0MZK1cTvpfYaxt4HEyewL54NI5Kj4YNb42pDiPtlTy2B3fKBGQB425QKXCU/hNsgUFefDQ/VMftgATScWwgyOD5JqAnUhzT3UNEntR8IzhlvcYXcZGqfi5ZxVBJqVUil5OLGbvj3iIAq8Kkeibt8B/l6hxAxie/O57U75Fl3FfhdVcbaRhEXBL+GiCuoEU0rpRIiesAjwxH3dZm8h9OYzyc1c X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2026 16:31:57.5827 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a49ab251-2dd9-46f6-defd-08de7a0b8dd9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B92.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6154 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 03/03/2026 18:16, Tom Tromey wrote: >>>>>> Matthieu Longo writes: > >> This patch replaces the raw uint8[3] buffer used to represent RGB values >> with a more convenient wrapper, rgb_color, around std::array. >> It also changes the return type of ui_file_style::color::get_rgb to >> rgb_color instead of filling a caller-provided buffer, and updates all >> callers accordingly. > > Nice, thanks. > >> else if (m_color_space == color_space::ANSI_8COLOR >> && 0 <= m_value && m_value <= 7) >> - memcpy (rgb, palette_8colors[m_value], 3 * sizeof (uint8_t)); >> + memcpy (rgb, palette_8colors[m_value], rgb.size_bytes ()); >> else if (m_color_space == color_space::AIXTERM_16COLOR >> && 0 <= m_value && m_value <= 15) >> - memcpy (rgb, palette_16colors[m_value], 3 * sizeof (uint8_t)); >> + memcpy (rgb, palette_16colors[m_value], rgb.size_bytes ()); >> else if (m_color_space != color_space::XTERM_256COLOR) >> gdb_assert_not_reached ("get_rgb called on invalid color"); >> else if (0 <= m_value && m_value <= 15) >> - memcpy (rgb, palette_16colors[m_value], 3 * sizeof (uint8_t)); >> + memcpy (rgb, palette_16colors[m_value], rgb.size_bytes ()); > > I wonder if the types of palette_8colors and palette_16colors should > change as well. Then it seems the memcpy could be an assignment. > Yes, it makes sense. I hadn't looked too much at the code using it. Ok, I will fix this in the new revision. >> diff --git a/gdb/ui-style.h b/gdb/ui-style.h >> index fca9150889b..72349256034 100644 >> --- a/gdb/ui-style.h >> +++ b/gdb/ui-style.h >> @@ -54,6 +54,34 @@ extern bool color_space_safe_cast (color_space *result, long c); >> /* Get the number of colors supported by the terminal where GDB is running. */ >> extern int gdb_get_ncolors (); > >> +struct rgb_color >> +{ > > Usually in gdb we add a comment before a struct definition that explains > what it is about. > /* Convenient wrapper for RGB color values. */ ? >> + constexpr const uint8_t& operator[](std::size_t idx) const noexcept >> + { return m_data[idx]; } > > The "&" should come after the space here. > Also a space between "[]" and "()". > Fixed. >> + color (const rgb_color &rgb) >> + : m_color_space (color_space::RGB_24BIT), >> + m_red (rgb.r ()), >> + m_green (rgb.g ()), >> + m_blue (rgb.b ()) >> + { >> + } > > Probably this constructor should be 'explicit'. That's the norm in gdb > unless there's a real need for an implicit conversion. Fixed. > > thanks, > Tom Matthieu