From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WsGFLVmMm2cIbx8AWB0awg (envelope-from ) for ; Thu, 30 Jan 2025 09:27:37 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SXAwRYKZ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pahvk90X; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SXAwRYKZ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pahvk90X; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A49691E105; Thu, 30 Jan 2025 09:27:37 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B167A1E08E for ; Thu, 30 Jan 2025 09:27:36 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3F6393857B9E for ; Thu, 30 Jan 2025 14:27:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3F6393857B9E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SXAwRYKZ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pahvk90X; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SXAwRYKZ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pahvk90X Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id AFDBD3858C56 for ; Thu, 30 Jan 2025 14:26:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFDBD3858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFDBD3858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738247207; cv=none; b=MYFA3aIue5OMgBSgedQo3so8FPOiVZ1Tkgs63obMZ31C4E0qq/LHW3oDFsQi+vhulS+IPnkCKaw7sCcQuhwcxyIFTulJD1Ig188vJzUc9NdXMpR3NCkVKILJhu3GgqP4jXaaa43DpBRXIDZHZ4WZG0y0ZJlwOH/bZVAo9pvrrAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738247207; c=relaxed/simple; bh=T4oYdzzzmWQUxgTXUPsYJ+3IX9p3BjZlmjChl2Rhfrk=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=BbRpMDvzyevQ/NFyXxfLTswTYlPTRcnMVyTJNL/gTT+zgamqGv1oszfYUdq2Fd/fCRXYfCluXRo+/bGXWNys7Xhi/uyqFOx5U+4g5xoCEQhpUv8qqz33Ip2kFZZJG/fKrZVXqwW7U53ZWB9VOgAWgJeXHy0P1CFIun+ZqH7HN0M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFDBD3858C56 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A332D1F383; Thu, 30 Jan 2025 14:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738247206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0mwyJdiSF687cJWXLSOSCXvXHAQuPQU/d58Yv29A1ik=; b=SXAwRYKZjV4MY2ou/TlUpsQYxDAXv+kc/tJpOsCTE2zJWnAwzOdocg2eoh57N/MXZYtgVF eaIzP942cOHlNxJ0UxvtdnU8EPxYq2ZRmWQcWw95LgLAp69NGEoSfl9I0GGq0Pbsn9Ub1S cYmtBGRbB8hG8oGtgFqBHBMLt4jWIzA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738247206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0mwyJdiSF687cJWXLSOSCXvXHAQuPQU/d58Yv29A1ik=; b=pahvk90X3e7JCAnRb4Ne5o+mOadKZMQxCn5UVLMhcWALsrDgGzqIj66l2Y5YotNuzTG3Cv UE4xO1g8937cMjCg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1738247206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0mwyJdiSF687cJWXLSOSCXvXHAQuPQU/d58Yv29A1ik=; b=SXAwRYKZjV4MY2ou/TlUpsQYxDAXv+kc/tJpOsCTE2zJWnAwzOdocg2eoh57N/MXZYtgVF eaIzP942cOHlNxJ0UxvtdnU8EPxYq2ZRmWQcWw95LgLAp69NGEoSfl9I0GGq0Pbsn9Ub1S cYmtBGRbB8hG8oGtgFqBHBMLt4jWIzA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1738247206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0mwyJdiSF687cJWXLSOSCXvXHAQuPQU/d58Yv29A1ik=; b=pahvk90X3e7JCAnRb4Ne5o+mOadKZMQxCn5UVLMhcWALsrDgGzqIj66l2Y5YotNuzTG3Cv UE4xO1g8937cMjCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 810E61364B; Thu, 30 Jan 2025 14:26:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZkPdHSaMm2dIcwAAD6G6ig (envelope-from ); Thu, 30 Jan 2025 14:26:46 +0000 Message-ID: <8a8fd46c-045d-49a8-a6a8-f9f9f4aa49eb@suse.de> Date: Thu, 30 Jan 2025 15:27:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/12] gdb, testsuite: Rename set_sanitizer_default to append_environment. To: "Schimpe, Christina" , Guinevere Larsen , "gdb-patches@sourceware.org" References: <20241220200501.324191-1-christina.schimpe@intel.com> <20241220200501.324191-2-christina.schimpe@intel.com> <798ec44e-0dc5-4dff-a26f-c8b331b981f6@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email, suse.de:mid, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/30/25 14:07, Schimpe, Christina wrote: >> -----Original Message----- >> From: Guinevere Larsen >> Sent: Tuesday, January 28, 2025 2:45 PM >> To: Schimpe, Christina ; gdb- >> patches@sourceware.org >> Subject: Re: [PATCH 01/12] gdb, testsuite: Rename set_sanitizer_default to >> append_environment. >> >> On 12/20/24 5:04 PM, Schimpe, Christina wrote: >>> The procedure set_sanitizer_default has been used for the >>> configuration of ASAN specific environment variables. However, it is >>> actually a generic function. Rename it to append_environment so that >>> its purpose is more clear. >> >> I think this is a good change, but in that case we should also rename >> set_sanitizer_1 and set_sanitizer. I think the conversion should be: >> >> set_sanitizer -> append_environment >> set_sanitizer_1 -> append_environment_1 >> set_sanitizer_default -> append_environment_default >> >> Also, I can see that patch 12 (and maybe others) use the append_environment >> call. If the user had already set GLIBC_TUNABLES, the test wouldn't update the >> value if I understand the TCL code correctly. >> Is that the expected outcome? If not, I would suggest the alternative of renaming >> set_sanitizer_1 to append_environment, so that set_sanitizer* can continue to >> work as is, and you can manually set the environment variables in a more obvious >> way. > > Thank you for the feedback. Yes, if the environment variable is already configured we > don't configure it by calling set_sanitizer_default/append_environment_default, in > contrast to set_sanitizer_1. I think set_sanitizer_1 was introduced later, that's why I > probably missed it. > > So I totally agree, we should rename all functions and your suggestion > >> set_sanitizer -> append_environment >> set_sanitizer_1 -> append_environment_1 >> set_sanitizer_default -> append_environment_default > > makes sense to me. > > This patch is actually independent of this series and wonder if I could post it separately, as I expect to merge it sooner then. > I am adding Tom to this conversation who introduced these procedures. Does the renaming as suggested above make sense to you? > Hi Christina, yes, the renaming is fine. I think it's not a bad idea to post this independently. Thanks, - Tom > Thanks! > Christina > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928