From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OaMBNEYGQGBVYgAAWB0awg (envelope-from ) for ; Wed, 03 Mar 2021 16:57:26 -0500 Received: by simark.ca (Postfix, from userid 112) id C5CAB1EF78; Wed, 3 Mar 2021 16:57:26 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 14F921E54D for ; Wed, 3 Mar 2021 16:57:26 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D297F3857832; Wed, 3 Mar 2021 21:57:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D297F3857832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614808644; bh=XdaQcBWctfdMXtCqKLX0fm8rcX2+DzioD+V8nmaRsLE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=hkbpmDuzHIUsCOBEqNehffStiRM9dBltAc75af19gbXWmXzHifeDEeJejN49nDqXN iT8xSI55Ng6JtHYc2InoYGO2+yQ0ELJzwDpJ3D9WAvkjkDwW6KToWhgtqzTFe/4ZQP 1E33igxr8O46Iizb47D1Ek5RJSd//C4L8PkAGt/0= Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by sourceware.org (Postfix) with ESMTPS id AE7FB3857832 for ; Wed, 3 Mar 2021 21:57:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AE7FB3857832 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 123LrvBF001226; Wed, 3 Mar 2021 21:57:20 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 371hhc6fe0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Mar 2021 21:57:20 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 123Lucnd189477; Wed, 3 Mar 2021 21:57:19 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 36yyuu1a2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Mar 2021 21:57:19 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 123LvIIf010472; Wed, 3 Mar 2021 21:57:18 GMT Received: from [10.159.251.190] (/10.159.251.190) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 03 Mar 2021 13:57:18 -0800 Subject: Re: [PATCH,V2 1/5] CTF: fix incorrect function return type To: Tom Tromey , Weimin Pan via Gdb-patches References: <1614650018-9135-1-git-send-email-weimin.pan@oracle.com> <1614650018-9135-2-git-send-email-weimin.pan@oracle.com> <87mtvkynvh.fsf@tromey.com> Message-ID: <8a68f477-6ba3-f081-e89b-626f7b48a248@oracle.com> Date: Wed, 3 Mar 2021 13:57:17 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <87mtvkynvh.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103030155 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1011 malwarescore=0 mlxlogscore=999 spamscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103030155 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Wei-min Pan via Gdb-patches Reply-To: Wei-min Pan Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 3/3/2021 12:37 PM, Tom Tromey wrote: >>>>>> ">" == Weimin Pan via Gdb-patches writes: >>> +2021-02-26 Weimin Pan >>> + >>> + * ctfread.c (new_symbol): Set function address. >>> + (read_func_kind_type): Remove incorrect type name setting. > Thanks, this looks good. This is in response to your comment from the original series. >>> - type->set_name (obstack_strdup (&of->objfile_obstack, name.get ())); > It looks like libctf strdup()s the name. If it returned a pointer to > the debuginfo section, you could just use that pointer without copying. > > Otherwise, objfile::intern de-dups names. Sometimes this is worthwhile. Given that line of code is deleted, it causes no harm. But will keep your comment in mind. Thanks. > > Tom