From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OWk0NldKiWDYIwAAWB0awg (envelope-from ) for ; Wed, 28 Apr 2021 07:43:19 -0400 Received: by simark.ca (Postfix, from userid 112) id D00B91F11C; Wed, 28 Apr 2021 07:43:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D1B471E01F for ; Wed, 28 Apr 2021 07:43:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A9203939C33; Wed, 28 Apr 2021 11:43:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A9203939C33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619610198; bh=IOJVNRH23uKMRT7dqncoQ/v8a9pSpeeu+QEgTdh0vzs=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=LhOtPuNDg8+l5CYIifo/wmOuGT/C5iE5mR+vVkb3dpgvNgP2UYyc9G35eCWlve1X8 wjsHq5VQEp+glftYVsSZsC8i/5yoI/J9JY7q0KMo4xyXV92vw5JWEQSEDYTFa41r3I nuTP8QBZRkFsAGE21sGv8YsHF7kqV6EhXyxEyKj4= Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-eopbgr750078.outbound.protection.outlook.com [40.107.75.78]) by sourceware.org (Postfix) with ESMTPS id 0143F3939C0D for ; Wed, 28 Apr 2021 11:43:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0143F3939C0D ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJ4cq7iGQEj1tg0LNzhCB7fFkKSLmTRkDxFq+8l8imV8CNLDihcFIFBbUWvSN4widj4BW54eP4H44831Mp68SjwcaRMzUtjJ+Cxv10n5iMskG/OJkDhJ/COrCE4SAjV2F2jQVrOfDsDO/pasdjEZLszB1rtzfupkM5NdUyaDLEsiR/tzVJui1LLrqRchyp1fdQRz7tRQ+jWqz3KM1BgBnAiz+tuclrY5sRUATPyCdWgbsZzhEAB4kbkyuxx/Bk6OpWPcN/HK9Ft4YFxvGI1CWfbR23CUQFj3zMJ/eMPi4vapqtnz8atjodo3x0b0Fx+2m8uA1m8V+Utm5XFdvgR5Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IOJVNRH23uKMRT7dqncoQ/v8a9pSpeeu+QEgTdh0vzs=; b=KHKh9TIGuuGzpx8mYZrSOn8AolggYdMb+ewj0FH9200hiBJU6EuKV2leeJO29fDBvYBS63cZhDdwXUuqt7EXppCMYPpesnSg5My5azagVoDd3BstK2dAN5eUlJ6dqHVqOoDFiiOuwlIlNT5iG0xMH1wG9W3o5G+CcgoOHsLeTvk6oOzag3BMbFue8Jj56HRAbiQn04IOX/ZSuBWs7cuKscTmY0dq2lOudDAOfTPV6ovz3G9du2Rp2LnjgErFbmjcOQvfUQflypJQzLefwZigt45BpVMKtbmUrGgBjeItpYK0e7zXEl15ICsAIk33XOjfMWpKbFc8+kUg6ISs7rIsvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB3289.namprd12.prod.outlook.com (2603:10b6:5:15d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Wed, 28 Apr 2021 11:43:13 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5%7]) with mapi id 15.20.4065.023; Wed, 28 Apr 2021 11:43:13 +0000 Subject: Re: [PATCH 14/43] Make value_copy also copy the stack data member To: Simon Marchi , gdb-patches@sourceware.org References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-15-Zoran.Zaric@amd.com> Message-ID: <8a3c64a1-332e-8349-df22-ef8c59f1a67c@amd.com> Date: Wed, 28 Apr 2021 12:43:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1] X-ClientProxiedBy: LNXP265CA0002.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::14) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1] (2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1) by LNXP265CA0002.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25 via Frontend Transport; Wed, 28 Apr 2021 11:43:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23bbc0ad-eea9-44f4-e2bc-08d90a3ace50 X-MS-TrafficTypeDiagnostic: DM6PR12MB3289: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gMHkuTooQ6nf1niOsdnXJB7+FZwrkpW17eus/BT2cmrwWSoaDC4lbI3gHUOCol59q81bp4wZcIXmibDk4+lkgKe3d9tEHDQ40s01pZ2Dmyud6cc3KidiwWVDc7p6c2rqQbfLXTlSv2scIUJ0MVQS1SyyY7ZoyoX3QtDDgZJuywqG6Zg9OPsZA6sFFSeZez29XNhA7joRpu+OfPtWzHXjWSfwybelIaBeAvMFqCfSfTmAPb9cNVVtNozKYkN2w6Y7lkORIVym53wU2r3V5FiLvQo94ycn8S+Kz/08IH7jY2vGillM5ohModTzDX4Mac4/gBfKoGmOSe7gDaDxIdMuBdJIuOT5Wt/EZb+SG7a2U+Zh3CtpzjkIKrl9ubm+CeFAq4+8KJtEN8vPg910nh5X0dL+ZK5JAxpftalk/c2CzQqDLq/uVURNe48dqMmn7/diTwzX23r6Qar0dVtIxyarEOTftatDOi0Noc+kY5fWrZKxQgJ4ezksN9WrpMfBBjkt+SSW1YLgP9BfaIQ57rK+uRe5OUWCX6UepTEMk6yO/WDlRZm89O0RVf7Usp1FU/Dq/UHD5BKBCDX6KMQbTc1BtuCxyiYOHDpq5YiAt0mZYV0dSx1LeW3zzWkE0wVnouDpeRq1NqtNWylOJOf5MZKB6G65zX1IacTlwtUPmsnfuyDz/9XZYSEJHEts1+JjWQ6O X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(366004)(136003)(396003)(8676002)(52116002)(316002)(53546011)(83380400001)(36756003)(6486002)(2616005)(6666004)(478600001)(38100700002)(86362001)(31686004)(66476007)(66556008)(8936002)(186003)(5660300002)(16526019)(2906002)(31696002)(66946007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bnJQUG0veEc1emtnTG5WY2hsS1drdkoyOWwxOUxHQXpXbmF2amd2R1FjSGtZ?= =?utf-8?B?bFB3VEZPV3lnaGkxQUhSMTRlU25XTkNURnM1MXNidlRDQUdoMWlJOVdCc1BY?= =?utf-8?B?S01jZm8reEUveVNHN0JiV0dzSEVqeUZ5a0F4NUJ6UUl2VWg5Rjh3WElxaVg1?= =?utf-8?B?OVQxL01vamEycmRNUTFyMnJac1p4Z1hJZ0Ivak9NeFptNTd2WUN4QWRCclIv?= =?utf-8?B?elpZN2N2TUJkL1lDNlVlMlVvY0txaTVwSlFRTnZVeFl6OC8wYWxscWZ2dFBE?= =?utf-8?B?TWVkUnVMUjNER0I0bU1sQnRWcTQwZEZVWnNwK0FZSWJ6ekFjaFJ0RHI1a1Iz?= =?utf-8?B?QVl6a0FhUmkvYnN6eGxvbG4vWElrVVhKZmhISzZoVW1pNmRTRDJlRDFOcHhX?= =?utf-8?B?N2srNkFRalhrZStQa0phclpYZXIxT0h3cDFTb1VzOVpuWmlSeFhVd3lRNUV2?= =?utf-8?B?WFN0a0NIbDFTc0xzU29VUFNaeXI1c1EvNlVMMU5TZWM3ajJvTXNac29hSHNu?= =?utf-8?B?MkU2NGd2UWw4UFBuaHJoeTZDWE10VE03QlRHKzBjUHcrS2NrbVpjNnBOejZZ?= =?utf-8?B?TmpzVmlxVkpUOU9JMndsdDFiVFRFUDhkMEE1REV3M1VvYkQrWjlVejlqUmtL?= =?utf-8?B?aEtEdkFudFJRZzZZT1o3OG9YbDl1V0xFZWxPeFV6SzVqam00WHdIaTdKZ3RY?= =?utf-8?B?VW5kZ3hjOXhTOWs4V1ZVZ3UrYmhuRWpiQ0NtVDlGU09pRDRJQXlpZDhZdk0y?= =?utf-8?B?ZWxFcVlkRmVwbk1Tc2ZkblliMkhhZXhvR3l3T0JsekhITnFhVnQyV3RtYm5G?= =?utf-8?B?UmFUV2VPN3U0eHl4OFdXRWpqUkRoL2RVWTY4anZ1bVdoVzJWaExVSjI2WVF6?= =?utf-8?B?MU9qTit6UjRiMTFnVHRtU1RMQnhiOFpBWHNhME5hYnpQVlJaYkNUdlFkTUNq?= =?utf-8?B?UEZZYTg1V0syWkpIMlNWVjVqZ3FqSkVpa09QelVRUDdCUnpWemFvWGNBc1E1?= =?utf-8?B?a0RvaUIyazlEajNjd1lGbHZlYWFIdlM1V2phM0NXeldURG1LMFFTRHk0dHU3?= =?utf-8?B?YnlIbWowTE51ZWFMRDB5aEhyVzVuYWF4cUVma2NlWWptL2FrYXF6QlNUay9J?= =?utf-8?B?N0VneFJDelFNdE95ZUduVUl1VDBYTUppY0Zic3o5TUloTFBzSzBjNkNQOEhS?= =?utf-8?B?dUoxMm1zOUhyRVRYZmx4aXNhUCt3R0tEcHBxU0U5SkdiWHZNKzRzQ1d0YXkx?= =?utf-8?B?YW5yNE9mckR0UHFQN0RQaXdONnRrbW0xVEN6eUFGb3JYcE94L3RYbDlRUlhk?= =?utf-8?B?NEppT0hEV09iQWx3RS9GaFV2Zk1Dd3c4WmFXU0FlMW12L1EvT2EyY3JKTlJN?= =?utf-8?B?QTUxM2Z3bnpjMmNmTmV2b05LVC9oWnlidDRhYzl5bE9VMzR4ZGV4RlNPVHIw?= =?utf-8?B?c1c2OVFvRWNNTVkwRlpmMy9Ldmd1dkJIeURuTVFVSGlPbE1lTXIwajVlbXhj?= =?utf-8?B?RW9kOTJ2endvOFNiWXo2L2s0YzdsSlI2cXp4WWhCaXFkdXIxc3hRaDBlNkda?= =?utf-8?B?ZE1tUEtNaEN5Ty9KOFVxVXFjK3N4amlRSzZHZHNiK245dWVjK2RxU0FRUDhE?= =?utf-8?B?aC9tTW13S2VENUZCSzAySUZndGNhcVFrM2lPOWNPRXcwQVZIRm9MVFAzOHE5?= =?utf-8?B?bllLeDVXNzBXbXJSWXBxSHVLb1ZjNjB2cExDcjZXU2hwWjMvd2N4dXFlZFVX?= =?utf-8?B?RTQrZFovck10NzYzeDlPOUVjWDQ2amo3Q3dwTEhqRk52N2E2SklQdDV6OFd1?= =?utf-8?B?Z2kwWXU3ZlJjemt5dXZOUnlRYXJqWXVwQ09laElyTUh3RTdLRGt1NXNvRm9L?= =?utf-8?Q?HXbsbV8I9VIzy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23bbc0ad-eea9-44f4-e2bc-08d90a3ace50 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2021 11:43:13.6653 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G/XGoBVrF1iFzWEJH9Kf3U1Wp6+43evENjr32suL7dfHzbfkmrawhY430sXGxVDNaszEPNQTH0AZLhpMMU5JJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3289 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 4/28/21 3:01 AM, Simon Marchi wrote: > [CAUTION: External Email] > > On 2021-03-01 9:45 a.m., Zoran Zaric via Gdb-patches wrote: >> Fixing a bug where the value_copy function did not copy the stack data >> member of the struct value. This is needed for the next patch where the >> DWARF expression evaluator is changed to return a single struct value >> object. >> >> * value.c (value_copy): Change to also copy the stack data >> member. > > `member` should be aligned with the asterisk. Thanks, I will fix it in the next iteration. > >> --- >> gdb/value.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gdb/value.c b/gdb/value.c >> index bddf9a47923..9f3914a5bc5 100644 >> --- a/gdb/value.c >> +++ b/gdb/value.c >> @@ -1690,6 +1690,7 @@ value_copy (struct value *arg) >> val->embedded_offset = value_embedded_offset (arg); >> val->pointed_to_offset = arg->pointed_to_offset; >> val->modifiable = arg->modifiable; >> + val->stack = arg->stack; >> if (!value_lazy (val)) >> { >> memcpy (value_contents_all_raw (val), value_contents_all_raw (arg), >> > > LGTM. Although it would be good to check if there are other leftovers. > For example it seems like the `initialized` field should be copied as > well? > > Simon > Yeah, I need to add the initialized there too and run the test to see what happens. I am confused how this wasn't noticed before though. There might be more information that is missing. Zoran