From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108194 invoked by alias); 30 Oct 2018 11:13:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108181 invoked by uid 89); 30 Oct 2018 11:13:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30059.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.59) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Oct 2018 11:13:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ruMBV4j+COskXF1x5t3jpFQNglC5N0vFi2sgeCOZ1Iw=; b=iawDb/dI/OE4kJev9Mhs4oqDgUXZNPGWn51iRFYVdhwUUXL6KCkjt6nk52Lk46/hNKFHkb4DMTfcWVRKUFRqmXp4lzmk3QdH1SZPJIbYk5CG9BeTei1Y5hGHPCz+2g/CwTl8K1XH/6kYIzAoYvltvEYimf/kf3oXllsrjwva7ko= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2262.eurprd08.prod.outlook.com (10.172.227.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.19; Tue, 30 Oct 2018 11:13:42 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::748a:5f72:2321:bc11%7]) with mapi id 15.20.1273.027; Tue, 30 Oct 2018 11:13:42 +0000 From: Alan Hayward To: Pedro Alves CC: GDB Patches , nd Subject: Re: [PATCH v3 3/3] Aarch64: Fix segfault when casting dummy calls Date: Tue, 30 Oct 2018 11:13:00 -0000 Message-ID: <8DDC5D9D-D601-4D6D-A21F-7A35FF92C6EA@arm.com> References: <20181011144905.66908-1-alan.hayward@arm.com> <20181011144905.66908-4-alan.hayward@arm.com> <95a5dd34-6815-f3f5-107c-13f4956b741e@redhat.com> <9290BC71-862C-48B1-97FD-A46C5D15A65C@arm.com> <201c7a49-ddf3-636a-f15a-eb9a4ccf284e@redhat.com> <3FFDA486-3FC8-4DA2-92C9-83C320F589F6@arm.com> <862cf8f4-9491-a1eb-251e-6c7c1ffffa6c@redhat.com> <830e7c3b-3469-6cea-61d1-5a1e7e230de1@redhat.com> In-Reply-To: <830e7c3b-3469-6cea-61d1-5a1e7e230de1@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <6C7B0090168F6A40A9072AC1F2110E5D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00710.txt.bz2 DQoNCj4gT24gMjkgT2N0IDIwMTgsIGF0IDE4OjEzLCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMTAvMjkvMjAx OCAwMjo1NiBQTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPiANCj4+IEEtaGEh IE5vdyBJIHVuZGVyc3RhbmQgd2h5IEkgZ2V0IHR3byBjYWxscyBpbnRvIF9w dXNoX2R1bW15X2NhbGwuDQo+PiANCj4+IFNvIHRvIGFuc3dlciB5b3VyIHF1 ZXN0aW9uLCB0aGUgVFlQRV9DT0RFX1BUUi0+VFlQRV9DT0RFX0lOVCBpcyB0 aGUgbWFsbG9jIGNhbGwuDQo+PiANCj4+IFRoZW4gdGhlIG5leHQgY2FsbCB0 byBfcHVzaF9kdW1teV9jYWxsIGhhcyBhIHJldHVybiB0eXBlIG9mIDAsIGFz IGV4cGVjdGVkLg0KPj4gVGhpcyBkb2VzbuKAmXQgc2VnZmF1bHQgYmVjYXVz ZSBpdCBnb2VzIGludG8gbGFuZ3VhZ2VfcGFzc19ieV9yZWZlcmVuY2Ugd2hp Y2gNCj4+IHJvdXRlcyB0byBkZWZhdWx0X3Bhc3NfYnlfcmVmZXJlbmNlLiBU aGUgc2FtZSBhcyB0aGUgQyBzaGFyZWQgbGlicmFyeSB2ZXJzaW9uLg0KPj4g DQo+PiANCj4+IEnigJl2ZSB1cGRhdGVkIHRoZSB0ZXN0IHNvIGl0IGRvZXMg e2MsYysrfSp7ZGVidWcgbm9kZWJ1Z30uDQo+PiBJIGNhbiBhbHNvIHVwZGF0 ZSBpdCB0byBkbyBib3RoIHNoYXJlZCBsaWIgYW5kIG5vbiBzaGFyZWQgbGli IHRvby4gVGhhdCBzaG91bGQNCj4+IGNvdmVyIGV2ZXJ5dGhpbmcuDQo+IEJ1 dCBzdGlsbCwgd2h5IGRvIHlvdSBzZWUgYSBkaWZmZXJlbmNlIGJldHdlZW4g c2hhcmVkIGxpYnJhcnkgYW5kIG5vbi1zaGFyZWQNCj4gbGlicmFyeT8NCg0K SW4gYWxsIGNhc2VzIHRoZSBmdW5jdGlvbiB0eXBlIGlzIHRoZSBzYW1lLg0K DQpUaGUgZGlmZmVyZW5jZSBpcyBiZWNhdXNlIHdpdGggYysrICYmIHNoYXJl ZCBsaWJyYXJ5LCB0aGUgY29kZSBlbmRzIHVwIGluIA0KZ251djNfcGFzc19i eV9yZWZlcmVuY2UoKSwgd2hpY2ggbWVhbnMgaXTigJlzIHVzaW5nIHRoZSBH TlUgRysrIFZlcnNpb24gMyBBQkksDQp3aGVyZWFzIHdpdGggYW55IG90aGVy IG9wdGlvbnMgKG5vbiBzaGFyZWQgb3IgYykgaXQgZW5kcyB1cCBpbg0KZGVm YXVsdF9wYXNzX2J5X3JlZmVyZW5jZSgpLg0KDQpMb29raW5nIGF0IHRoZSBk b2MgZm9yIEdOVSBHKysgVmVyc2lvbiAzIEFCSToNCmh0dHBzOi8vZ2NjLmdu dS5vcmcvb25saW5lZG9jcy9saWJzdGRjKysvbWFudWFsL2FiaS5odG1sDQpU aGUgbGlicmFyeSBuZWVkcyB0byBiZSBsaW5rZWQgYWdhaW5zdCBsaWJzdGRj Kysuc28gdG8gdXNlIGl0Lg0KDQpBIHF1aWNrIGxkZCBzaG93cyBvbmx5IHRo ZSBjKysgLnNvIGlzIGxpbmtlZCBhZ2FpbnN0IGl0Lg0KDQoNCkFsYW4uDQoN Cg0K >From gdb-patches-return-151993-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Oct 30 14:59:02 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 27447 invoked by alias); 30 Oct 2018 14:59:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 27420 invoked by uid 89); 30 Oct 2018 14:59:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_STOCKGEN,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Oct 2018 14:59:00 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8C4DDB0F8; Tue, 30 Oct 2018 14:58:58 +0000 (UTC) Subject: Re: [PUSHED 2/5] Add [-q] [-t TYPEREGEXP] [NAMEREGEXP] args to info [args|functions|locals|variables] To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20181027124418.20394-1-philippe.waroquiers@skynet.be> <20181027124418.20394-3-philippe.waroquiers@skynet.be> From: Tom de Vries Cc: Pedro Alves Message-ID: Date: Tue, 30 Oct 2018 14:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181027124418.20394-3-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00711.txt.bz2 Content-length: 1908 On 10/27/18 2:44 PM, Philippe Waroquiers wrote: > @@ -4497,8 +4560,13 @@ search_symbols (const char *regexp, enum search_domain kind, > || MSYMBOL_TYPE (msymbol) == ourtype3 > || MSYMBOL_TYPE (msymbol) == ourtype4) > { > - if (!preg || preg->exec (MSYMBOL_NATURAL_NAME (msymbol), 0, > - NULL, 0) == 0) > + /* If the user wants to see var matching a type regexp, > + then never give a minimal symbol. */ > + if (kind != VARIABLES_DOMAIN > + && !treg.has_value () /* minimal symbol has never a type ???? */ > + && (!preg.has_value () > + || preg->exec (MSYMBOL_NATURAL_NAME (msymbol), 0, > + NULL, 0) == 0)) > { > /* For functions we can do a quick check of whether the > symbol might be found via find_pc_symtab. */ Hi, Consider this testcase with minimal symbols: ... $ cat test.c static int var; int main (void) { return 0; } $ gcc test.c $ ... After this commit, I don't see "var": ... $ gdb -batch a.out -ex "info var" All defined variables: File init.c: 24: const int _IO_stdin_used; ... while before this commit, I do see "var": ... $ gdb -batch a.out -ex "info variables" All defined variables: File init.c: 24: const int _IO_stdin_used; Non-debugging symbols: 0x0000000000400534 __GNU_EH_FRAME_HDR 0x0000000000400624 __FRAME_END__ 0x0000000000600e40 __frame_dummy_init_array_entry 0x0000000000600e40 __init_array_start 0x0000000000600e48 __do_global_dtors_aux_fini_array_entry 0x0000000000600e48 __init_array_end 0x0000000000600e50 _DYNAMIC 0x0000000000601000 _GLOBAL_OFFSET_TABLE_ 0x0000000000601018 __data_start 0x0000000000601018 data_start 0x0000000000601020 __dso_handle 0x0000000000601028 __TMC_END__ 0x0000000000601028 __bss_start 0x0000000000601028 _edata 0x0000000000601028 completed 0x000000000060102c var 0x0000000000601030 _end ... I think this is a regression. Thanks, - Tom