From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mMB2Nefl/WNbeAAAWB0awg (envelope-from ) for ; Tue, 28 Feb 2023 06:30:47 -0500 Received: by simark.ca (Postfix, from userid 112) id D5DA61E222; Tue, 28 Feb 2023 06:30:47 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=sATM1zp6; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 787E11E128 for ; Tue, 28 Feb 2023 06:30:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 00CD03864832 for ; Tue, 28 Feb 2023 11:30:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00CD03864832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677583846; bh=pwh29vJpOGEFV1Fen0iZ8hVpBVKdUfkNZ9dNp59Ilio=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=sATM1zp6akf+JjTi70td6KaYvDiHCIVsXTeVFREKQzBpfFCV4gjWtay75dW3NHDoq YzH/DBeGhKZe48cuQwJkQXYoi+w1sFq3ayUXSlyKNaHes8c+5hdvo/rx+WDcaRWEWM sSOy3rtXajw2kpoWEOIicxUWtH7A7w1QVZiINf7U= Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 95A5C385043A for ; Tue, 28 Feb 2023 11:30:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 95A5C385043A X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="420374065" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="420374065" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:30:13 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="848213536" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="848213536" Received: from ultl2604.iul.intel.com (HELO localhost) ([172.28.48.47]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:30:11 -0800 To: gdb-patches@sourceware.org Subject: [PATCH 14/26] gdbserver: introduce and use regcache::set_register_status Date: Tue, 28 Feb 2023 12:28:12 +0100 Message-Id: <89ffb94330c3f96b34e00a653ebbfce99a075c42.1677582744.git.tankut.baris.aktemur@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tankut Baris Aktemur via Gdb-patches Reply-To: Tankut Baris Aktemur Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Introduce and use a setter method in regcache to set the status of a register. There already exists get_register_status. So, it made sense to add the setter to control access to the register_status field. --- gdbserver/regcache.cc | 23 +++++++++++++++-------- gdbserver/regcache.h | 3 +++ 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index 79835ef4ff1..ec11082be6f 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -336,16 +336,14 @@ regcache::raw_supply (int n, const void *buf) { memcpy (register_data (n), buf, register_size (tdesc, n)); #ifndef IN_PROCESS_AGENT - if (register_status != NULL) - register_status[n] = REG_VALID; + set_register_status (n, REG_VALID); #endif } else { memset (register_data (n), 0, register_size (tdesc, n)); #ifndef IN_PROCESS_AGENT - if (register_status != NULL) - register_status[n] = REG_UNAVAILABLE; + set_register_status (n, REG_UNAVAILABLE); #endif } } @@ -358,8 +356,7 @@ supply_register_zeroed (struct regcache *regcache, int n) memset (regcache->register_data (n), 0, register_size (regcache->tdesc, n)); #ifndef IN_PROCESS_AGENT - if (regcache->register_status != NULL) - regcache->register_status[n] = REG_VALID; + regcache->set_register_status (n, REG_VALID); #endif } @@ -384,7 +381,7 @@ regcache::supply_regblock (const void *buf) memcpy (registers, buf, tdesc->registers_size); #ifndef IN_PROCESS_AGENT for (int i = 0; i < tdesc->reg_defs.size (); i++) - register_status[i] = REG_VALID; + set_register_status (i, REG_VALID); #endif } else @@ -392,7 +389,7 @@ regcache::supply_regblock (const void *buf) memset (registers, 0, tdesc->registers_size); #ifndef IN_PROCESS_AGENT for (int i = 0; i < tdesc->reg_defs.size (); i++) - register_status[i] = REG_UNAVAILABLE; + set_register_status (i, REG_UNAVAILABLE); #endif } } @@ -498,6 +495,16 @@ regcache::get_register_status (int regnum) const #endif } +void +regcache::set_register_status (int regnum, enum register_status status) +{ +#ifndef IN_PROCESS_AGENT + gdb_assert (regnum >= 0 && regnum < tdesc->reg_defs.size ()); + if (register_status != nullptr) + register_status[regnum] = status; +#endif +} + /* See gdbsupport/common-regcache.h. */ bool diff --git a/gdbserver/regcache.h b/gdbserver/regcache.h index 88e6ac32bae..ceef28086ce 100644 --- a/gdbserver/regcache.h +++ b/gdbserver/regcache.h @@ -64,6 +64,9 @@ struct regcache : public reg_buffer_common /* See gdbsupport/common-regcache.h. */ enum register_status get_register_status (int regnum) const override; + /* Set the status of register REGNUM to STATUS. */ + void set_register_status (int regnum, enum register_status status); + /* See gdbsupport/common-regcache.h. */ void raw_supply (int regnum, const void *buf) override; -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928