From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115566 invoked by alias); 11 Jul 2018 10:58:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115557 invoked by uid 89); 11 Jul 2018 10:58:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=documents X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jul 2018 10:58:55 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0C0F581A4EAD; Wed, 11 Jul 2018 10:58:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A60B1C661; Wed, 11 Jul 2018 10:58:53 +0000 (UTC) Subject: Re: [RFA_v4 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20180710213926.32240-1-philippe.waroquiers@skynet.be> From: Pedro Alves Message-ID: <89ff2c0a-2654-d4a6-ded9-65bf726a61bf@redhat.com> Date: Wed, 11 Jul 2018 10:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180710213926.32240-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00297.txt.bz2 On 07/10/2018 10:39 PM, Philippe Waroquiers wrote: > This is the fifth iteration of the patch series that: > * implements a new command > 'frame apply [all | COUNT | -COUNT | level LEVEL...] [FLAG]... COMMAND'. > * enhance 'thread apply COMMAND' by adding FLAG arguments. > * adds some shortcuts commands. > * documents the above in gdb.texinfo and NEWS. > * adds a unit test for cli-utils.c. > * adds test for 'frame apply'. > * modify gdb.threads/pthreads.exp to test 'thread apply' FLAG arguments. > > The fifth version is RFA v4. It handles the third set of comments > given by Pedro. > The main changes compared to RFA v3 are: > * frame level LEVEL... replaces frame id ID... Very nice. The changes to the testcases and the unit tests makes them much clearer, IMHO, well done. This version looks great to me. Thanks, Pedro Alves