From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0MCIO7LkX2r9+yEAWB0awg (envelope-from ) for ; Tue, 21 Jul 2026 17:29:23 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=UwikKtET; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DD5CC1E09E; Tue, 21 Jul 2026 17:29:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 520DF1E033 for ; Tue, 21 Jul 2026 17:29:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8C33F4BA2E25 for ; Tue, 21 Jul 2026 21:29:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C33F4BA2E25 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=UwikKtET Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 58AFF4BA543C for ; Tue, 21 Jul 2026 21:28:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58AFF4BA543C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 58AFF4BA543C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784669336; cv=none; b=U35dBQao5ik+kFmNXRqFfE9Yng7phAoRhWvhqWbycfOJ7oX81i1mA39bckhILIMrI1bMK1oQCxHMxIcu6uewR1rQPQ4DL55aqvLTNZjw7L78/iSq1Hqi7itAHx7THljorJ2MOwbliIEX7Kd5fMgtqwRur1Uyv/KRBIe7csslAtY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784669336; c=relaxed/simple; bh=us+6xvCGDmN4uHcohej5olZmRFC0xWbvpq8R9MnaJIc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=XTIavs3okJ0zAZNuyr5APPMeU76Iix+bRgWhr9l6atO7NfU2/qJkledt2Nz3UHLpWT8T8jni433b+XEEXSFs5VaKfHLg6uOb4MffsEE0UYzR8F2QiZFDTCZRK8U1RsWlfW1R8zPSQV6TctpQp/aEVXMEaWDzAOlgolUkCF/lDq4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=UwikKtET DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 58AFF4BA543C Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-472326ca506so9095646f8f.2 for ; Tue, 21 Jul 2026 14:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784669335; x=1785274135; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=wUI0Z93bWZ2R3gBJFxGHcfzpFmBwTfrENu1fIu6QMl0=; b=UwikKtETOpHl7KdwG7CJQqTTVZYOlQvnb16f/nNqo1m4kHFAzzBhjtVqeiYA21E4zS eUXnhdtYZiuLIko3Ass8uDQfYHok6aJMK9xszqI6S3gpv1yyCN0cxDh/0fUE3yFV81ql lsUAajxtYJ8lj+Ow2gSuXU5aiCU8fW0okv/Y4rMtW6+hY2MSeJ6TC3O3BMfSxKrmSnFE MSIeVSfSz1sYq52fIhdT9OgG4mvRPeHvAkIazxkjPAj1hhrBy6cnkKmAT441WSfh8inw p6m0SmvxUSHGVao5cmpKNPjQwgHISaaCvtiiDIBU5DID88m1uT9R3Hu1MbjrpFuUhVjb zTtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784669335; x=1785274135; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wUI0Z93bWZ2R3gBJFxGHcfzpFmBwTfrENu1fIu6QMl0=; b=LJZc1+yHDeV5Qd6SstqoCmeqfNEKcQYFk0xuklYPDqF9hM+mmPqRV4dHYiQUUGW2tm 90csjDA3O+M6Iw+EdLuzN5wh+0Xh8oaYH3oBwpYAud4sXjfdTw3zvpMILPelByjBWPql ZdvlYkvTMgk7PnoRiY/rGIEV8/u0quq4QCN0/X6fTRFZgC8KsjOEVlx9ffqrmUK8Fc5A RiAjX62s9ngr/Dw4YqNl8cSpKEF7HJWzelbJLrWw1WkAe9knLLlzUOVaj1Rxf9MbSsKh J9qWOeQlornNxCKJ2Qi4nmyMERlbw2TNXephdWk9nuRrFfdnQevvAaPdD1jqX9LOvhJp XiGg== X-Forwarded-Encrypted: i=1; AHgh+Rq+Ey/zag4off/tWJo7OrrJRoGjIY3ylJ4ampaUTaktmiokSa5INtbPHFzin2smoF/K8saKROX19Xm1qw==@sourceware.org X-Gm-Message-State: AOJu0YxMB3U7chZOiGRZ4G7VPMw+YwDduXNHWO78hl4HDaJwBXMZWxMJ 7lWnag/Lwxcu20CCvSv7JsE1QsyJ8+x4LomoBM6cnYGjhUvHHPPASkaG X-Gm-Gg: AR+sD10eyI+JPw22GLwlvYrboymDKVdEaQzSlfRgQDuPMhYS7Baf9cMU1NHJzmvef4t TFXi+/bBYlQAUme28ND7Q+yntte/Mt6FtcAs5lOjWH9RwQ3wGDqb8Vtgx4351G0GwCem3gEqdQb 6pecdWXlkeEmT2rbqw2rowK9AZkjrUMQ+nElX+HgS5aJQOeGqJ3GfCJP0OdgSoAE3Oog85fnEkO S3q0pGqbggwwqziKPSM6Jk2KcOJZzTDFjVSwFa8/Wbtez7t7lmJcI2WbVtIRxogwy1h4naZA6ET E1boHnjND/MZSYpslG8UN5cOvHZKNYReznBoVQcl2z+9hNUmwuBJfaxXrQo2QIjIQIRIMzhwgcy OPjjjy+1M9xWaNUUzyAk6JpQd6D/8vDgiEK6gsZrg5ICcX4edZXn1SYga8/zlMNqKS9ITUVgdUV 1fK2K4/nR64KjPRvG9v9PuVeYI+w== X-Received: by 2002:a05:6000:41ce:b0:47f:70b9:4882 with SMTP id ffacd0b85a97d-47f70b964b9mr18659036f8f.17.1784669335118; Tue, 21 Jul 2026 14:28:55 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63eddd1csm41757159f8f.29.2026.07.21.14.28.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 14:28:54 -0700 (PDT) Message-ID: <89ed83ac-eff5-429d-abba-3d2a71cb7299@gmail.com> Date: Tue, 21 Jul 2026 22:28:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/10] target_fileio_read_stralloc: add an optional length parameter Content-Language: en-US To: Matthieu Longo , gdb-patches@sourceware.org Cc: Luis Machado , Andrew Burgess , Yury Khrustalev , Pedro Alves , Tom Tromey References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-4-matthieu.longo@arm.com> From: Luis In-Reply-To: <20260707154900.94542-4-matthieu.longo@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Empty commit message... On 07/07/2026 16:48, Matthieu Longo wrote: > --- > gdb/target.c | 10 +++++++--- > gdb/target.h | 2 +- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/gdb/target.c b/gdb/target.c > index 5d937f3ae85..e4907ca815a 100644 > --- a/gdb/target.c > +++ b/gdb/target.c > @@ -3547,7 +3547,8 @@ target_fileio_read_alloc (struct inferior *inf, const char *filename, > /* See target.h. */ > > gdb::unique_xmalloc_ptr > -target_fileio_read_stralloc (struct inferior *inf, const char *filename) > +target_fileio_read_stralloc (struct inferior *inf, const char *filename, > + size_t *len) > { > gdb_byte *buffer; > char *bufstr; > @@ -3556,17 +3557,20 @@ target_fileio_read_stralloc (struct inferior *inf, const char *filename) > transferred = target_fileio_read_alloc_1 (inf, filename, &buffer, 1); > bufstr = (char *) buffer; > > + if (len != nullptr) > + *len = (transferred < 0 ? 0 : transferred); > + > if (transferred < 0) > return gdb::unique_xmalloc_ptr (nullptr); > > if (transferred == 0) > return make_unique_xstrdup (""); > > - bufstr[transferred] = 0; > + bufstr[transferred] = '\0'; Why 0 -> \0? > > /* Check for embedded NUL bytes; but allow trailing NULs. */ > for (i = strlen (bufstr); i < transferred; i++) > - if (bufstr[i] != 0) > + if (bufstr[i] != '\0') Likewise, why 0 -> \0? > { > warning (_("target file %s " > "contained unexpected null characters"), > diff --git a/gdb/target.h b/gdb/target.h > index 22653138491..4215553033c 100644 > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -2336,7 +2336,7 @@ extern LONGEST target_fileio_read_alloc (struct inferior *inf, > are returned as allocated but empty strings. A warning is issued > if the result contains any embedded NUL bytes. */ > extern gdb::unique_xmalloc_ptr target_fileio_read_stralloc > - (struct inferior *inf, const char *filename); > + (struct inferior *inf, const char *filename, size_t *len = nullptr); > > /* Invalidate the target associated with open handles that were open > on target TARG, since we're about to close (and maybe destroy) the