From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9FuXNTsE6V/BLAAAWB0awg (envelope-from ) for ; Sun, 27 Dec 2020 17:01:31 -0500 Received: by simark.ca (Postfix, from userid 112) id CBEA01F0AA; Sun, 27 Dec 2020 17:01:31 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8FFE11E99A for ; Sun, 27 Dec 2020 17:01:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DDE00384241B; Sun, 27 Dec 2020 22:01:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDE00384241B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1609106489; bh=poJ4IHXtshYJrwxjGUlnwlTg0tNj7RUmRPIrxFgXru4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cEohw/iEj9FkTZ+BdcEAz6e/cZ1+MO+M3iZc9drmxZQkLUOL0E/3ubkROxIyhiYWL U2p6zOWEunHP3D+0TyqWzLiF6R1fWWCN61hr6vtTx7kEFQSzYYR8LkCQx1xjjRT8sj uivIDPW5UmGrkVYwsg2YvcjqPOxYAykkvG2SN3sM= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id ACDAD3857824 for ; Sun, 27 Dec 2020 22:01:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ACDAD3857824 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BRM15bV010223 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 27 Dec 2020 17:01:10 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BRM15bV010223 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E87C61E99A; Sun, 27 Dec 2020 17:01:04 -0500 (EST) Subject: Re: [PATCH v2] Enable GDB build with in-tree GMP and MPFR To: Bernd Edlinger , Joel Brobecker References: <71f5437f-c4f5-b58d-06f7-67a4d0b31007@simark.ca> <214e9564-5dfd-65a2-c2d8-6e8398ebc913@simark.ca> <87o8iw9ilx.fsf@tromey.com> <20201215023315.GK3461@adacore.com> <4ea7575a-b727-d9b7-e510-5c8b942f77f9@polymtl.ca> <20201216073333.GA934694@adacore.com> Message-ID: <89e6d36b-7a4b-4eed-69bd-fa82add4dab0@polymtl.ca> Date: Sun, 27 Dec 2020 17:01:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 27 Dec 2020 22:01:05 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Pedro Alves , Tom Tromey , "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-12-25 7:05 a.m., Bernd Edlinger wrote: > Hi everybody, > > I have now two possible ways to go forward with the configure options > for gmp and mpfr. > > See the attached patches: > > Variant 1: implements traditional configure options > --with-gmp-include=DIR, --with-gmp-lib=DIR, --with-gmp=DIR, > --with-mpfr-include=DIR, --with-mpfr-lib=DIR, --with-mpfr=DIR > but does additionally understand --with-libmpfr-prefix=DIR > and --with-mpfr=auto/yes/no. > > Variant 2: (I already posted that one) keeps all configure options > as they are now, and just uses the presence of a ../gmp and ../mpfr > directory to override the gmp and mpfr configure flags. > > I would be interested in what you think, and which variant you would > prefer. > > > Thanks > Bernd. > I really don't have a strong opinion about this, but my only strong-ish opinion is that I want to minimize the complexity of what we add. I'm already on the fence about the download script and detecting gmp / mpfr in-tree, because I think this is complexity we don't need. It's not difficult for the user to download and build these two libraries. It's totally fine for a project to have required dependencies that the user needs to build first... We already provide --with-libmpfr-prefix and --with-libgmp-prefix. Any complexity we add (like adding --with-gmp-include and --with-gmp-lib on top of that) means more combinations to test for whoever needs to modify that code next, more chances of breaking something. IMO it is not a net benefit for the project to add these additional new switches. Joel convinced me that it's not so important to stay in sync with gcc for this. So I'd choose the existing solution of using AC_LIB_HAVE_LINKFLAGS, since that takes care of all the low level details for us. Simon