Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH][gdb/symtab] Don't create duplicate psymtab for forward-imported CU
Date: Wed, 22 Apr 2020 15:55:35 +0200	[thread overview]
Message-ID: <89a77483-fe80-c537-47ff-b34e9eaacf29@suse.de> (raw)
In-Reply-To: <edaa17a8-0cd4-b54a-d0cf-c12b33c4acdc@simark.ca>

On 22-04-2020 15:45, Simon Marchi wrote:
> On 2020-04-22 2:13 a.m., Tom de Vries wrote:
>>> [ Forgot to mention ]
>>>
>>> Using a 2.8GB libxul.so debug file from opensuse tumbleweed, build with
>>> lto, we have:
>>> ...
>>> $ time.sh gdb -batch -iex "maint set dwarf max-cache-age 1000" -iex "set
>>> language c" usr/lib/debug/usr/lib64/firefox/libxul.so-74.0-1.1.x86_64.debug
>>> maxmem: 10417196
>>> real: 116.62
>>> user: 114.85
>>> system: 2.37
>>> ...
>>> and with this patch:
>>> ...
>>> $ time.sh gdb -batch -iex "maint set dwarf max-cache-age 1000" -iex "set
>>> language c" usr/lib/debug/usr/lib64/firefox/libxul.so-74.0-1.1.x86_64.debug
>>> maxmem: 10436372
>>> real: 77.42
>>> user: 75.54
>>> system: 2.46
>>>
>>> OK for trunk?
> 
> I just glanced at this and... wow, that's a big difference.
> 

Yeah :)

Not as big though as the difference of changing dwarf max-cache-age from
default 5 to 1000 (
https://sourceware.org/bugzilla/show_bug.cgi?id=25703#c1 )

Thanks,
- Tom



  reply	other threads:[~2020-04-22 13:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 10:19 Tom de Vries
2020-04-08 10:22 ` Tom de Vries
2020-04-22  6:13   ` Tom de Vries
2020-04-22 13:45     ` Simon Marchi
2020-04-22 13:55       ` Tom de Vries [this message]
2020-05-27 15:09         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89a77483-fe80-c537-47ff-b34e9eaacf29@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox