From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23451 invoked by alias); 17 Nov 2010 08:45:09 -0000 Received: (qmail 23442 invoked by uid 22791); 17 Nov 2010 08:45:08 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mms3.broadcom.com (HELO MMS3.broadcom.com) (216.31.210.19) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Nov 2010 08:45:02 +0000 Received: from [10.16.192.224] by MMS3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Wed, 17 Nov 2010 00:45:09 -0800 X-Server-Uuid: B55A25B1-5D7D-41F8-BC53-C57E7AD3C201 Received: from SJEXCHCCR02.corp.ad.broadcom.com ([10.16.192.130]) by SJEXCHHUB01.corp.ad.broadcom.com ([10.16.192.224]) with mapi; Wed, 17 Nov 2010 00:44:57 -0800 From: "Andrew Burgess" To: "gdb-patches@sourceware.org" Date: Wed, 17 Nov 2010 08:45:00 -0000 Subject: RE: [PATCH] Multi-dimensional Fortran arrays issue PR11104 Message-ID: <89AE14E37D740B4796DC14566DF6325ECB7F8F140B@SJEXCHCCR02.corp.ad.broadcom.com> References: <89AE14E37D740B4796DC14566DF6325ECB7E173182@SJEXCHCCR02.corp.ad.broadcom.com> <89AE14E37D740B4796DC14566DF6325ECB7F0C2B39@SJEXCHCCR02.corp.ad.broadcom.com> <20101018211952.GA16206@host1.dyn.jankratochvil.net> <89AE14E37D740B4796DC14566DF6325ECB7F1F6E81@SJEXCHCCR02.corp.ad.broadcom.com> In-Reply-To: <89AE14E37D740B4796DC14566DF6325ECB7F1F6E81@SJEXCHCCR02.corp.ad.broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00225.txt.bz2 Hi, If anyone has the time please could this patch be reviewed. I realise that = there's an overlap with some of the code currently in the Archer VLA branch= , but as this keeps some of the bounds checking in place I hoped this might= be acceptable. The revised patch includes the ChangeLog entry as text ahead of the patch c= ontent, I've since been told that's not the preferred format and will split= it out if that would make people life easier. I'm happy to make any changes requested. At the time I submitted the patch I built & tested on x86-64 with no regres= sions. Thanks, Andrew > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Andrew Burgess > Sent: 19 October 2010 17:23 > To: gdb-patches@sourceware.org > Cc: Jan Kratochvil > Subject: RE: [PATCH] Multi-dimensional Fortran arrays issue PR11104 >=20 > Jan, thanks for taking the time to look through the original patch. >=20 > > On 18 October 2010 22:20, Jan Kratochvil wrote: > > > > multi-dim.tar.bz2 (.exp + .f90) should be submitted as a normal > patch, >=20 > Done. >=20 > > > > ChangeLog should be submitted as a text, not as patch. > > >=20 > I've included the ChangeLog entries within the patch file as plain text > before the start of that patch content, this seems to be what others > have done, but I can pull them out if this is not correct. >=20 > > There are several minor issues with formatting: > > http://www.gnu.org/prep/standards/ >=20 > I believe that these have all been addressed. If I've still missed > anything then please let me know. >=20 > > > > This functionality is implemented by archer-jankratochvil-vla from: > > http://sourceware.org/gdb/wiki/ArcherBranchManagement > > > > (out of bounds access is not detected by the VLA patchset though) > > > > which is currently not submitted for a review as it has more > > prerequisites. >=20 > As I had the patch pretty much ready I cleaned it up anyway. I guess > it's up to someone else to decide to merge this or wait for the Archer > branch to land. >=20 > Thanks, >=20 > Andrew >=20 >=20