From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dF2WCls8lmhlBgcAWB0awg (envelope-from ) for ; Fri, 08 Aug 2025 14:05:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UPVUxQEm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 192F91E100; Fri, 8 Aug 2025 14:05:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3020B1E091 for ; Fri, 8 Aug 2025 14:05:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 517E23857BA5 for ; Fri, 8 Aug 2025 18:05:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 517E23857BA5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UPVUxQEm Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A4EE03858D29 for ; Fri, 8 Aug 2025 18:04:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A4EE03858D29 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A4EE03858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754676280; cv=none; b=LtLY3khrOCwFq04abvy5lKfd+sxOhmN3dBLsNsKJGfda9ipi1cH+MxU5M0mDaBlkr93U9V8Okvn+C/gsZheeTc9MsR9G8srTfaVXdtwvMZ4aN//2A25MDLt/3B4h43N8eHwEgVlA3Gu+dnM1GfF4FDfjN/8RDv0BbBRPNKp4NI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754676280; c=relaxed/simple; bh=GqCiyjR21Jk5NgIBmnddpSdLLqbYDrIE1tHBghhOavU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pr0QPI6Iu7hOW1QVxl7NS0oioL/YASNuICpq+DWD2odgVGahsyNUit3g9S+b9sBv4JCP/oHLUK9Ja8p1BsW1piGgBZsNzrIZZ8SmlBZGAfRv1S4/DanIeR6KqVV3lR5WzT+k7rM/cLVcFna6TGhrdyD3yvm/4SbCG9a2AsADQIc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4EE03858D29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754676280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RDow/ePF1un/ocba0R4Nc5rq/KCySlvhG8JP6ACTL2A=; b=UPVUxQEm0hAtDVe3cv7qHsvAFSfPHWm5mpoKRbM2MUDPtKfGVMlasxRCU3n5j3rvziz/kO 3sLghD1ZYn9QosHF+JES5ekV43ORTO5GQA9z/rYvrWVpfjCycd6UvM17/Hv1GdwRkuS7qm MhYZ1FlTlDIyRvUGa56lZgt8Xpl33BI= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-rtStWv-TOTSrcWbnry0Ejw-1; Fri, 08 Aug 2025 14:04:39 -0400 X-MC-Unique: rtStWv-TOTSrcWbnry0Ejw-1 X-Mimecast-MFC-AGG-ID: rtStWv-TOTSrcWbnry0Ejw_1754676279 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-71bf006b4f9so15629487b3.3 for ; Fri, 08 Aug 2025 11:04:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754676278; x=1755281078; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RDow/ePF1un/ocba0R4Nc5rq/KCySlvhG8JP6ACTL2A=; b=qAy/KLC6ofpDN62RGi23hasgez3fNITCsmwU5VWWHzpi0SF1H9PggxRbAPwbAoYFyM FQTwjVfL6+Kcxf/xwkNmTTILmtYKgTAEjhGf0SlGBhsZzyIikl5va49uuCiab2Yyj5qf 0E+z8T2MRnbGs4VhLtOO10pty/4HFkJnl2QZdMMaI7NIdWLYrJwa4b/5qFB2PxUDSbRm TDQ1fNXzaGf6Rm2VvA6wFcNBoRuHjWR83G/0tDLSK8+2NO7zBbe4LNq+m5OEWEGujfZ6 /8syAdQ4qTsJUeHrS9CrM/v04mjfjFyKINHd4Dlxa2VKw2KQ73qCUK3JpF40pELVT2pz DH7A== X-Gm-Message-State: AOJu0YxaR0Cx7b8BD7759tIRnz0nazYjgS1l6Nxiavlk3frucjrOKarI 1mmV/oq7S/Q1/+emfihecG5Hm3PF4OlRsFBgrlK1fBTbxIXaINNfqp7eyP1E5VZIX0aM76yzaty F8bej6x00eZWrXvQAHXflRAUDQgI+mwJhLtvSG73lWAKBGJs3gft05K2/bYbIr7vaK5tKEXn7CX HrUlPfvomsVnaUrGwFUbFU/hhoc6p15LMCiU6Kv8dLGPY/ X-Gm-Gg: ASbGncuZg0GBK0y6CFn6r4ozMjk5R4id6Kd+xxMJfuAU38BxxE+HkxMEFu32IfwNbtc cj1YRHKUDffMKSdAq6G/t0SIJfFN3fgMcq1ULKiZ4rw4hXOHqGP611qRl6Nm0+5EL1ctXWr58Rw MJmQPmCwKbGzz9L1QSu2k45sR96todwLeNXLs/45YP48R/EvRmG7JEJxNb+XOEOw/IXTCiwy3B1 pmluKE1KkiS6NbtL7dcH1BSjfOdf34ypLf+KsmOp17GU346p7bBEJKZzWBvmQbr9L59hLPy2Heq dasBB1+4vlGRaMJ13mg3B32cGAWoQyH00esOhzf0PeGkow== X-Received: by 2002:a05:690c:4c13:b0:719:c5dc:adc5 with SMTP id 00721157ae682-71bf0cd3c54mr52019937b3.9.1754676278222; Fri, 08 Aug 2025 11:04:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE32EssmECkuXAao+y2kNxqIHligV71YYhUcb0Aov0UcXhmcCqBrAIN25DOiyuJvzHaRxW7WQ== X-Received: by 2002:a05:690c:4c13:b0:719:c5dc:adc5 with SMTP id 00721157ae682-71bf0cd3c54mr52019237b3.9.1754676277624; Fri, 08 Aug 2025 11:04:37 -0700 (PDT) Received: from [150.1.200.135] ([172.56.107.115]) by smtp.gmail.com with ESMTPSA id 00721157ae682-71b5a3a996esm52899867b3.18.2025.08.08.11.04.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Aug 2025 11:04:37 -0700 (PDT) Message-ID: <899fd0f3-256e-4d7f-bbf5-ed16be4f32c5@redhat.com> Date: Fri, 8 Aug 2025 11:04:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] should_validate_memtags: Do not dereference references To: gdb-patches@sourceware.org References: <60afe2cd4b01bc7955fcf2b4e18727de0440801b.1754064717.git.keiths@redhat.com> <20250802154829.0e2bf696@f41-zbm-amd> From: Keith Seitz In-Reply-To: <20250802154829.0e2bf696@f41-zbm-amd> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SBK36p9oUNvKC1W8RfRXamAKUNpkkhPL4aU_TlQSPUU_1754676279 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/2/25 3:50 PM, Kevin Buettner wrote: > > Aside from the mode change of gdb/value.c, this LGTM. Approved, with > that change undone... Weird but fixed. > Approved-by: Kevin Buettner Thank you for the review, I've pushed this.Keith