From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107725 invoked by alias); 3 Apr 2019 19:00:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107270 invoked by uid 89); 3 Apr 2019 19:00:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail-wr1-f46.google.com Received: from mail-wr1-f46.google.com (HELO mail-wr1-f46.google.com) (209.85.221.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Apr 2019 19:00:44 +0000 Received: by mail-wr1-f46.google.com with SMTP id k17so213553wrx.10 for ; Wed, 03 Apr 2019 12:00:44 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id c189sm23656040wme.32.2019.04.03.12.00.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 12:00:41 -0700 (PDT) Subject: Re: [RFC] Sort #includes in gdb To: Simon Marchi , Tom Tromey References: <87fttfmnpq.fsf@tromey.com> <878sygydob.fsf@tromey.com> <87r2b7viht.fsf@tromey.com> <875zs1csim.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <898eb4d9-9c21-9dee-0291-ce82251e6c42@redhat.com> Date: Wed, 03 Apr 2019 19:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-04/txt/msg00056.txt.bz2 On 03/29/2019 09:05 PM, Simon Marchi wrote: > > I don't think I've mentioned it, but I really like this change.  I don't like the mental weight of having to choose where to add my include in an unorganized list :). Me too. I'm waiting for this to land before touching the "namespace gdb" work again, since a not-insignificant part of that work revolves around moving "#include"s in the middle of files to the top of the file. Thanks, Pedro Alves