From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18743 invoked by alias); 14 Feb 2020 17:58:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18735 invoked by uid 89); 14 Feb 2020 17:58:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Feb 2020 17:58:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581703111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nhrx0BZk9e+QmW7jftBuu526jguxubeBZki2FNSwKjo=; b=H91KXzoaQ/rMaYo97wriDQw9/OTUFBl72XKZwvqKjEqyDUMpVH20BI6N/nT3JWuM/i6T+V mppmmk5ye5xMN+ysDT12xt5w+dw+Ks4fC/APeNl2W4iollgHbPfzkC1kTolKklNP4YLW8g m1m289+1XOARj3F4HKYYoSK5ktIxZPA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-h1aTSY3UO5qznNvocmMIZA-1; Fri, 14 Feb 2020 12:58:22 -0500 Received: by mail-wm1-f70.google.com with SMTP id 7so3873323wmf.9 for ; Fri, 14 Feb 2020 09:58:22 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id a9sm8510347wrn.3.2020.02.14.09.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Feb 2020 09:58:20 -0800 (PST) Subject: Re: [RFC 00/17] Merge event loop implementations To: Tom Tromey References: <20190224165153.5062-1-tom@tromey.com> <3ae5ab8e-c219-6510-bb54-b30c1cf2d074@redhat.com> <87mueqslhn.fsf@tromey.com> <52b71425-e839-99fa-5045-8aaa02eafaef@redhat.com> <87a7apeesm.fsf@tromey.com> <87tv3taoxl.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <8972414d-dc31-8826-8a0d-20849c55d1f0@redhat.com> Date: Fri, 14 Feb 2020 17:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87tv3taoxl.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00566.txt.bz2 On 2/14/20 2:21 AM, Tom Tromey wrote: > Tom> However, my hope was that unifying on the gdb approach would be good > Tom> enough. And, while debugging on Windows this week, I happened (I forgot > Tom> to look before starting, so it's kind of a goofy accident) to use this > Tom> event unification branch. I used gdb and also tried gdbserver, and as > Tom> far as I can tell, everything worked fine. > > I rebased this series recently. > > I wasn't sure what the status really was. I thought this at the time: > > Tom> So, my view is that the current patch series is probably roughly ok. > > ... meaning that gdb_fildes_t could be removed and replaced with plain > "int", and nothing else would have to change. > My latest thoughts were here: https://sourceware.org/ml/gdb-patches/2019-09/msg00555.html "In conclusion, I suggest sweeping the issue under the rug for now and cast SOCKET to int for this series, like GDB already does." > I can re-test the series on Windows. The updates due to rebasing were > all mechanical, though, stuff like making sure the files were moved into > the now-correct directories. > > I thought maybe we could use gdb_select in gdbsupport, but now I see it > reaches into the serial code, so maybe that isn't so easy after all. > > Let me know what you think. I can't find a response to my comments to patch 2 and 15, for example. I'm not sure you saw them? Thanks, Pedro Alves