From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kdoZA8hxtWn8NSkAWB0awg (envelope-from ) for ; Sat, 14 Mar 2026 10:33:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SfRMlAcv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 032271E0DD; Sat, 14 Mar 2026 10:33:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 630B71E08D for ; Sat, 14 Mar 2026 10:33:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E48374C318B3 for ; Sat, 14 Mar 2026 14:33:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E48374C318B3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SfRMlAcv Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 228994C31899 for ; Sat, 14 Mar 2026 14:32:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 228994C31899 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 228994C31899 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773498757; cv=none; b=teKxO3Q88+wx08idfkyJZtpz+byvEnosUOAV70FJqA4I8uxzg3PGvqbl6sFXRYLZ4oVEStsinrwcs0+//oW5faZlA5Ois4UDCp1N/gRkdLY6NXvFqWqgUwodRH2b0/jxx/LI3W0GT+BzlUuSeqYXXoCc+QAu/i7010TG6oOauUE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773498757; c=relaxed/simple; bh=4OEKOQEUUzv1MyOf9Ds4senK6s37wud5p9eHL45uB6M=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=fuzyTIXIIjkHTFx8SNKmvrBv6n0yKfaMp8X8EYfg6ZBkBVak9tn1qeECsbycFmqwI2YJeRSlExnKv1TeOjUIuokwQdpFaHQkq392BpoTLcvGZgvMxVzl2Olc/oMPn2PKM5ShMm1WYIGtIvtcdRdtQBgsxMlVQpOVwukU6boqRHA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 228994C31899 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773498756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R7gNw6MwfSVOv39Wv3W0DDR0AxxwFCvyadTP3fD4MAc=; b=SfRMlAcvr1/Ae8Fk/AoYioQd22PkHiNvbOsXIpi9kjB7Tlwybdu7fB3GImHvLCo2qGYElA PZfBgAl+nRZMlkNODBUparG1BPg3nos7nQa0R4j6uY01N40MDsGH+gKq8AvyDGjTF56Kc3 qBh6m67JmCxnemS7Sa4M3exxgx1EUQw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-IIoLNyvfOTmtMBruyzUDMg-1; Sat, 14 Mar 2026 10:32:35 -0400 X-MC-Unique: IIoLNyvfOTmtMBruyzUDMg-1 X-Mimecast-MFC-AGG-ID: IIoLNyvfOTmtMBruyzUDMg_1773498754 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-439fbfd93e8so2248337f8f.0 for ; Sat, 14 Mar 2026 07:32:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773498754; x=1774103554; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R7gNw6MwfSVOv39Wv3W0DDR0AxxwFCvyadTP3fD4MAc=; b=X56SBmkDQt49ou4ogU3yV9JMI8h7PrRnKGagBPVTHjmcumGJavWZCzu+WAETiHflRQ i/sgPutGrjZKEMOJ0fAKPtn5jVNrsIu7o7XPTS698o+Kn44TF3yVlW/NAxcwTao67xYk eS769Knp/lTnromWmxp5Q/5c9JQhludTnhS2/ttc0dTF8Ii8MfcnPXwvPDb9Tbg1uEYh I92xUJBaShbCwFmxAbv0ciGCkubIFbcC/0CzkCqwiuGQn8i/GZsaMnmb94cZl1co0X2w he1obs8l8T3tkB/1Yg7NTEWh0YPTBRfg7tA86s19nlZvhbmSbU46sqbDeGboAwVyZjcl v2tg== X-Gm-Message-State: AOJu0YzYCVNalWt4Kz9czni5gKbSMYai60R2NFlvKPoLhNl4vqUc3lxy z777ug8vUMdcLvtchJkt64WKbPBcHa3zzH/dB9O2MOs9j32k1Xe76oE+lsokU/87gtrClaJ3APO 2FLPy2bOvu4tCVybJJfVkY7LUKzUfWKK+M/Xj+Q0sbLsTJuXcLB7VIKna76kQH1i5HaClFMcj5O MlMbTmU+PX5XOrIM3KfLfCAmu6WcRrAVeseaDx8EaybMviQMQ= X-Gm-Gg: ATEYQzzRrfLhi13o7TZB7SqDVRULTUGw54YpHBRrlR4QEjzm3CyMV2Q7T/b5AXMOSj+ tsczYymltszthCRlnXrz4jamVK08Pd178t1I+ApTmm+y7Sxbhif+6wW6WX95xiKCOPayIAiIAZM q3FdWb4y5dBNwUa/xm5banPw/JGkW+Vmx7d9dqLYNVxvNpUVVnOuDuIytnKU302IEq2Uavd2h5K bDz8FXyYDGvgmNMTUTE6MnVcAMzeodSQNM/DnrWKi/icNeURQgC3myygOTaEWC/vpxF+h7kYtkr 7rX87Wwh/F2A1xoz5JOgTty3TLk8tj3KS3giFDCESWQSNJQ+xbr3kBjUX4voH1ulX6oRk/QwT2J ff8i36NM9XqsPisLRLLufBZCh4XBPu8GtGBm2E6/dY0qq9A== X-Received: by 2002:a05:6000:2584:b0:439:ac6b:dd38 with SMTP id ffacd0b85a97d-43a04db142bmr13253121f8f.31.1773498753724; Sat, 14 Mar 2026 07:32:33 -0700 (PDT) X-Received: by 2002:a05:6000:2584:b0:439:ac6b:dd38 with SMTP id ffacd0b85a97d-43a04db142bmr13253079f8f.31.1773498753244; Sat, 14 Mar 2026 07:32:33 -0700 (PDT) Received: from localhost (92.40.185.182.threembb.co.uk. [92.40.185.182]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe1abf84sm24144515f8f.14.2026.03.14.07.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Mar 2026 07:32:32 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 3/5] gdb: remove 'num' argument from gdbarch_read_core_file_mappings callback Date: Sat, 14 Mar 2026 14:32:20 +0000 Message-Id: <8963a8b9c1b15ee1d4d138323ede9242d5341b84.1773498341.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aU7eHMRBsMdBUzkZfgmtAbHmT480QGL2X-IVcI85MgU_1773498754 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The gdbarch_read_core_file_mappings method takes two callback functions. The second of these, the loop_cb takes a 'num' parameter that is never used. It's not entirely clear what this 'num' represents, and in later commits I'm going to be tweaking what gets sent through this callback, and it's not clear to me how 'num' should be changed. So let's just remove the 'num' argument, this will make the later commits easier. --- gdb/corelow.c | 2 +- gdb/gdbarch.h | 3 +-- gdb/linux-tdep.c | 7 +++---- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index 84f44bc680e..e540e44474b 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -2138,7 +2138,7 @@ gdb_read_core_file_mappings (struct gdbarch *gdbarch, struct bfd *cbfd) /* read_core_file_mappings will invoke this lambda for each mapping that it finds. */ - [&] (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, + [&] (ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename, const bfd_build_id *build_id) { /* Architecture-specific read_core_mapping methods are expected to diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index fe59846b916..356aae0fee8 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -127,8 +127,7 @@ using read_core_file_mappings_pre_loop_ftype = gdb::function_view; using read_core_file_mappings_loop_ftype = - gdb::function_viewtable_header (0, ui_left, "objfile", "File"); current_uiout->table_body (); }, - [=] (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, + [=] (ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename, const bfd_build_id *build_id) { ui_out_emit_tuple tuple_emitter (current_uiout, nullptr); -- 2.25.4